Add NIKKOR Z 135mm f/1.8 S Plena

Add tca data for Olympus ZD ED 50mm f/2 Macro

Upload 8496cb

Add vignetting data for Olympus Zuiko Digital ED 50-200mm f/2.8-3.5 SWD + EC-20 2x extender

Upload a4f993

Update BUG-REPORT.yml

Update BUG-REPORT.yml

Add upload and backtrace

Update BUG-REPORT.yml

Add OpenCL

Update BUG-REPORT.yml

Fix YAML syntax ?

Update BUG-REPORT.yml

Fix YAML syntax

Update BUG-REPORT.yml

Add version and OS

Merge pull request #681 from LebedevRI/uncoalescing

BitVacuumers: delegate byte splitting to the consumer

Extract PartitioningOutputIterator out of BitVacuumer

Create BUG-REPORT.yml

Test template

Github: remove bug report template

Update config.yml

Add Chantal to links

Github: remove feature request template

Create config.yml

Update issue templates

Disable feature requests

BitVacuumer: do advance the iterator

CoalescingOutputIterator: silence clang-tidy's performance-move-constructor-init

BitVacuumerJPEG: do advance the iterator

CoalescingOutputIterator::maybeOutputCoalescedParts(): do advance the iterator

While it doesn't matter for std::*inserter iterators, it is generally a pointer, and that does need to be advanced.

Implement PartitioningOutputIterator

Codecov Report

Attention: Patch coverage is 74.07407% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 60.96%. Comparing base (8a9967c) to head (a8274e1). Report is 3 commits behind head on develop.

@@ Coverage Diff @@
## develop #681 +/- ##
===========================================
+ Coverage 60.91% 60.96% +0.05% 
===========================================
 Files 271 273 +2 
 Lines 16366 16406 +40 
 Branches 2077 2077 
===========================================
+ Hits 9969 10002 +33 
- Misses 6268 6276 +8 
+ Partials 129 128 -1 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Merge pull request #680 from kmilos/kmilos/unsupported

Add placeholders for known unsupported cameras

Add Pergear 60mm f/2.8 MK2 Macro

Upload c6bddc

Add unsupported Canon placeholders

• Canon models using CR3 codec
• Panasonic models using v8 codec

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8a9967c) 60.91% compared to head (58031e3) 60.91%.

@@ Coverage Diff @@
## develop #680 +/- ##
========================================
 Coverage 60.91% 60.91% 
========================================
 Files 271 271 
 Lines 16366 16366 
 Branches 2077 2077 
========================================
 Hits 9969 9969 
 Misses 6268 6268 
 Partials 129 129 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

(I have not verified that each change here does exactly what it says it does.)

Hm i don't know. I guess this makes sense, and seeds the names for RPU sample request thing.

@kmilos thank you.

I guess this makes sense, and seeds the names for RPU sample request thing.

One of the ideas behind it indeed. Another I had in mind is to still have getCamera() return at least something (e.g. sanitized maker/model names and aliases) for as many known cameras as possible.

Add unsupported Panasonic placeholders

Hi there,

I want to help on #367 and want to get some enlightenment to point me out how to test on it. I had build and download the test images from raw.pixls.us, what will be the recommend process of testing?

For example, how can I determine the decompressor is successfully implement? Are there any viewer or way to test the result?

Thanks!

I'm not sure what the specific question is. You know that it is successfully implemented when, after compiling darktable with updated rawspeed submodule, the images load correctly in darktable :)

See also https://github.com/darktable-org/rawspeed/blob/develop/docs/IntegrationTesting.rst. And:

rawspeed/build-Clang17-releaseWithAsserts$ ./src/utilities/rstest/rstest 
usage: ./src/utilities/rstest/rstest
 [-h] print this help
 [-c] for each file: decode, compute hash and store it.
 If hash exists, it does not recompute it, unless option -f is set!
 [-f] if -c is set, then it will final the existing hashes.
 If -c is not set, and the hash does not exist, then just decode,
 but do not write the hash!
 [-d] store decoded image as PPM
 the file[s] to work on.

With no options given, each raw with an accompanying hash will be decoded
 and compared (unless option -f is set!) to the existing hash. A summary of
 all errors/failed hash comparisons will be reported at the end.

Suggested workflow for easy regression testing:
 1. remove all .hash files and build 'trusted' version of this program
 2. run with option '-c' -> creates .hash for all supported files
 3. build new version to test for regressions
 4. run with no option -> checks files with existing .hash
 If the second run shows no errors, you have no regressions,
 otherwise, the diff between hashes is appended to rstest.log

Thanks for the swift reply!

I'm not sure what the specific question is. You know that it is successfully implemented when, after compiling darktable with updated rawspeed submodule, the images load correctly in darktable :)

I would like to know more about the workflow, do you directly working in the darktable rawspeed-submodule and rebuild the darktable after modifying the rawspeed?

Since it will open up a relative heavy GUI, are there any way to prevent this, or there is a lightweight viewer that also depend on rawspeed?

Also, any suggestion on attaching the GDB for debugging/tracing purpose? Is it still need to attach to rebuilt darktable?

Thanks!

I'm not sure what the specific question is. You know that it is successfully implemented when, after compiling darktable with updated rawspeed submodule, the images load correctly in darktable :)

I would like to know more about the workflow, do you directly working in the darktable rawspeed-submodule and rebuild the darktable after modifying the rawspeed?

Generally almost never, but everyones's mileage may differ.

Again, it depends on what you want to achieve. You could just build the rawspeed as a standalone project, and, as noted in the blurb i posted, use $ ./src/utilities/rstest/rstest -d to produce a PPM/PFM of the decoded image.

Again, it depends on what you want to achieve. You could just build the rawspeed as a standalone project, and, as noted in the blurb i posted, use $ ./src/utilities/rstest/rstest -d to produce a PPM/PFM of the decoded image.

Thanks for pointing me out! I tried rstest and stored the PPM, put the PPM back into darktable and adjust the exposure to get the image back! (btw, are there any viewer that is not darktable support adjusting exposure on the fly?)

So if the new decompressor works will, the above workflow should work, right?

Thanks for pointing me out! I tried rstest and stored the PPM, put the PPM back into darktable and adjust the exposure to get the image back!

Usually it's not quite An Image, since usually a demosaicing is needed, which doesn't happen for PPM's, but it's enough to get a rough view, i guess.

(btw, are there any viewer that is not darktable support adjusting exposure on the fly?)

I can't parse the question, sorry.

So if the new decompressor works will, the above workflow should work, right?

I guess so?

@mlouielu thank you for taking a look at that!

I suppose you can open the PGM in GIMP and hit Colors -> Auto -> Stretch Contrast... (or any other tool having similar functionality, like Adjustments -> Auto-Level in paint.NET on Windows etc.)

It'll be still CFA mosaiced and grayscale, but should at least give you an idea if there is a "sensible" image behind it or just garbage.

Or, you could even temporarily just hack the rstest code to write out the PGM as MSB aligned and there's no need for external programs for exposure compensation then.

You can also avoid any code changes and use pamdepth 65535 to shift the PGM up to 16b, then use pnmhisteq/pnmnorm to enhance, and then pamtopng/pnmtopng (or any other output format to view in any sw): https://netpbm.sourceforge.net/doc/directory.html

I'm sure you can do the equivalent w/ ImageMagick/GraphicsMagick as well on one line...

Skip to content

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

{{ message }}

darktable-org

/

rawspeed

Public

Notifications

Fork 116

Star 325

Issues: darktable-org/rawspeed

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 Open

118 Closed

72 Open

118 Closed

Assigned to nobody

Newest

Oldest

Most commented

Least commented

Recently updated

Least recently updated

Best match

Most reactions

👍

👎

😄

🎉

😕

❤️

🚀

👀

Issues list

How to help for developing new decompressor?

679

opened Feb 22, 2024 by mlouielu

9

Probable overscanning of sony ILCE-7M4 APS-C cropped RAWs

520

opened Sep 18, 2023 by koolfy

13

On the use of dithering when decompressing lossless NEF files

518

opened Sep 13, 2023 by mallman

1

Support JPEG XL compression in DNG

516

opened Sep 1, 2023 by kmilos

4

DNG opcode level 2 support

incomplete

lacks-RPU-samples

506

opened Jul 31, 2023 by jcampbell05

8

src/librawspeed/README.md is out of date

491

opened Jun 30, 2023 by mallman

4

Website died

489

opened Jun 24, 2023 by aurelienpierre

Fujifilm X-T5 Raw compressed doesn't work in github version

411

opened Dec 14, 2022 by ghost

5

Olympus white level

392

opened Oct 28, 2022 by paolodepetrillo

5

We don't sample black areas unless asked to scale black/white. Is that what we really want?

390

opened Oct 21, 2022 by LebedevRI

RawImageDataU16::calculateBlackAreas() only looks at a single pixel o_O

389

opened Oct 21, 2022 by LebedevRI

Different white/black point, Canon EOS 30D

377

opened Jul 25, 2022 by PeterWem

Panasonic DC-GH6 raws are version 8 - new decompressor needed

367

opened Jun 1, 2022 by LebedevRI

6

Fujifilm GFX100 (non-lossless) "compressed" raw support

366

opened May 30, 2022 by LebedevRI

Nikon D7000 raw white level too high

359

opened May 11, 2022 by kofa73

1

failure to process certain DNG files (Leica M246)

343

opened Feb 9, 2022 by ubergeek801

7

[2022-12] Revert temporary patches that resurrected support for cameras lacking sample coverage

338

opened Jan 9, 2022 by LebedevRI

Fujifilm X-E4 (non-lossless) "compressed" raw support

332

opened Dec 19, 2021 by vfonov

Investigate Halide dependency

325

opened Dec 7, 2021 by LebedevRI

pointer to guidelines or requirements for tests

320

opened Nov 9, 2021 by homberghp

Kodak DCS 520c, issues with ISO

311

opened Oct 9, 2021 by PeterWem

2

White level for Canon EOS Rebel T3

285

opened Aug 9, 2021 by photopea

3

need canon eos m6 mark ii support

284

opened Jul 25, 2021 by jheidemann

1

Exif data from Silverfast DNG causes rawspeed to fail

283

opened Jul 9, 2021 by 0x10

1

9

DNG GainMap opcode support

267

opened Apr 21, 2021 by paolodepetrillo

4

Previous 1 2 3 Next

Previous Next

ProTip! Exclude everything labeled bug with -label:bug .

You can’t perform that action at this time.

https://github.com/darktable-org/darktable/issues/16297

Using latest ADC 16.2

Crops are not verified, waiting for RPU samples.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.91%. Comparing base (8a9967c) to head (785a599). Report is 10 commits behind head on develop.

@@ Coverage Diff @@
## develop #677 +/- ##
========================================
 Coverage 60.91% 60.91% 
========================================
 Files 271 271 
 Lines 16366 16366 
 Branches 2077 2077 
========================================
 Hits 9969 9969 
 Misses 6268 6268 
 Partials 129 129 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Checked, still no sample uploads.

Merge pull request #676 from LebedevRI/recoalescing

CoalescingOutputIterator: non-byte parts

CoalescingOutputIterator: allow non-byte parts

BitVacuumerBenchmark: also benchmark with-coalescing paths

Merge pull request #675 from LebedevRI/bitvacuumer-perf

Make some use of CoalescingOutputIterator

BitVacuumerJPEG: add fast-path for the happy path

Comparing bench/librawspeed/bitstreams/BitVacuumerJPEGBenchmark-old to bench/librawspeed/bitstreams/BitVacuumerJPEGBenchmark
Benchmark Time CPU Time Old Time New CPU Old CPU New
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
BM/Stuffed/2097152_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM/Stuffed/2097152_mean +0.0125 +0.0126 6205 6282 6204 6282
BM/Stuffed/2097152_median +0.0125 +0.0127 6204 6282 6203 6282
BM/Stuffed/2097152_stddev +3.9793 +3.9137 2 10 2 10
BM/Stuffed/2097152_cv +3.9180 +3.8527 0 0 0 0
BM>/Stuffed/2097152_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM>/Stuffed/2097152_mean -0.0349 -0.0348 6453 6228 6452 6227
BM>/Stuffed/2097152_median -0.0338 -0.0338 6447 6229 6446 6228
BM>/Stuffed/2097152_stddev -0.8191 -0.8192 41 7 41 7
BM>/Stuffed/2097152_cv -0.8125 -0.8126 0 0 0 0
BM>/Stuffed/2097152_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM>/Stuffed/2097152_mean -0.1021 -0.1020 5819 5225 5819 5225
BM>/Stuffed/2097152_median -0.1015 -0.1015 5816 5225 5815 5225
BM>/Stuffed/2097152_stddev -0.6999 -0.6951 10 3 10 3
BM>/Stuffed/2097152_cv -0.6658 -0.6605 0 0 0 0
BM>/Stuffed/2097152_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM>/Stuffed/2097152_mean -0.0482 -0.0482 5681 5408 5681 5407
BM>/Stuffed/2097152_median -0.0482 -0.0482 5682 5408 5682 5408
BM>/Stuffed/2097152_stddev +0.3751 +0.3802 3 4 3 4
BM>/Stuffed/2097152_cv +0.4448 +0.4500 0 0 0 0
BM/Unstuffed/2097152_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM/Unstuffed/2097152_mean -0.0402 -0.0401 6508 6247 6508 6246
BM/Unstuffed/2097152_median -0.0401 -0.0400 6508 6247 6508 6247
BM/Unstuffed/2097152_stddev +15.3546 +21.8853 1 9 0 9
BM/Unstuffed/2097152_cv +16.0395 +22.8421 0 0 0 0
BM>/Unstuffed/2097152_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM>/Unstuffed/2097152_mean -0.0328 -0.0328 6414 6203 6413 6203
BM>/Unstuffed/2097152_median -0.0317 -0.0318 6409 6206 6409 6205
BM>/Unstuffed/2097152_stddev -0.7829 -0.7804 38 8 38 8
BM>/Unstuffed/2097152_cv -0.7756 -0.7729 0 0 0 0
BM>/Unstuffed/2097152_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM>/Unstuffed/2097152_mean -0.0982 -0.0983 5939 5356 5939 5355
BM>/Unstuffed/2097152_median -0.0984 -0.0985 5939 5355 5939 5354
BM>/Unstuffed/2097152_stddev +0.0997 +0.1317 3 4 3 4
BM>/Unstuffed/2097152_cv +0.2194 +0.2550 0 0 0 0
BM>/Unstuffed/2097152_pvalue 0.0062 0.0062 U Test, Repetitions: 9 vs 9
BM>/Unstuffed/2097152_mean +0.0041 +0.0041 5545 5568 5545 5568
BM>/Unstuffed/2097152_median +0.0044 +0.0045 5544 5569 5543 5568
BM>/Unstuffed/2097152_stddev +5.5353 +5.1423 3 17 3 17
BM>/Unstuffed/2097152_cv +5.5087 +5.1171 0 0 0 0
BM/Unstuffed/2097152_pvalue 0.0062 0.0062 U Test, Repetitions: 9 vs 9
BM/Unstuffed/2097152_mean +0.0048 +0.0048 6243 6273 6242 6272
BM/Unstuffed/2097152_median +0.0061 +0.0061 6235 6273 6234 6272
BM/Unstuffed/2097152_stddev -0.5808 -0.5713 18 7 18 8
BM/Unstuffed/2097152_cv -0.5827 -0.5733 0 0 0 0
BM>/Unstuffed/2097152_pvalue 0.0423 0.0423 U Test, Repetitions: 9 vs 9
BM>/Unstuffed/2097152_mean -0.0028 -0.0028 6017 6000 6016 5999
BM>/Unstuffed/2097152_median -0.0034 -0.0033 6022 6001 6021 6001
BM>/Unstuffed/2097152_stddev -0.7949 -0.7906 22 4 22 5
BM>/Unstuffed/2097152_cv -0.7944 -0.7900 0 0 0 0
BM>/Unstuffed/2097152_pvalue 0.0036 0.0036 U Test, Repetitions: 9 vs 9
BM>/Unstuffed/2097152_mean +0.0005 +0.0006 5109 5112 5108 5111
BM>/Unstuffed/2097152_median +0.0006 +0.0006 5108 5111 5108 5111
BM>/Unstuffed/2097152_stddev -0.3388 -0.2929 2 1 1 1
BM>/Unstuffed/2097152_cv -0.3391 -0.2933 0 0 0 0
BM>/Unstuffed/2097152_pvalue 0.0047 0.0047 U Test, Repetitions: 9 vs 9
BM>/Unstuffed/2097152_mean -0.0023 -0.0022 5055 5043 5054 5043
BM>/Unstuffed/2097152_median -0.0024 -0.0023 5056 5044 5056 5044
BM>/Unstuffed/2097152_stddev +0.4571 +0.4766 6 9 6 9
BM>/Unstuffed/2097152_cv +0.4604 +0.4798 0 0 0 0
OVERALL_GEOMEAN -0.0290 -0.0290 0 0 0 0

CoalescingOutputIterator: actually conform to the output iterator concept

BitVacuumerJPEGBenchmark: benchmarks with-coalescing too

CoalescingOutputIteratorBenchmark: parametrize coalescization

BitVacuumerJPEGBenchmark: parametrize some more

CoalescingOutputIterator: provide dummy container_type, with value_type

CoalescingOutputIterator: a few more invariants

CoalescingOutputIterator: disallow type conversion in ctor, use universal reference

BitVacuumer: disallow type conversion in ctor, use universal reference

BitVacuumerBenchmark: just don't deal with JPEG here

BitVacuumerJPEG: actually require that the output iterator takes bytes

BitVacuumer: actually require that the output iterator takes bytes

CoalescingOutputIteratorTest: add missing include

correction

Add 7Artisans 35mm f/0.95

Upload f23ad5

Add Olympus Zuiko Digital ED 50-200mm f/2.8-3.5 SWD + EC-14 1.4x extender

upload 2474a3

Add vignetting data for Olympus Zuiko Digital ED 50-200mm f/2.8-3.5 SWD

update 17ee75

Add Fujifilm X100VI

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6f1a5bf) 60.94% compared to head (ae1a159) 60.86%.

@@ Coverage Diff @@
## develop #675 +/- ##
===========================================
- Coverage 60.94% 60.86% -0.08% 
===========================================
 Files 271 271 
 Lines 16327 16342 +15 
 Branches 2075 2077 +2 
===========================================
- Hits 9950 9947 -3 
- Misses 6249 6268 +19 
+ Partials 128 127 -1 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Merge pull request #674 from LebedevRI/CoalescingOutputIterator

Implement CoalescingOutputIterator

Implement CoalescingOutputIterator

$ bench/librawspeed/adt/CoalescingOutputIteratorBenchmark
2024-02-20T02:27:50+03:00
Running bench/librawspeed/adt/CoalescingOutputIteratorBenchmark
Run on (32 X 3397.05 MHz CPU s)
CPU Caches:
 L1 Data 32 KiB (x16)
 L1 Instruction 32 KiB (x16)
 L2 Unified 512 KiB (x16)
 L3 Unified 32768 KiB (x2)
Load Average: 1.16, 1.08, 1.12
------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
------------------------------------------------------------------------------------------
BM_Broadcast/16777216 9893 us 9893 us 70 Latency=589.649ps Throughput=1.57945Gi/s
BM_Broadcast/16777216 4948 us 4948 us 141 Latency=294.908ps Throughput=3.15801Gi/s
BM_Broadcast/16777216 3711 us 3710 us 189 Latency=221.16ps Throughput=4.21109Gi/s
BM_Broadcast/16777216 3708 us 3708 us 189 Latency=220.986ps Throughput=4.21439Gi/s
BM_Copy/16777216 8115 us 8114 us 85 Latency=483.656ps Throughput=1.92559Gi/s
BM_Copy/16777216 3533 us 3533 us 198 Latency=210.609ps Throughput=4.42204Gi/s
BM_Copy/16777216 1730 us 1730 us 402 Latency=103.111ps Throughput=9.03223Gi/s
BM_Copy/16777216 1301 us 1301 us 536 Latency=77.538ps Throughput=12.0112Gi/s

Will be rather useful for BitVacuumer perf work.

$ bench/librawspeed/adt/CoalescingOutputIteratorBenchmark
2024-02-20T02:27:50+03:00
Running bench/librawspeed/adt/CoalescingOutputIteratorBenchmark
Run on (32 X 3397.05 MHz CPU s)
CPU Caches:
 L1 Data 32 KiB (x16)
 L1 Instruction 32 KiB (x16)
 L2 Unified 512 KiB (x16)
 L3 Unified 32768 KiB (x2)
Load Average: 1.16, 1.08, 1.12
------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
------------------------------------------------------------------------------------------
BM_Broadcast/16777216 9893 us 9893 us 70 Latency=589.649ps Throughput=1.57945Gi/s
BM_Broadcast/16777216 4948 us 4948 us 141 Latency=294.908ps Throughput=3.15801Gi/s
BM_Broadcast/16777216 3711 us 3710 us 189 Latency=221.16ps Throughput=4.21109Gi/s
BM_Broadcast/16777216 3708 us 3708 us 189 Latency=220.986ps Throughput=4.21439Gi/s
BM_Copy/16777216 8115 us 8114 us 85 Latency=483.656ps Throughput=1.92559Gi/s
BM_Copy/16777216 3533 us 3533 us 198 Latency=210.609ps Throughput=4.42204Gi/s
BM_Copy/16777216 1730 us 1730 us 402 Latency=103.111ps Throughput=9.03223Gi/s
BM_Copy/16777216 1301 us 1301 us 536 Latency=77.538ps Throughput=12.0112Gi/s

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (953b136) 60.68% compared to head (c862016) 60.93%. Report is 2 commits behind head on develop.

@@ Coverage Diff @@
## develop #674 +/- ##
===========================================
+ Coverage 60.68% 60.93% +0.25% 
===========================================
 Files 268 271 +3 
 Lines 16193 16326 +133 
 Branches 2062 2075 +13 
===========================================
+ Hits 9826 9949 +123 
- Misses 6239 6249 +10 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

meson: update subprojects

Signed-off-by: Rosen Penev

unitTests: fix sign comparison warnings

Signed-off-by: Rosen Penev

Add vignetting data for Olympus Zuiko Digital ED 50mm f/2.0 Macro

upload 38c228

Merge pull request #673 from kmilos/kmilos/panny_tz95d

Add Panasonic DC-TZ95D alias

In keeping w/ the tradition, the "D" seems to denote just the back LCD panel refresh.

Resolves https://github.com/darktable-org/darktable/issues/16353

https://github.com/darktable-org/darktable/issues/16353 also mentions ZS-80, is that something we should also add?

Ah, we have that as ZS80.

@kmilos thank you!

One could in theory also add TZ97, TZ96D and ZS80D...

Add Panasonic DC-TZ95D alias

Add Olympus Zuiko Digital 70-300mm F4.0-5.6

upload 1d2581

Add Olympus Zuiko Digital Pro ED 35-100mm F2.0

upload c934d7

updated vignetting data

Olympus Zuiko Digital ED 14-35mm F2.0 SWD Olympus Zuiko Digital ED 12-60mm f/2.8-4.0 SWD

Merge pull request #671 from LebedevRI/bitvacuumerjpeg-perf

Implement simple BitVacuumerJPEGBenchmark

Implement simple BitVacuumerJPEGBenchmark

JPEGStuffedByteStreamGenerator: optionally don't produce stuffing byte

Rename JPEGUnstuffedByteStreamGenerator as NonJPEGByteStreamGenerator

Extract JPEG{,Un}StuffedByteStreamGenerator out of BitStreamerJPEGBenchmark

Much like with Streamer, 0xFF byte is special, so if we want to know the true perf of BitVacuumerJPEG, we need to feed it the true JPEG-like stream, with 0xFF bytes, occurring at the same frequency as with BitStreamerJPEGBenchmark

Merge pull request #665 from LebedevRI/bitstream-perf

Add very crude BitVacuumer benchmark

BitVacuumer::put(): don't special-case zero bit count

Comparing bench/librawspeed/bitstreams/BitVacuumerBenchmark-old to bench/librawspeed/bitstreams/BitVacuumerBenchmark
Benchmark Time CPU Time Old Time New CPU Old CPU New
--------------------------------------------------------------------------------------------------------------------------------------
BM/4194304_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM/4194304_mean -0.0691 -0.0691 8 8 8 8
BM/4194304_median -0.0712 -0.0712 8 7 8 7
BM/4194304_stddev +10.3823 +10.4597 0 0 0 0
BM/4194304_cv +11.2274 +11.3106 0 0 0 0
BM/4194304_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM/4194304_mean -0.0649 -0.0649 8 7 8 7
BM/4194304_median -0.0648 -0.0648 8 7 8 7
BM/4194304_stddev +1.0849 +1.0516 0 0 0 0
BM/4194304_cv +1.2297 +1.1941 0 0 0 0
BM/4194304_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM/4194304_mean -0.0345 -0.0345 8 8 8 8
BM/4194304_median -0.0325 -0.0325 8 8 8 8
BM/4194304_stddev -0.6149 -0.6124 0 0 0 0
BM/4194304_cv -0.6011 -0.5986 0 0 0 0
BM/4194304_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM/4194304_mean -0.0544 -0.0544 8 7 8 7
BM/4194304_median -0.0543 -0.0543 8 7 8 7
BM/4194304_stddev -0.2789 -0.2807 0 0 0 0
BM/4194304_cv -0.2374 -0.2393 0 0 0 0
BM/4194304_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
BM/4194304_mean -0.1186 -0.1186 9 8 9 8
BM/4194304_median -0.1153 -0.1153 9 8 9 8
BM/4194304_stddev -0.8102 -0.8112 0 0 0 0
BM/4194304_cv -0.7847 -0.7858 0 0 0 0
OVERALL_GEOMEAN -0.0687 -0.0687 0 0 0 0

BitStreamCacheBase::push(): allow pushing zero bits

When push() is called by BitStreamer, count is a constant integer, so we'll drop the zero check.

Add very crude BitVacuumer benchmark

Merge pull request #670 from LebedevRI/byte

Make BitStreamer more byte-friendly

Cleanup includes

BitStreamerJPEG::fillCache(): when there's 0xFF byte, we consume at least 5 bytes

VariableLengthLoad: operate on std::byte

BitStreamerJPEG::fillCache(): when encountering end-of-stream we consume at least 6 bytes

Comparing bench/librawspeed/bitstreams/BitStreamerJPEGBenchmark-old to bench/librawspeed/bitstreams/BitStreamerJPEGBenchmark
Benchmark Time CPU Time Old Time New CPU Old CPU New
--------------------------------------------------------------------------------------------------------------------------------------------
BM/Stuffed/16777216_pvalue 0.1000 0.1000 U Test, Repetitions: 3 vs 3. WARNING: Results unreliable! 9+ repetitions recommended.
BM/Stuffed/16777216_mean -0.1233 -0.1233 9396 8238 9396 8237
BM/Stuffed/16777216_median -0.1240 -0.1240 9403 8237 9402 8237
BM/Stuffed/16777216_stddev -0.7235 -0.7254 14 4 14 4
BM/Stuffed/16777216_cv -0.6846 -0.6868 0 0 0 0
BM/Unstuffed/16777216_pvalue 0.1000 0.1000 U Test, Repetitions: 3 vs 3. WARNING: Results unreliable! 9+ repetitions recommended.
BM/Unstuffed/16777216_mean -0.1439 -0.1439 8665 7419 8665 7419
BM/Unstuffed/16777216_median -0.1446 -0.1446 8673 7419 8673 7419
BM/Unstuffed/16777216_stddev -0.9929 -0.9894 14 0 14 0
BM/Unstuffed/16777216_cv -0.9917 -0.9876 0 0 0 0
BM/Unstuffed/16777216_pvalue 0.1000 0.1000 U Test, Repetitions: 3 vs 3. WARNING: Results unreliable! 9+ repetitions recommended.
BM/Unstuffed/16777216_mean +0.3519 +0.3519 1828 2472 1828 2471
BM/Unstuffed/16777216_median +0.3528 +0.3528 1827 2472 1827 2471
BM/Unstuffed/16777216_stddev -0.9250 -0.9228 2 0 2 0
BM/Unstuffed/16777216_cv -0.9445 -0.9429 0 0 0 0
OVERALL_GEOMEAN +0.0049 +0.0049 0 0 0 0

BitStreamer: operate on std::byte

Revert "Merge remote-tracking branch 'upstream/pr/668' into develop"

While waiting until this was time to do this, i forgot the prep step of splitting the cast into sub-cast steps. Let's do that first.

This reverts commit 446a71d613fb32d94fd1d5253b334f491b9a37db, reversing changes made to 63844eab69644ffc9949c6a9e4b2e0f9fb68a27e.

This reverts commit 8aae6c9a86abeca5cec20c42046ff9a8993b67bd. This reverts commit 70de40e352cb9ac4db3f00c7b2f9e712c3ba3d65.

TiffEntry::getFloat(): cast is not lossless

Merge pull request #669 from LebedevRI/bit

Drop some `` bits

Drop countl_zero()/countl_one()

Drop bit_cast

ThreefrDecoder::decodeMetaDataInternal(): casts are not lossless

TiffDecoderFuzzer-ThreefrDecoder: /src/librawspeed/src/librawspeed/decoders/../adt/Casts.h:66: Ttgt rawspeed::lossless_cast(Tsrc) [Ttgt = int, Tsrc = float]: Assertion `impl::is_bitwise_identical(roundTrippedValue, value)' failed.
<...>
#9 0x6314b4 in rawspeed::ThreefrDecoder::decodeMetaDataInternal(rawspeed::CameraMetaData const*) /src/librawspeed/src/librawspeed/decoders/ThreefrDecoder.cpp

Merge remote-tracking branch 'upstream/pr/668' into develop

• upstream/pr/668: Casts.h: use concepts, not is_*_v ngDecoder::decodeBlackLevels(): cast is not lossless NefDecoder::DecodeNikonSNef(): cast is not lossless DngOpcodes: PolynomialMap: cast is not lossless IiqDecoder::PhaseOneFlatField(): cast is not lossless VC5Decompressor: decompand(): cast is not lossless Spline::calculateCurve(): cast is not lossless lossless_cast(): actually enforce the invariant Finally rename implicit_cast as lossless_cast

Casts.h: use concepts, not is_*_v

ngDecoder::decodeBlackLevels(): cast is not lossless

#6 0x00005555555f3170 in rawspeed::lossless_cast (value=) at /home/lebedevri/rawspeed/src/librawspeed/decoders/../adt/Casts.h:66
 newValue = 
 roundTrippedValue = 
#7 0x00005555555f3170 in rawspeed::DngDecoder::decodeBlackLevels (this=, raw=)
 blackdim = 
 black_entry =

NefDecoder::DecodeNikonSNef(): cast is not lossless

DngOpcodes: PolynomialMap: cast is not lossless

#6 0x0000555555616009 in rawspeed::lossless_cast (value=) at /home/lebedevri/rawspeed/src/librawspeed/common/../adt/Casts.h:66
 newValue = 
 roundTrippedValue =

IiqDecoder::PhaseOneFlatField(): cast is not lossless

#6 0x000055555561cc9d in rawspeed::lossless_cast (value=) at /home/lebedevri/rawspeed/src/librawspeed/decoders/../adt/Casts.h:66
 newValue = 
 roundTrippedValue =

VC5Decompressor: decompand(): cast is not lossless

#6 0x0000555555607eb4 in rawspeed::lossless_cast (value=1.0000463170273877) at /home/lebedevri/rawspeed/src/librawspeed/decompressors/../adt/Casts.h:67
 newValue = 1
 roundTrippedValue = 1

Spline::calculateCurve(): cast is not lossless

[----------] Global test environment tear-down
[==========] 668 tests from 12 test suites ran. (397 ms total)
[ PASSED ] 666 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] SplineDeathTest.ClampUshort16Min
[ FAILED ] SplineDeathTest.ClampUshort16Max

lossless_cast(): actually enforce the invariant

Finally rename implicit_cast as lossless_cast

Surprisingly few of these casts ended up being non-lossless, but oss-fuzz will likely help with that :)

CMake: document basic type assumptions

Just so i can stop worrying about things that are impossible.

Merge pull request #666 from LebedevRI/six-hundred-sixty-six

Require XCode 15.2 / libc++-16 / clang-15

Is your feature request related to a problem?

No.

Describe the solution you would like

I would like to request a feature that would make it easier to install and update exiv2 on Windows using the winget tool, which is a command-line interface to the Windows Package Manager service, part of the App Installer. You can learn more about winget here,here.

To support winget installation, you would need to create and submit a manifest file to the winget-pkgs repository2, which is the source for the packages available through winget. The manifest file contains the metadata and installer URLs for your software. You can use the winget-create tool3 to help you generate or update the manifest file.

Describe alternatives you have considered

No.

Desktop

• OS and version: windows

Any packaging/delivery of exiv2 is out of scope for the project.

Please feel to contact the winget project/packagers directly, or contribute the PR there and maintain winget delivery yourself.

Thank you for your understanding and contribution!

Thank you @kmilos It seems someone already submitted a PR. 😊

Require XCode 15.2 / LLVM15 (not LLVM16!), GCC is unaffected

Merge pull request #667 from LebedevRI/prep

Split prep changes from PR666

oss-fuzz: build our own libc++-16

oss-fuzz comes with LLVM15-ish, but that (aside from macOS, which comes with LLVM16), is the only libc++-based distro, so it looks like we can get away with requiring libc++-16.

It is a pity that we have to support clang-15, but that is much more invasive of a change.

Refs. https://github.com/google/oss-fuzz/issues/9989

oss-fuzz: don't expect cmake generator to be Make

oss-fuzz: print sizes of build / install directories

oss-fuzz: use Ninja generator

CMake: also check version of C++ standard library's implementation

oss-fuzz: use lld / echo all commands

CI: add macos-13 / XCode 15.2 job

See https://github.com/darktable-org/rawspeed/pull/663

LLVM16 migrated into debian stable. macOS 12 will become EOL in summer.

Therefore, for the summer dt release, we can require macOS 13 + XCode 15.2, which means we'll be able to bump required LLVM version up to 15 or even 16.

... but here let's just prepare for the bump. It's best to discover issues before that.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (686394b) 60.41% compared to head (86297c7) 60.41%.

@@ Coverage Diff @@
## develop #667 +/- ##
========================================
 Coverage 60.41% 60.41% 
========================================
 Files 264 264 
 Lines 16093 16093 
 Branches 2052 2052 
========================================
 Hits 9723 9723 
 Misses 6242 6242 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Restore localisation of error messages/exceptions

Signed-off-by: Jim Easterbrook (cherry picked from commit a3985001b13132ce4841bf1170626f7ef8f9dae7)

This is an automatic backport of pull request #2924 done by Mergify.

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport will backport this PR on `` branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (28fa956) 64.57% compared to head (dbb9a80) 64.57%. Report is 2 commits behind head on main.

@@ Coverage Diff @@
## main #2926 +/- ##
=======================================
 Coverage 64.57% 64.57% 
=======================================
 Files 104 104 
 Lines 22196 22196 
 Branches 10882 10882 
=======================================
 Hits 14332 14332 
 Misses 5622 5622 
 Partials 2242 2242 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d5b6ccd) 64.57% compared to head (13c7fb9) 64.57%.

@@ Coverage Diff @@
## main #2925 +/- ##
=======================================
 Coverage 64.57% 64.57% 
=======================================
 Files 104 104 
 Lines 22196 22196 
 Branches 10882 10882 
=======================================
 Hits 14332 14332 
 Misses 5622 5622 
 Partials 2242 2242 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Bump CMake version

CMake 3.25 is avaliable in debian stable / Fedora 36, but ubuntu 22.04 still has 3.22, and kitware's cmake apt repo for focal only provides 3.24.2

So at the moment, only require 3.22

CMake: add_specialized_fuzzer() needs to be a macro

With CMake 3.21's policies, the list of all fuzzers variable does not get appended when it is called multiple times.

Add vignetting profile for Olympus Zuiko Digital ED 12-60mm f/2.8-4.0 SWD

Upload d676be

Add vignetting profile for Olympus Zuiko Digital ED 14-35mm F2.0 SWD

Upload 07d280

See https://github.com/darktable-org/rawspeed/pull/663

LLVM16 migrated into debian stable. macOS 12 will become EOL in summer.

Therefore, for the summer dt release, we can require macOS 13 + XCode 15.2, which means we'll be able to bump required LLVM version up to 15 or even 16.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2c9444b) 60.41% compared to head (1520a43) 60.41%.

@@ Coverage Diff @@
## develop #666 +/- ##
========================================
 Coverage 60.41% 60.41% 
========================================
 Files 264 264 
 Lines 16093 16093 
 Branches 2052 2052 
========================================
 Hits 9723 9723 
 Misses 6242 6242 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

I would be afraid to merge this one! 😨

And not passing at that... should be telling us something!

:imp: :imp: :imp:

(this is waiting at least on the dt 4.6.1 release)

Ha!

dt 4.6.1 has been released, and oss-fuzz appears happy with #667. Let's merge this into darktable and see what rest of CI says.

Since v0.28.0 libexiv2's error messages have not been localised. This small change adds the _() gettext function to localise the error message before doing the %n substitutions.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f1632fe) 64.66% compared to head (edda8ed) 64.66%. Report is 1 commits behind head on 0.28.x.

@@ Coverage Diff @@
## 0.28.x #2924 +/- ##
=======================================
 Coverage 64.66% 64.66% 
=======================================
 Files 104 104 
 Lines 22169 22169 
 Branches 10839 10839 
=======================================
 Hits 14335 14335 
 Misses 5590 5590 
 Partials 2244 2244 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Are the messages themselves marked w/ N_()?

Are the messages themselves marked w/ N_()?

Yes. See https://github.com/Exiv2/exiv2/blob/84ce408771859570d2534effaaecb3dbf535b1c4/src/error.cpp#L14

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (686394b) 60.41% compared to head (1dbcfd5) 60.55%. Report is 35 commits behind head on develop.

@@ Coverage Diff @@
## develop #665 +/- ##
===========================================
+ Coverage 60.41% 60.55% +0.13% 
===========================================
 Files 264 265 +1 
 Lines 16093 16148 +55 
 Branches 2052 2056 +4 
===========================================
+ Hits 9723 9778 +55 
 Misses 6242 6242 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Merge pull request #664 from LebedevRI/prefix-code-encoder

Prefix code encoder: rest of the flavors / decoders

Prefix code encoder fuzzer: check all decoder implementations

Prefix code encoder: support VC5Code flavor

Prefix code encoder fuzzer: check two decoder implementations

CI-rpuu.yml: actually use bookworm, not trixie

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (190e592) 60.55% compared to head (13deccc) 60.41%.

@@ Coverage Diff @@
## develop #664 +/- ##
===========================================
- Coverage 60.55% 60.41% -0.14% 
===========================================
 Files 264 264 
 Lines 16057 16093 +36 
 Branches 2052 2052 
===========================================
 Hits 9723 9723 
- Misses 6206 6242 +36 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Merge remote-tracking branch 'upstream/pr/663' into develop

• upstream/pr/663: compiler-versions.cmake: 2024 edition

Merge remote-tracking branch 'upstream/pr/662' into develop

• upstream/pr/662: Bit counting is missing in clang14 PrefixCodeEncoder: support DNG 1.0 LJpeg stream flavor PrefixCodeEncoder: support full (difference) encoding

LLVM16 migrated into debian stable. macOS 12 will become EOL in summer.

Therefore, for the summer dt release, we can require macOS 13 + XCode 15.2, which means we'll be able to bump required LLVM version up to 15 or even 16.

@TurboGit @zisoft FYI ^ I'm really looking forward dropping at least the LLVM14 support.

Yes, that's the plan and I have already made some tests with the macos-13 runner. Unfortunately, Xcode 15 segfaults on this runner when compiling src/common/iop_profile.c: 15945. Does not happen with Xcode 14.

Is there something special in iop_profile.c? I have opened this issue in the hope that some compiler experts can have a look.

Yes, that's the plan and I have already made some tests with the macos-13 runner.

Do you think the bump could happen right after the next point release of stable series of dt? (pending https://github.com/darktable-org/darktable/issues/15945 ?)

@zisoft : There is some DT_CLONE_TARGETS on this unit, but that's not the only one. It a a somewhat large file too 66k but nothing huge. So not sure why iop_profile.c crash the compiler here.

@LebedevRI : Seems like LLVM version 16 in Debian is not in stable but in testing at the moment.

@LebedevRI : Seems like LLVM version 16 in Debian is not in stable but in testing at the moment.

Are you sure you are not mixing up LLVM 17 and LLVM 16? LLVM17 is in testing and not stable, but LLVM16 did migrate into stable: https://packages.debian.org/bookworm/clang-16

That's strange...

$ apt policy llvm
llvm:
 Installé : (aucun)
 Candidat : 1:16.0-57
 Table de version :
 1:16.0-57 500
 500 http://ftp.debian.org/debian testing/main amd64 Packages
 1:14.0-55.7~deb12u1 500
 500 http://ftp.debian.org/debian stable/main amd64 Packages

So 14 on stable and 16 on testing.

Likewise for clang package:

$ apt policy clang
[sudo] Mot de passe de pascal : 
clang:
 Installé : (aucun)
 Candidat : 1:16.0-57
 Table de version :
 1:16.0-57 500
 500 http://ftp.debian.org/debian testing/main amd64 Packages
 1:14.0-55.7~deb12u1 500
 500 http://ftp.debian.org/debian stable/main amd64 Packages

Wait... That's because this is only the default install, but one can install more recent versions:

On testing:

$ apt show clang-17
Package: clang-17
Version: 1:17.0.6-5
Priority: optional
Section: devel
Source: llvm-toolchain-17
...

So, indeed no problem to bump CLang version.

I'm not sure what you are looking at, i literally have a LLVM16 @ bookworm CI entry: https://github.com/darktable-org/rawspeed/actions/runs/7895101031/job/21546912094

As i've said, rawspeed will only be able to bump to LLVM15 (https://github.com/google/oss-fuzz/issues/9989 :/), but dt should be able to bump all the way to LLVM16.

Do you think the bump could happen right after the next point release of stable series of dt?

With darktable.org/darktable#15945 fixed we can bump to

{ os: macos-13, xcode: "15.2", deployment: 13.5 }

Awesome! Let's get point release out of the door soon, and do that!

compiler-versions.cmake: 2024 edition

LLVM16 migrated into debian stable. macOS 12 will become EOL in summer.

Therefore, for the summer dt release, we can require macOS 13 + XCode 15.2, which means we'll be able to bump required LLVM version up to 15 or even 16.

Bit counting is missing in clang14

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (d5bba51) 60.61% compared to head (12aa613) 60.55%.

@@ Coverage Diff @@
## develop #662 +/- ##
===========================================
- Coverage 60.61% 60.55% -0.07% 
===========================================
 Files 264 264 
 Lines 16040 16057 +17 
 Branches 2052 2052 
===========================================
 Hits 9723 9723 
- Misses 6189 6206 +17 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

PrefixCodeEncoder: support DNG 1.0 LJpeg stream flavor

PrefixCodeEncoder: support full (difference) encoding

Merge pull request #2923 from kevinbackhouse/update-security-policy

Update security policy

Merge pull request #661 from LebedevRI/prefix-code-encoder

Prefix code encoder

Prefix Code Encoder

Changes copied from 0.28.x branch.

Legend

Update security policy

Extract AbstractPrefixCodeTranscoder out of AbstractPrefixCodeDecoder

Build release without samples.

I forgot to include this in #2921.

Legend

Update workflows

CI: fix event trigger branches, minor tweaks

Apply @kmilos's suggestions from #2919 to the main branch.

Kinda did it in https://github.com/Exiv2/exiv2/pull/2920 😉

Just keep the release workflow fix?

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a08de6f) 64.03% compared to head (a33ca3c) 64.03%. Report is 1 commits behind head on main.

@@ Coverage Diff @@
## main #2921 +/- ##
=======================================
 Coverage 64.03% 64.03% 
=======================================
 Files 104 104 
 Lines 22409 22409 
 Branches 10882 10882 
=======================================
 Hits 14350 14350 
 Misses 5830 5830 
 Partials 2229 2229 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (16584be) 64.03% compared to head (285c985) 64.57%.

@@ Coverage Diff @@
## main #2920 +/- ##
==========================================
+ Coverage 64.03% 64.57% +0.53% 
==========================================
 Files 104 104 
 Lines 22409 22196 -213 
 Branches 10882 10882 
==========================================
- Hits 14350 14332 -18 
+ Misses 5830 5622 -208 
- Partials 2229 2242 +13 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

CI: use system ninja

These are changes that were made on the main branch but haven't been backported to 0.28.x yet. The only difference now is that I didn't backport special_noFilesystemAccess because I think that's a new feature on the main branch.

Legend

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (72129e7) 63.99% compared to head (981926b) 64.66%. Report is 38 commits behind head on 0.28.x.

@@ Coverage Diff @@
## 0.28.x #2919 +/- ##
==========================================
+ Coverage 63.99% 64.66% +0.66% 
==========================================
 Files 103 104 +1 
 Lines 22338 22169 -169 
 Branches 10821 10839 +18 
==========================================
+ Hits 14296 14335 +39 
+ Misses 5818 5590 -228 
- Partials 2224 2244 +20 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Shall we do one last compare after the last few commits to main?

Merge pull request #2915 from kevinbackhouse/fix-GHSA-crmj-qh74-2r36

prevent unbounded recursion in QuickTimeVideo::multipleEntriesDecoder

Merge pull request #2916 from kevinbackhouse/fix-GHSA-g9xm-7538-mq8w

Avoid out-of-bounds read in QuickTimeVideo::NikonTagsDecoder

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (36e3d55) 63.93% compared to head (39555d8) 63.93%.

@@ Coverage Diff @@
## main #2918 +/- ##
=======================================
 Coverage 63.93% 63.93% 
=======================================
 Files 104 104 
 Lines 22400 22400 
 Branches 10877 10877 
=======================================
 Hits 14322 14322 
 Misses 5854 5854 
 Partials 2224 2224 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Why?

Not critical of course - that's more likely what the end users/packagers will use (like we already do in case of macOS, MSYS2, etc...), and might be quicker to download/install from github images/mirrors than pypi...

Not critical of course - that's more likely what the end users/packagers will use (like we already do in case of macOS, MSYS2, etc...), and might be quicker to download/install from github images/mirrors than pypi...

This makes sense to me. I always use apt-get rather than pip whenever possible.

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (801bd8b) 60.97% compared to head (e4739c1) 60.61%.

@@ Coverage Diff @@
## develop #661 +/- ##
===========================================
- Coverage 60.97% 60.61% -0.37% 
===========================================
 Files 260 264 +4 
 Lines 15946 16041 +95 
 Branches 2044 2052 +8 
===========================================
 Hits 9723 9723 
- Misses 6095 6190 +95 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Merge pull request #660 from LebedevRI/cmake

CMake: cache more stuff

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cd1d81e) 60.97% compared to head (34f0b24) 60.97%.

@@ Coverage Diff @@
## develop #660 +/- ##
========================================
 Coverage 60.97% 60.97% 
========================================
 Files 260 260 
 Lines 15946 15946 
 Branches 2044 2044 
========================================
 Hits 9723 9723 
 Misses 6095 6095 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

GoogleTest.cmake: avoid dealing with GoogleTest.cmake.in if not needed

GoogleBenchmark.cmake: avoid dealing with GoogleBenchmark.cmake.in if not needed

Update version numbers for the new release.

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (981926b) 64.66% compared to head (f1632fe) 64.66%. Report is 1 commits behind head on 0.28.x.

@@ Coverage Diff @@
## 0.28.x #2917 +/- ##
=======================================
 Coverage 64.66% 64.66% 
=======================================
 Files 104 104 
 Lines 22169 22169 
 Branches 10839 10839 
=======================================
 Hits 14335 14335 
 Misses 5590 5590 
 Partials 2244 2244 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Shall we sync the CI to main before release? @neheb

Also, will need to update https://github.com/Exiv2/exiv2/blob/main/SECURITY.md, on both 0.28.x and main?

@kmilos: Good point about security.md. I'll add that to this PR. What's the issue with the CI that needs to be synced?

What's the issue with the CI that needs to be synced?

The usual: Conan version and actions out of date... Not a must, more of a "nice to have"...

I think we also have less jobs on main and handled the constantly failing FreeBSD one...

I updated SECURITY.md. I'm wondering if we should remove all mention of versions before 0.27 though. In fact, are we even still supporting 0.27 at this point?

In fact, are we even still supporting 0.27 at this point?

Not really, but we have somewhat of a problem because of wchar_t removal in 0.28x so some still have to use it on Windows.

It seems https://github.com/Exiv2/exiv2/actions/runs/7888790070/job/21527100716?pr=2917 FreeBSD VM is not booting properly, hence this leads to timeout. I may try to compile the latest and gretest code on the real FreeBSD 14 machine in order to check that. Later today.

It seems https://github.com/Exiv2/exiv2/actions/runs/7888790070/job/21527100716?pr=2917 FreeBSD VM is not booting properly, hence this leads to timeout. I may try to compile the latest and gretest code on the real FreeBSD 14 machine in order to check that. Later today.

@1div0: I'm hoping to fix that with #2919

I squashed the commits.

This is a rebase of https://github.com/Exiv2/exiv2/commit/a98d76cc6f97474dcebd6164bd0496c68b826783, which fixed https://github.com/Exiv2/exiv2-ghsa-g9xm-7538-mq8w, onto the main branch.

Legend

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (36e3d55) 63.93% compared to head (79ab2f6) 64.02%.

@@ Coverage Diff @@
## main #2916 +/- ##
==========================================
+ Coverage 63.93% 64.02% +0.08% 
==========================================
 Files 104 104 
 Lines 22400 22402 +2 
 Branches 10877 10879 +2 
==========================================
+ Hits 14322 14343 +21 
+ Misses 5854 5830 -24 
- Partials 2224 2229 +5 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64151 nul-terminate buf to avoid out-of-bounds read

Regression test for https://github.com/Exiv2/exiv2/security/advisories/GHSA-g9xm-7538-mq8w

This is a rebase of https://github.com/Exiv2/exiv2/commit/355afea485550e8214ac6b449fb210a7efb71365, which fixed https://github.com/Exiv2/exiv2/security/advisories/GHSA-crmj-qh74-2r36, onto the main branch.

Legend

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (36e3d55) 63.93% compared to head (9d69a71) 63.94%.

@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
+ Coverage 63.93% 63.94% +0.01% 
==========================================
 Files 104 104 
 Lines 22400 22407 +7 
 Branches 10877 10880 +3 
==========================================
+ Hits 14322 14329 +7 
 Misses 5854 5854 
 Partials 2224 2224 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Throw exception if the recursion goes too deep.

Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65541 Add recursion_depth parameter to ensure that the recursion doesn't go too deep.

Regression test for https://github.com/Exiv2/exiv2/security/advisories/GHSA-crmj-qh74-2r36

cpu-large-page-size.cmake: cache state

cpu-page-size.cmake: cache state

cpu-cache-line-size.cmake: cache state

CpuMarch.cmake: cache state, don't recompute on cmake re-run

Add NIKKOR Z 28mm f/2.8

Upload eafb3e

Merge pull request #658 from LebedevRI/footprint

CMake: improve disk footprint of build directory

CMake: split-dwarf not supported by mingw's gcc (but works with clang)

CMake: when debug info is enabled, also enable split dwarf

This results in addition -28% footprint reduction of the Release build directory.

CMake: when debug info is enabled, also enable it's compression

This results in -48% less footprint of the Release build directory...

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b737e89) 60.97% compared to head (8850e3c) 60.97%.

@@ Coverage Diff @@
## develop #658 +/- ##
========================================
 Coverage 60.97% 60.97% 
========================================
 Files 260 260 
 Lines 15946 15946 
 Branches 2044 2044 
========================================
 Hits 9723 9723 
 Misses 6095 6095 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

BitStreamTraits: document if the stream has fixed-size chunk or not

CMake: stop telling gtest to dump output xml's

IIRC those were (going to be?) used in SonarCloud, to get the test coverage, but that never worked.

Merge pull request #657 from LebedevRI/coverage

CI: enable sample-based testing for all linux-fast jobs, not just Coverage

CI: enable sample-based testing for all linux-fast jobs, not just Coverage

CI: drop obsolete ubuntu:jammy reference

ci-macos: drop obsolete MACOSX_DEPLOYMENT_TARGET check

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (10320be) 60.97% compared to head (300c73d) 60.97%.

@@ Coverage Diff @@
## develop #657 +/- ##
========================================
 Coverage 60.97% 60.97% 
========================================
 Files 260 260 
 Lines 15946 15946 
 Branches 2044 2044 
========================================
 Hits 9723 9723 
 Misses 6095 6095 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

BitStreamerJPEG: add name to friend function's argument

dt's Fedora 38 PPC64LE build (and only that one?!) is failing with a very weird

[ 337s] In file included from /home/abuild/rpmbuild/BUILD/darktable-4.7.0~git534.af89bfbf/src/external/rawspeed/src/librawspeed/decoders/../decompressors/SonyArw1Decompressor.h:25,
[ 337s] from /home/abuild/rpmbuild/BUILD/darktable-4.7.0~git534.af89bfbf/src/external/rawspeed/src/librawspeed/decoders/ArwDecoder.cpp:35:
[ 337s] /home/abuild/rpmbuild/BUILD/darktable-4.7.0~git534.af89bfbf/src/external/rawspeed/src/librawspeed/decoders/../io/BitStreamerMSB.h:47:29: error: default argument specified in explicit specialization [-fpermissive]
[ 337s] 47 | friend void Base::fill(int); // Allow it to call our `fillCache()`.
[ 337s] | ^
[ 338s] gmake[2]: *** [lib64/darktable/rawspeed/src/librawspeed/decoders/CMakeFiles/rawspeed_decoders.dir/build.make:93:

... which makes zero sense since we clearly don't have a default argument here. Maybe giving it a name helps? Probably not.

Merge pull request #656 from LebedevRI/ctu

CI: split off CTU static analysis into a separate job

CI: split off CTU static analysis into a separate job

Merge pull request #655 from LebedevRI/cmake-build-type

CMake: RelWithDebInfo is pointless, replace it with ReleaseWithAsserts

CMake: RelWithDebInfo is pointless, replace it with ReleaseWithAsserts

We always enable debug info.

And actually i though assertions were enabled in RelWithDebInfo but they are not.

So ReleaseWithAsserts is more interesting.

We always enable debug info.

And actually i though assertions were enabled in RelWithDebInfo but they are not.

So ReleaseWithAsserts is more interesting.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d9d14dc) 60.97% compared to head (ff3e87a) 60.97%.

@@ Coverage Diff @@
## develop #655 +/- ##
========================================
 Coverage 60.97% 60.97% 
========================================
 Files 260 260 
 Lines 15946 15946 
 Branches 2044 2044 
========================================
 Hits 9723 9723 
 Misses 6095 6095 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

I've got two low severity security bugs that I'd like to release fixes for. Is everyone happy for me to release v0.28.2? I'll take care of the related tasks like updating the website.

Output of git shortlog -s -n v0.28.1..0.28.x:

 16 Miloš Komarčević
 7 Jim Easterbrook
 3 Miguel Borges de Freitas
 2 Pino Toscano
 2 Rosen Penev

That's: @kmilos @jim-easterbrook @enen92 @pinotree @neheb

Code changes in this release are listed in the milestone: https://github.com/Exiv2/exiv2/milestone/13

Links to the two security issues (currently still private): * CVE-2024-24826 * CVE-2024-25112

Nice. I believe that those regex purges may make some people happy :)

I believe that those regex purges may make some people happy :)

@kamiccolo I think there is still some way to go on those: https://gitlab.gnome.org/GNOME/gimp/-/merge_requests/1102#note_2011736

I believe that those regex purges may make some people happy :)

@kamiccolo I think there is still some way to go on those: https://gitlab.gnome.org/GNOME/gimp/-/merge_requests/1102#note_2011736

Oh yeah, there were some left-overs last time I've checked.

• canonmn_int.cpp: https://github.com/Exiv2/exiv2/blob/main/src/canonmn_int.cpp#L2888-L2915
• value.cpp: https://github.com/Exiv2/exiv2/blob/main/src/value.cpp#L898-L924
• version.cpp: https://github.com/Exiv2/exiv2/blob/main/src/version.cpp#L88-L97
• app/exiv2.cpp: https://github.com/Exiv2/exiv2/blob/main/app/exiv2.cpp#L504-L515
• app/actions.cpp: https://github.com/Exiv2/exiv2/blob/main/app/actions.cpp#L422-L431

(at least those)

Skip to content

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

{{ message }}

aurelienpierreeng

/

ansel

Public

forked from edgardoh/darktable

Notifications

Fork 19

Star 574

Issues: aurelienpierreeng/ansel

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

68 Open

145 Closed

68 Open

145 Closed

Assigned to nobody

Newest

Oldest

Most commented

Least commented

Recently updated

Least recently updated

Best match

Most reactions

👍

👎

😄

🎉

😕

❤️

🚀

👀

Issues list

Selective History Stack Copy

327

opened Feb 11, 2024 by CavemanChris

1

Crash while using liquefy

326

opened Feb 10, 2024 by Giorey01

Visual mapping button missing?

322

opened Feb 3, 2024 by Sharparam

1

Crash on import-Copy to disk

320

opened Jan 28, 2024 by elidigui

4

Cannot apply any change to a specific image in the darkroom

318

opened Jan 20, 2024 by marco44

1

Mouse pan/zoom leaks GPU memory in Darkroom

317

opened Jan 15, 2024 by tajuma

1

Feature request: add export of a list of selected file names

difficulty: easy

enhancement

316

opened Jan 15, 2024 by blonchkman

The export result is considerably darker than the central view in the darkroom

313

opened Jan 5, 2024 by blonchkman

2

masks: hiding the mask view randomly causes a black or disturbed central view.

312

opened Jan 4, 2024 by blonchkman

2

Retouch module does not show/apply correction

310

opened Jan 3, 2024 by antoniopiazza

4

Horizon and perspective breaks when crop is applied prior

308

opened Jan 3, 2024 by trougnouf

1

Image disorted when changing TCA overwrite. Fixes when zooming.

bug

306

opened Jan 1, 2024 by pjhyor7

0.1

Zooming messes with pipeline (preview in Darkroom not stable)

bug

296

opened Dec 24, 2023 by LucaZulberti

0.1

4

UI Scopes module

redesign

Needs to rewrite existing features

293

opened Dec 22, 2023 by audiomartin

0.1

3

Import adds an invalid empty folder

regression

291

opened Dec 22, 2023 by vtyrtov

0.1

1

No copy on windows

regression

289

opened Dec 21, 2023 by wadouk

0.1

3

Make pasting development recompute pipe caches in darkroom too

enhancement

priority: critical

Affects basic and core functionnalities of the software in a way that prevents it to work at all

284

opened Dec 18, 2023 by Jiyone

2

Framing module: increasing border size past a certin point does not preserve frame's aspect ratio.

unclear

277

opened Dec 16, 2023 by pedrorrodriguez

1

Unable to clear history

priority: critical

Affects basic and core functionnalities of the software in a way that prevents it to work at all

regression

269

opened Dec 13, 2023 by kred

5

Pickers given priority when snapshot function is active.

enhancement

264

opened Dec 10, 2023 by pjhyor7

1

Ansel freezes by applying style from the darkroom

bug

priority: high

Affects basic and core functionnalities of the software in a way that severly degrades usability

262

opened Dec 8, 2023 by lologor

Thoughts on the new theme

enhancement

259

opened Dec 8, 2023 by pedrorrodriguez

14

Improve color picker viewport display

enhancement

257

opened Dec 7, 2023 by pedrorrodriguez

Display metadata placement

enhancement

256

opened Dec 7, 2023 by pedrorrodriguez

5

Zoom levels should not be on the navigation module

enhancement

254

opened Dec 7, 2023 by pedrorrodriguez

3

Previous 1 2 3 Next

Previous Next

ProTip! Type g i on any issue or pull request to go back to the issue listing page.

You can’t perform that action at this time.

I googled it, and used the chantel AI and got a little confused. Either I'm doing something stupid or there's no "history stack selective copy" feature in Ansel if there is, it's not as easy to work with like darktable, with a separate tab, i can't find a way to do it. If there isn't, I think it's a good idea to implement.

I like your minimalist approach and saw the video about the coffee maker and I agree, the old stuff is made solid. But sometimes minimalism takes away some cool features. ie easter egg game. lol. didn't know that was on darktable till I saw the video.

Also this might not be the appropriate place but considering your software is potentially superior to photoshop in that it's scene referred based, how would it stack up against other software like Silverfast HDR studio. a youtube video about it would be awesome. or a quick message. Instagram @chris__ratke email candidchris@protonmail.com

... Either I'm doing something stupid or there's no "history stack selective copy" feature in Ansel...

These commands have been moved to Ansel's global menu. Edit --> copy development : copy the current state and params of all modules involved up to the currently selected history step (there is no choice here). Edit --> Past development (all) : past all modules. Edit --> Past development (parts) : opens a dialog for selecting.

Hope that might help

Crash while using liquefy on JPG

System

• OS : Win11
• Graphics card msi gtx 1660 :
• Graphics driver Nvidia 551.23 :

here's the crash report

this is ansel 0.0.0+729~ge2c4a0a reporting an exception:

Error occurred on Saturday, February 10, 2024 at 10:21:39.

ansel.exe caused an Access Violation at location 00007FF9D81A1ECF in module libgtk-3-0.dll Reading from location FFFFFFFFFFFFFFFF.

AddrPC Params 00007FF9D81A1ECF 0000000000000000 0000000000000002 00000236045B7A00 libgtk-3-0.dll!gtk_widget_queue_draw+0x2f 00007FF9D8A330D9 0000000000000000 0000000000000000 0000000000000000 libansel.dll!dt_conf_cleanup+0x189 00007FFA1628EB5C 0000000000000002 00000236045B7A00 0000000000000000 libglib-2.0-0.dll!g_clear_list+0x11ac 00007FFA16291983 0000000000000000 00007FFA162B3E26 0000000000000000 libglib-2.0-0.dll!g_get_monotonic_time+0xa73 00007FFA16292320 0000000000000000 0000000000000000 00007FF9D8E230C0 libglib-2.0-0.dll!g_main_loop_run+0x120 00007FF9D803BB5E 0000000000000000 00007FF66859406A 00007FF668594028 libgtk-3-0.dll!gtk_main+0x7e 00007FF9D8B2B46F 0002000000000001 0000023602417FD0 0000000000000001 libansel.dll!dt_gui_gtk_run+0xaf 00007FF668592D09 00007FF668591560 00007FF66859277D 00007FFA49B80F28 ansel.exe!0x2d09 00007FF6685914C2 0000000000000000 00007FF668597048 0000000000000000 ansel.exe!0x14c2 00007FF6685912F7 0000000000000000 0000000000000000 0000000000000000 ansel.exe!0x12f7 00007FF668591406 0000000000000000 0000000000000000 0000000000000000 ansel.exe!0x1406 00007FFA4B8C257D 0000000000000000 0000000000000000 0000000000000000 KERNEL32.DLL!BaseThreadInitThunk+0x1d 00007FFA4C34AA58 0000000000000000 0000000000000000 0000000000000000 ntdll.dll!RtlUserThreadStart+0x28

00007FF668590000-00007FF6685AE000 ansel.exe 0.0.0.729 00007FFA4C2F0000-00007FFA4C507000 ntdll.dll 10.0.22621.2506 00007FFA4B8B0000-00007FFA4B974000 KERNEL32.DLL 10.0.22621.2506 00007FFA496A0000-00007FFA49A46000 KERNELBASE.dll 10.0.22621.2792 00007FFA464B0000-00007FFA46547000 apphelp.dll 10.0.22621.2506 00007FFA49A80000-00007FFA49B91000 ucrtbase.dll 10.0.22621.2506 00007FFA35E90000-00007FFA35EC5000 libintl-8.dll 0.22.4.0 00007FFA4B990000-00007FFA4BA43000 ADVAPI32.dll 10.0.22621.3007 00007FFA4BA50000-00007FFA4BAF7000 msvcrt.dll 7.0.22621.2506 00007FFA4A140000-00007FFA4A1E8000 sechost.dll 10.0.22621.3007 00007FFA49A50000-00007FFA49A78000 bcrypt.dll 10.0.22621.2506 00007FFA4B210000-00007FFA4B327000 RPCRT4.dll 10.0.22621.2792 00007FFA16250000-00007FFA163B6000 libglib-2.0-0.dll 2.78.3.0 00007FFA4AFA0000-00007FFA4B140000 ole32.dll 10.0.22621.2506 00007FFA49C60000-00007FFA49CFA000 msvcp_win.dll 10.0.22621.2506 00007FFA4BC50000-00007FFA4BC79000 GDI32.dll 10.0.22621.2792 00007FFA49F90000-00007FFA49FB6000 win32u.dll 10.0.22621.3007 00007FFA49D00000-00007FFA49E18000 gdi32full.dll 10.0.22621.2861 00007FFA4BFB0000-00007FFA4C15E000 USER32.dll 10.0.22621.2506 00007FFA4A320000-00007FFA4A6A9000 combase.dll 10.0.22621.2792 00007FFA4A6D0000-00007FFA4AF2A000 SHELL32.dll 10.0.22621.3007 00007FFA4BF10000-00007FFA4BF81000 WS2_32.dll 10.0.22621.1 00007FF9E7070000-00007FF9E7189000 libiconv-2.dll 1.17.0.0 00007FFA161E0000-00007FFA16248000 libpcre2-8-0.dll 00007FF9D8930000-00007FF9D8ECA000 libansel.dll 00007FFA345C0000-00007FFA345E4000 libgcc_s_seh-1.dll 00007FF9FD2C0000-00007FF9FD316000 exchndl.dll 0.9.11.0 00007FF9E6AA0000-00007FF9E6BCC000 libcairo-2.dll 00007FFA261C0000-00007FFA261F1000 libgdk_pixbuf-2.0-0.dll 2.42.10.0 00007FF9D87E0000-00007FF9D8928000 libgdk-3-0.dll 3.24.39.0 00007FFA4A2E0000-00007FFA4A311000 IMM32.dll 10.0.22621.2792 00007FFA4B330000-00007FFA4B7A4000 SETUPAPI.dll 10.0.22621.2506 00007FF9D8620000-00007FF9D87D9000 libgio-2.0-0.dll 2.78.3.0 00007FFA4C1F0000-00007FFA4C24E000 SHLWAPI.dll 10.0.22621.2506 00007FF9FD260000-00007FF9FD2BA000 libgobject-2.0-0.dll 2.78.3.0 00007FF9FCF00000-00007FF9FCF65000 libpango-1.0-0.dll 1.50.14.0 00007FFA3CCB0000-00007FFA3CCC8000 libpangocairo-1.0-0.dll 1.50.14.0 00007FF9D7EC0000-00007FF9D861F000 libgtk-3-0.dll 3.24.39.0 00007FFA3C1B0000-00007FFA3C1C7000 libwinpthread-1.dll 1.0.0.0 00007FFA4A040000-00007FFA4A139000 comdlg32.dll 10.0.22621.2506 00007FFA4B7B0000-00007FFA4B8A3000 shcore.dll 10.0.22621.2715 00007FFA3B6D0000-00007FFA3B6EF000 zlib1.dll 00007FFA25DE0000-00007FFA25E16000 libavif-16.dll 00007FF9E61C0000-00007FF9E628C000 libcurl-4.dll 8.5.0.0 00007FFA49E20000-00007FFA49F86000 CRYPT32.dll 10.0.22621.2506 00007FFA4AF30000-00007FFA4AF92000 WLDAP32.dll 10.0.22621.2506 00007FF9D7B90000-00007FF9D7EB7000 libexiv2.dll 00007FFA4A6B0000-00007FFA4A6B8000 PSAPI.DLL 10.0.22621.1 00007FF9D7960000-00007FF9D7B90000 libstdc++-6.dll 00007FFA3CB50000-00007FFA3CB60000 libgmodule-2.0-0.dll 2.78.3.0 00007FFA25780000-00007FFA257CF000 libgomp-1.dll 00007FF9D7820000-00007FF9D795C000 libGraphicsMagick-3.dll 00007FF9D7720000-00007FF9D7811000 libheif.dll 00007FF9D7620000-00007FF9D771C000 libjpeg-8.dll 00007FF9D7450000-00007FF9D7616000 libicuuc74.dll 00007FFA33480000-00007FFA334AE000 libjson-glib-1.0-0.dll 00007FF9E8220000-00007FF9E828F000 liblcms2-2.dll 00007FF9D7180000-00007FF9D744E000 libicuin74.dll 00007FF9D6E70000-00007FF9D717A000 libOpenEXR-3_2.dll 00007FF9E6EE0000-00007FF9E6F57000 libopenjp2-7.dll 00007FFA18C20000-00007FFA18C63000 libpng16-16.dll 00007FF9FCEB0000-00007FF9FCEF3000 libpugixml.dll 1.14.0.0 00007FF9DB660000-00007FF9DB6B9000 libsecret-1-0.dll 00007FF9DA6C0000-00007FF9DA755000 libsoup-2.4-1.dll 00007FF9D6DD0000-00007FF9D6E63000 libtiff-6.dll 00007FF9D6C40000-00007FF9D6DC2000 libsqlite3-0.dll 00007FF9D63A0000-00007FF9D6C3E000 librsvg-2-2.dll 00007FFA36270000-00007FFA36284000 libwebpmux-3.dll 00007FFA3FA60000-00007FFA3FA6A000 VERSION.dll 10.0.22621.1 00007FF9D62E0000-00007FF9D639F000 libwebp-7.dll 00007FFA3AD10000-00007FFA3AD17000 MSIMG32.dll 10.0.22621.2506 00007FF9DB600000-00007FF9DB657000 libfontconfig-1.dll 00007FF9D6210000-00007FF9D62D1000 mgwhelp.dll 0.9.11.0 00007FF9D60C0000-00007FF9D6203000 libxml2-2.dll 00007FFA33590000-00007FFA33749000 gdiplus.dll 10.0.22621.2506 00007FFA46AB0000-00007FFA46ADB000 dwmapi.dll 10.0.22621.2506 00007FFA47E30000-00007FFA47E3E000 HID.DLL 10.0.22621.1 00007FFA3A120000-00007FFA3A154000 WINMM.dll 10.0.22621.2506 00007FF9D5FF0000-00007FF9D60B4000 libfreetype-6.dll 2.13.2.0 00007FFA34FE0000-00007FFA34FF1000 libcairo-gobject-2.dll 00007FF9D5F40000-00007FF9D5FEF000 libpixman-1-0.dll 00007FFA28820000-00007FFA2884C000 libfribidi-0.dll 00007FFA480F0000-00007FFA481E9000 DNSAPI.dll 10.0.22621.2506 00007FFA480C0000-00007FFA480ED000 IPHLPAPI.DLL 10.0.22621.1 00007FFA26E90000-00007FFA26EAF000 libpangowin32-1.0-0.dll 1.50.14.0 00007FFA22160000-00007FFA22171000 libffi-8.dll 00007FF9D5D90000-00007FF9D5F3F000 libepoxy-0.dll 00007FF9D5C50000-00007FF9D5D8C000 libharfbuzz-0.dll 00007FFA33750000-00007FFA339E3000 COMCTL32.dll 6.10.22621.2506 00007FFA33A60000-00007FFA33B08000 WINSPOOL.DRV 10.0.22621.2506 00007FFA1DCD0000-00007FFA1DCE8000 libthai-0.dll 00007FFA1C5D0000-00007FFA1C5FE000 libatk-1.0-0.dll 2.50.0.0 00007FFA161C0000-00007FFA161DC000 libpangoft2-1.0-0.dll 1.50.14.0 00007FF9D5360000-00007FF9D5C44000 libaom.dll 00007FF9D5160000-00007FF9D5356000 libdav1d-7.dll 7.0.0.0 00007FF9E8310000-00007FF9E8326000 libsharpyuv-0.dll 00007FF9D4DF0000-00007FF9D5155000 rav1e.dll 00007FF9D4600000-00007FF9D4DE3000 libSvtAv1Enc.dll 00007FF9E8200000-00007FF9E8217000 libbrotlidec.dll 00007FF9D44F0000-00007FF9D45F1000 libyuv.dll 00007FF9E7B10000-00007FF9E7B47000 libnghttp2-14.dll 1.58.0.0 00007FF9D44A0000-00007FF9D44E2000 libidn2-0.dll 00007FF9E76B0000-00007FF9E76D2000 libpsl-5.dll 00007FF9D4450000-00007FF9D449E000 libssh2-1.dll 1.11.0.0 00007FF9D3F70000-00007FF9D4441000 libcrypto-3-x64.dll 3.2.0.0 00007FF9D3E80000-00007FF9D3F64000 libssl-3-x64.dll 3.2.0.0 00007FF9E6180000-00007FF9E61B4000 libexpat-1.dll 00007FF9D3D60000-00007FF9D3E7E000 libzstd.dll 00007FF9E6EC0000-00007FF9E6EDA000 libbz2-1.dll 00007FF9DB5E0000-00007FF9DB5F8000 libltdl-7.dll 00007FF9D3CA0000-00007FF9D3D5A000 libde265-0.dll 00007FF9D1F30000-00007FF9D3C99000 libicudt74.dll 00007FF9D1ED0000-00007FF9D1F28000 libImath-3_1.dll 00007FF9DB570000-00007FF9DB582000 libIlmThread-3_2.dll 00007FF9D1E70000-00007FF9D1ED0000 libIex-3_2.dll 00007FF9D1C30000-00007FF9D1E6E000 libOpenEXRCore-3_2.dll 00007FF9D1AE0000-00007FF9D1C26000 libgcrypt-20.dll 1.10.3.0 00007FF9DA6A0000-00007FF9DA6B7000 libjbig-0.dll 00007FF9D1AC0000-00007FF9D1ADC000 libdeflate.dll 00007FF9D19F0000-00007FF9D1AB1000 libLerc.dll 00007FFA48C20000-00007FFA48C4C000 USERENV.dll 10.0.22621.2506 00007FF9D19B0000-00007FF9D19E5000 liblzma-5.dll 5.4.5.0 00007FFA46FD0000-00007FFA47203000 dbghelp.dll 10.0.22621.2506 00007FFA4A200000-00007FFA4A2D7000 OLEAUT32.dll 10.0.22621.2506 00007FFA448B0000-00007FFA44B23000 DWrite.dll 10.0.22621.2506 00007FFA28020000-00007FFA28039000 USP10.dll 10.0.22621.1 00007FF9D0650000-00007FF9D19A2000 libx265.dll 3.4.0.31 00007FFA3C7C0000-00007FFA3C7D0000 libdatrie-1.dll 00007FF9D0620000-00007FF9D064C000 libgraphite2.dll 00007FF9D05F0000-00007FF9D061D000 libbrotlicommon.dll 00007FF9D0400000-00007FF9D05ED000 libunistring-5.dll 1.1.0.0 00007FFA48EB0000-00007FFA48EBC000 CRYPTBASE.DLL 10.0.22621.1 00007FFA3B240000-00007FFA3B272000 dbgcore.DLL 10.0.22621.1 00007FF9D03C0000-00007FF9D03FC000 libgpg-error-0.dll 1.47.0.0 00007FFA49FC0000-00007FFA4A03A000 bcryptPrimitives.dll 10.0.22621.2506 00007FFA4B980000-00007FFA4B989000 NSI.dll 10.0.22621.1 00007FFA48710000-00007FFA48728000 kernel.appcore.dll 10.0.22621.2715 00007FFA47530000-00007FFA47E26000 windows.storage.dll 10.0.22621.2792 00007FFA473F0000-00007FFA4752E000 wintypes.dll 10.0.22621.2792 00007FFA42970000-00007FFA42AA7000 winhttp.dll 10.0.22621.2506 00007FFA26FA0000-00007FFA26FA6000 KBDUSX.DLL 10.0.22621.1 00007FFA465B0000-00007FFA4665B000 uxtheme.dll 10.0.22621.3007 00007FFA4BB00000-00007FFA4BC50000 MSCTF.dll 10.0.22621.2792 00007FFA492F0000-00007FFA4931C000 DEVOBJ.dll 10.0.22621.2506 00007FFA49320000-00007FFA4936E000 cfgmgr32.dll 10.0.22621.2506 00007FFA49630000-00007FFA4969B000 WINTRUST.dll 10.0.22621.3007 00007FFA492D0000-00007FFA492E2000 MSASN1.dll 10.0.22621.2506 00007FFA4BE40000-00007FFA4BEF0000 clbcatq.dll 2001.12.10941.16384 00007FFA18C70000-00007FFA18DDC000 OpenCL.dll 3.0.3.0 00007FFA46780000-00007FFA467B6000 dxcore.dll 10.0.22621.2506 00007FFA42D40000-00007FFA42E75000 AppXDeploymentClient.dll 10.0.22621.2792 00007FF9CF900000-00007FF9D03BC000 nvopencl64.dll 31.0.15.5123 00007FFA3FA20000-00007FFA3FA52000 cryptnet.dll 10.0.22621.1 00007FFA3F4A0000-00007FFA3F5F8000 drvstore.dll 10.0.22621.2506 00007FFA48E00000-00007FFA48E4B000 wldp.dll 10.0.22621.2792 00007FFA39180000-00007FFA39844000 nvapi64.dll 31.0.15.5123 00007FF9CE5E0000-00007FF9CF8FF000 nvptxJitCompiler64.dll 31.0.15.5123 00007FFA35ED0000-00007FFA35FCC000 Windows.ApplicationModel.dll 10.0.22621.2506 00007FFA36C20000-00007FFA36D0B000 Windows.StateRepositoryPS.dll 10.0.22621.2792 00007FFA44040000-00007FFA44063000 Windows.StateRepositoryBroker.dll 10.0.22621.2792 00007FFA34400000-00007FFA34518000 mrmcorer.dll 10.0.22621.2506 00007FFA33D60000-00007FFA3401C000 iertutil.dll 11.0.22621.3007 00007FFA41C60000-00007FFA41C7A000 windows.staterepositorycore.dll 10.0.22621.2792 00007FFA49560000-00007FFA49586000 profapi.dll 10.0.22621.2506 00007FFA2B370000-00007FFA2B4E4000 Windows.UI.dll 10.0.22621.2506 00007FFA2BA10000-00007FFA2BA42000 bcp47mrm.dll 10.0.22621.2506 00007FFA45800000-00007FFA45901000 propsys.dll 7.0.22621.2506 00007FFA21A50000-00007FFA21A6A000 NetworkExplorer.dll 10.0.22621.1 00007FFA0F680000-00007FFA0F6A6000 mssprxy.dll 7.0.22621.2792 00007FFA2B320000-00007FFA2B364000 languageoverlayutil.dll 10.0.22621.2506 00007FF9CA4A0000-00007FF9CE5D5000 nvvm64.dll 31.0.15.5123 00007FFA48ED0000-00007FFA48EEB000 CRYPTSP.dll 10.0.22621.2506 00007FFA48670000-00007FFA486A5000 rsaenh.dll 10.0.22621.1 00007FFA40BC0000-00007FFA40BFD000 windows.staterepositoryclient.dll 10.0.22621.2792 00007FFA36300000-00007FFA36309000 IconCodecService.dll 10.0.22621.1 00007FFA44640000-00007FFA447F0000 WindowsCodecs.dll 10.0.22621.2506 00007FFA43350000-00007FFA43360000 libpixbufloader-png.dll 00007FFA3DBF0000-00007FFA3DCAC000 mscms.dll 10.0.22621.2506 00007FF9FCB20000-00007FF9FCB69000 icm32.dll 10.0.22621.2506 00007FFA3CB60000-00007FFA3CCAA000 textinputframework.dll 10.0.22621.2792 00007FFA45EB0000-00007FFA45FE4000 CoreMessaging.dll 10.0.22621.3007 00007FFA40E60000-00007FFA411CC000 CoreUIComponents.dll 10.0.22621.2506 00007FFA3D0C0000-00007FFA3D345000 msxml6.dll 6.30.22621.2506 00007FFA3B820000-00007FFA3B842000 libdarkroom.dll 00007FFA3CCD0000-00007FFA3CCDF000 liblighttable.dll 00007FFA3B810000-00007FFA3B81F000 libavif.dll 00007FFA3B800000-00007FFA3B80D000 libcopy.dll 00007FFA3B7E0000-00007FFA3B7F6000 libexr.dll 00007FFA3B7D0000-00007FFA3B7DE000 libj2k.dll 00007FFA3B7C0000-00007FFA3B7CE000 libjpeg.dll 00007FFA3B7B0000-00007FFA3B7C0000 libpdf.dll 00007FFA3B7A0000-00007FFA3B7AD000 libpfm.dll 00007FFA3B790000-00007FFA3B79F000 libpng.dll 00007FFA3B780000-00007FFA3B78D000 libppm.dll 00007FFA3B770000-00007FFA3B77F000 libtiff.dll 00007FFA3B760000-00007FFA3B76F000 libwebp.dll 00007FFA3B740000-00007FFA3B753000 libxcf.dll 00007FFA3B730000-00007FFA3B73F000 libdisk.dll 00007FFA3B720000-00007FFA3B730000 libgallery.dll 00007FFA3B700000-00007FFA3B711000 libpiwigo.dll 00007FFA35440000-00007FFA35468000 libashift.dll 00007FFA35420000-00007FFA35439000 libatrous.dll 00007FFA25E60000-00007FFA25E80000 libbasecurve.dll 00007FFA25E40000-00007FFA25E56000 libbasicadj.dll 00007FFA3B6F0000-00007FFA3B6FF000 libbilat.dll 00007FFA25E20000-00007FFA25E31000 libbilateral.dll 00007FFA3B680000-00007FFA3B68E000 libbloom.dll 00007FFA259E0000-00007FFA259F1000 libblurs.dll 00007FFA259C0000-00007FFA259D1000 libborders.dll 00007FFA259A0000-00007FFA259B6000 libcacorrect.dll 00007FFA36420000-00007FFA36430000 libcacorrectrgb.dll 00007FFA345B0000-00007FFA345BE000 libcensorize.dll 00007FFA261B0000-00007FFA261C0000 libchannelmixer.dll 00007FFA25970000-00007FFA2599D000 libchannelmixerrgb.dll 00007FFA25DD0000-00007FFA25DDE000 libclahe.dll 00007FFA25950000-00007FFA2596C000 libclipping.dll 00007FFA25940000-00007FFA2594E000 libcolisa.dll 00007FFA25920000-00007FFA2593B000 libcolorbalance.dll 00007FFA25900000-00007FFA2591B000 libcolorbalancergb.dll 00007FFA258E0000-00007FFA258FB000 libcolorchecker.dll 00007FFA258D0000-00007FFA258DE000 libcolorcontrast.dll 00007FFA258C0000-00007FFA258D0000 libcolorcorrection.dll 00007FFA258A0000-00007FFA258B9000 libcolorin.dll 00007FFA25890000-00007FFA2589E000 libcolorize.dll 00007FFA25870000-00007FFA25883000 libcolormapping.dll 00007FFA25850000-00007FFA25861000 libcolorout.dll 00007FFA25830000-00007FFA25843000 libcolorreconstruct.dll 00007FFA25820000-00007FFA2582F000 libcolortransfer.dll 00007FFA25800000-00007FFA2581C000 libcolorzones.dll 00007FFA257E0000-00007FFA257F4000 libcrop.dll 00007FFA257D0000-00007FFA257DF000 libdefringe.dll 00007FFA18AE0000-00007FFA18B2D000 libdemosaic.dll 00007FFA18AC0000-00007FFA18ADE000 libdenoiseprofile.dll 00007FFA18AA0000-00007FFA18AB5000 libdiffuse.dll 00007FFA25050000-00007FFA2505F000 libdither.dll 00007FFA18A80000-00007FFA18A95000 libequalizer.dll 00007FFA18A60000-00007FFA18A72000 libexposure.dll 00007FFA18A40000-00007FFA18A56000 libfilmic.dll 00007FFA18A10000-00007FFA18A3B000 libfilmicrgb.dll 00007FFA22150000-00007FFA2215D000 libfinalscale.dll 00007FFA1C5C0000-00007FFA1C5CF000 libflip.dll 00007FFA18A00000-00007FFA18A10000 libgamma.dll 00007FFA189F0000-00007FFA18A00000 libglobaltonemap.dll 00007FFA189D0000-00007FFA189E2000 libgraduatednd.dll 00007FFA189C0000-00007FFA189CE000 libgrain.dll 00007FFA189B0000-00007FFA189C0000 libhazeremoval.dll 00007FFA18990000-00007FFA189AA000 libhighlights.dll 00007FFA18980000-00007FFA1898E000 libhighpass.dll 00007FFA18970000-00007FFA1897F000 libhotpixels.dll 00007FFA18960000-00007FFA18970000 libinvert.dll 00007FFA18930000-00007FFA18951000 liblens.dll 00007FF9DA940000-00007FF9DA968000 liblensfun.dll 00007FFA15B20000-00007FFA15B2D000 libsystre-0.dll 00007FF9DA920000-00007FF9DA93F000 libtre-5.dll 00007FF9DA900000-00007FF9DA911000 liblevels.dll 00007FF9DA8E0000-00007FF9DA8FA000 libliquify.dll 00007FF9DA8C0000-00007FF9DA8D2000 liblowlight.dll 00007FF9FD250000-00007FF9FD260000 liblowpass.dll 00007FF9DA8A0000-00007FF9DA8C0000 liblut3d.dll 00007FF9C99B0000-00007FF9CA498000 libgmic.dll 00007FF9DA880000-00007FF9DA891000 libfftw3_threads-3.dll 00007FF9D9010000-00007FF9D9422000 libfftw3-3.dll 00007FF9DA820000-00007FF9DA87A000 libGraphicsMagick++-12.dll 00007FF9DA770000-00007FF9DA819000 libopencv_videoio-409.dll 4.9.0.0 00007FF9C9560000-00007FF9C99A9000 libopencv_core-409.dll 4.9.0.0 00007FF9C92E0000-00007FF9C9552000 avformat-60.dll 60.16.100.0 00007FF9C81B0000-00007FF9C92DC000 avutil-58.dll 58.29.100.0 00007FF9C6D00000-00007FF9C81AF000 avcodec-60.dll 60.31.102.0 00007FF9D8FF0000-00007FF9D900B000 libgstapp-1.0-0.dll 00007FF9D8F60000-00007FF9D8FE4000 libgstbase-1.0-0.dll 00007FF9D8ED0000-00007FF9D8F57000 libgstaudio-1.0-0.dll 00007FF9C6CE0000-00007FF9C6CFA000 libgstriff-1.0-0.dll 00007FF9C6C90000-00007FF9C6CD3000 libgstpbutils-1.0-0.dll 00007FF9C6B50000-00007FF9C6C90000 libgstreamer-1.0-0.dll 00007FF9C6AA0000-00007FF9C6B46000 swscale-7.dll 7.5.100.0 00007FF9C69D0000-00007FF9C6A9B000 libgstvideo-1.0-0.dll 00007FF9C68D0000-00007FF9C69D0000 OPENGL32.dll 10.0.22621.2506 00007FF9C6850000-00007FF9C68C8000 libopencv_imgcodecs-409.dll 4.9.0.0 00007FF9C61A0000-00007FF9C6845000 libopencv_imgproc-409.dll 4.9.0.0 00007FF9C6130000-00007FF9C6196000 libtbb12.dll 2021.11.0.0 00007FF9C60C0000-00007FF9C6123000 libbluray-2.dll 00007FF9C6060000-00007FF9C60B6000 libgme.dll 00007FF9C5E50000-00007FF9C6052000 libgnutls-30.dll 00007FF9C5D60000-00007FF9C5E4B000 libmodplug-1.dll 00007FF9C5D30000-00007FF9C5D5F000 librtmp-1.dll 00007FF9C5C60000-00007FF9C5D2B000 libsrt.dll 00007FF9C5C10000-00007FF9C5C52000 libva.dll 00007FF9C5B80000-00007FF9C5C03000 libssh.dll 00007FF9E81F0000-00007FF9E81FD000 libva_win32.dll 00007FF9C5B10000-00007FF9C5B7B000 libvpl.dll 2.10.0.0 00007FF9C5AF0000-00007FF9C5B07000 libgsm.dll 00007FF9C5A60000-00007FF9C5AE2000 libmp3lame-0.dll 00007FF9C5A20000-00007FF9C5A52000 libopencore-amrnb-0.dll 00007FF9C5A00000-00007FF9C5A20000 libopencore-amrwb-0.dll 00007FF9C5990000-00007FF9C59FB000 libopus-0.dll 00007FF9C5960000-00007FF9C5989000 libspeex-1.dll 00007FF9C2ED0000-00007FF9C595D000 libopenblas.dll 00007FF9C2EB0000-00007FF9C2ECF000 libtheoradec-1.dll 00007FF9C2E70000-00007FF9C2EAE000 libtheoraenc-1.dll 00007FF9C2DD0000-00007FF9C2E65000 libvorbisenc-2.dll 00007FF9C2AE0000-00007FF9C2DC4000 libx264-164.dll 0.164.3161.0 00007FF9C2770000-00007FF9C2ADF000 libvpx-1.dll 00007FF9C2640000-00007FF9C2761000 xvidcore.dll 00007FF9C2610000-00007FF9C2639000 swresample-4.dll 4.12.100.0 00007FF9C25B0000-00007FF9C260B000 liborc-0.4-0.dll 00007FF9C2560000-00007FF9C25AD000 libgsttag-1.0-0.dll 00007FF9C2530000-00007FF9C255D000 GLU32.dll 10.0.22621.2506 00007FF9C2470000-00007FF9C2528000 libbrotlienc.dll 00007FF9C23C0000-00007FF9C246D000 libgmp-10.dll 00007FFA48FC0000-00007FFA48FEE000 ncrypt.dll 10.0.22621.3007 00007FF9C2370000-00007FF9C23BC000 libhogweed-6.dll 00007FF9C2310000-00007FF9C2369000 libnettle-8.dll 00007FF9C22F0000-00007FF9C2310000 libtasn1-6.dll 00007FFA1FCD0000-00007FFA1FCD9000 WSOCK32.dll 10.0.22621.1 00007FF9C2180000-00007FF9C22E3000 libp11-kit-0.dll 00007FF9C2140000-00007FF9C2173000 libvorbis-0.dll 00007FF9C2120000-00007FF9C2133000 libogg-0.dll 00007FF9C2090000-00007FF9C2117000 libsoxr.dll 00007FF9C1D70000-00007FF9C2088000 libgfortran-5.dll 00007FF9C1D00000-00007FF9C1D64000 libquadmath-0.dll 00007FFA48F80000-00007FFA48FB7000 NTASN1.dll 10.0.22621.1 00007FF9E7B00000-00007FF9E7B0D000 libmask_manager.dll 00007FF9C1CE0000-00007FF9C1CF1000 libmonochrome.dll 00007FF9C1CC0000-00007FF9C1CD3000 libnegadoctor.dll 00007FF9E7AD0000-00007FF9E7ADE000 libnlmeans.dll 00007FF9E73B0000-00007FF9E73BF000 liboverexposed.dll 00007FF9E6A90000-00007FF9E6AA0000 libprofile_gamma.dll 00007FF9C1CA0000-00007FF9C1CB3000 librawdenoise.dll 00007FF9DB5D0000-00007FF9DB5DF000 librawoverexposed.dll 00007FF9C1C80000-00007FF9C1C92000 librawprepare.dll 00007FF9DA760000-00007FF9DA76E000 librelight.dll 00007FF9C1C60000-00007FF9C1C7E000 libretouch.dll 00007FF9C1C40000-00007FF9C1C5A000 librgbcurve.dll 00007FF9C1C20000-00007FF9C1C34000 librgblevels.dll 00007FF9DA690000-00007FF9DA69E000 librotatepixels.dll 00007FF9C1C10000-00007FF9C1C1E000 libscalepixels.dll 00007FF9C1BF0000-00007FF9C1C03000 libshadhi.dll 00007FF9C1BE0000-00007FF9C1BF0000 libsharpen.dll 00007FF9C1BD0000-00007FF9C1BDE000 libsoften.dll 00007FF9C1BC0000-00007FF9C1BD0000 libsplittoning.dll 00007FF9C1BA0000-00007FF9C1BB1000 libspots.dll 00007FF9C1A90000-00007FF9C1B9A000 libtemperature.dll 00007FF9C1A70000-00007FF9C1A89000 libtonecurve.dll 00007FF9C1A40000-00007FF9C1A69000 libtoneequal.dll 00007FF9C1A30000-00007FF9C1A3F000 libtonemap.dll 00007FF9C1A20000-00007FF9C1A2E000 libvelvia.dll 00007FF9C1A10000-00007FF9C1A1D000 libvibrance.dll 00007FF9C19F0000-00007FF9C1A01000 libvignette.dll 00007FF9C19D0000-00007FF9C19E4000 libwatermark.dll 00007FF9C19B0000-00007FF9C19C3000 libzonesystem.dll 00007FF9C19A0000-00007FF9C19AD000 libbackgroundjobs.dll 00007FF9C1980000-00007FF9C199B000 libcollect.dll 00007FF9C1960000-00007FF9C1971000 libcolorpicker.dll 00007FF9C1950000-00007FF9C1960000 libduplicate.dll 00007FF9C1930000-00007FF9C1947000 libexport.dll 00007FF9C1920000-00007FF9C192D000 libfilmstrip.dll 00007FF9C1910000-00007FF9C191F000 libfilter.dll 00007FF9C18F0000-00007FF9C1906000 libgeotagging.dll 00007FF9C18D0000-00007FF9C18F0000 libosmgpsmap-1.0-1.dll 00007FF9C18C0000-00007FF9C18CD000 libhinter.dll 00007FF9C18A0000-00007FF9C18B8000 libhistogram.dll 00007FF9C1880000-00007FF9C1894000 libhistory.dll 00007FF9C1870000-00007FF9C187D000 libimage_infos.dll 00007FF9C1860000-00007FF9C186D000 libioporder.dll 00007FF9C1850000-00007FF9C185D000 liblighttable_mode.dll 00007FF9C1840000-00007FF9C184F000 liblocation.dll 00007FF9C1820000-00007FF9C1831000 libmap_locations.dll 00007FF9C1810000-00007FF9C181E000 libmap_settings.dll 00007FF9C17F0000-00007FF9C1806000 libmasks.dll 00007FF9C17E0000-00007FF9C17ED000 libmasktoolbar.dll 00007FF9C17B0000-00007FF9C17D2000 libmenu.dll 00007FF9C17A0000-00007FF9C17AD000 libmenubuttons.dll 00007FF9C1780000-00007FF9C1791000 libmetadata.dll 00007FF9C1760000-00007FF9C1772000 libmetadata_view.dll 00007FF9C1740000-00007FF9C1759000 libmidi.dll 00007FF9C1720000-00007FF9C1731000 libportmidi.dll 00007FF9FCBA0000-00007FF9FCBC9000 winmmbase.dll 10.0.22621.1 00007FFA3F0E0000-00007FFA3F17D000 MMDevAPI.DLL 10.0.22621.2506 00007FF9F9A00000-00007FF9F9A46000 wdmaud.drv 10.0.22621.1 00007FFA417E0000-00007FFA417EB000 AVRT.dll 10.0.22621.2506 00007FFA2BD50000-00007FFA2BD59000 ksuser.dll 10.0.22621.1 00007FFA23350000-00007FFA2353C000 AUDIOSES.DLL 10.0.22621.2506 00007FFA2BD60000-00007FFA2BD6E000 msacm32.drv 10.0.22621.2506 00007FFA0ECB0000-00007FFA0ECCE000 MSACM32.dll 10.0.22621.1 00007FFA2BB90000-00007FFA2BB9B000 midimap.dll 10.0.22621.2506 00007FF9C1710000-00007FF9C171F000 libmodulegroups.dll 00007FF9C1700000-00007FF9C170D000 libmodule_toolbox.dll 00007FF9C16F0000-00007FF9C1700000 libnavigation.dll 00007FF9C16E0000-00007FF9C16EF000 libsnapshots.dll 00007FF9C16C0000-00007FF9C16D1000 libstyles.dll 00007FF9C16A0000-00007FF9C16BC000 libtagging.dll 00007FF9C1690000-00007FF9C169D000 libview_toolbox.dll 00007FF9C1680000-00007FF9C168D000 libpixbufloader-svg.dll 00007FFA48B80000-00007FFA48BE9000 mswsock.dll 10.0.22621.2506 00007FFA29840000-00007FFA298F0000 TextShaping.dll 10.0.22621.2506

Windows 10.0.22621.2506 DrMingw 0.9.11

Once Sony raw files are converted to dng using Adobe converter, exiv2 can't read marker notes from these dng file. I experienced the issue with all Sony A7 cameras I could test: A7III, A7IV, A7RII and A7RV.

Because of this issue, the lens correction with embedded meta-data doesn't work in darktable.

exiv2 --version
exiv2 0.27.6

exiv2 20221220-7R200672.dng | grep Vignett
Error: Directory Sony2 with 25665 entries considered invalid; not read.

exiv2 20221220-7R200672.dng | grep Chromatic
Error: Directory Sony2 with 25665 entries considered invalid; not read.

exiv2 20221220-7R200672.dng | grep Distortion
Error: Directory Sony2 with 25665 entries considered invalid; not read.

Exiftool in the other hand has no problem reading it:

exiftool 20221220-7R200672.dng | grep Vignetting
Vignetting Correction : Off
Vignetting Corr Params : 0 32 192 448 768 1184 1696 2304 3072 4000 5056 6240 7424 8576 9632 10688

exiftool 20221220-7R200672.dng | grep Chromatic
Lateral Chromatic Aberration : Off
Chromatic Aberration Corr Params: 781 731 689 656 632 621 610 586 554 511 466 429 389 339 273 223 -90 -56 -26 4 32 62 84 80 82 120 168 210 260 324 406 502

exiftool 20221220-7R200672.dng | grep "Distortion Corr"
Distortion Correction Setting : Off
Distortion Correction : None
Distortion Corr Params : 12 0 -36 -80 -144 -216 -312 -408 -524 -640 -772 -900 -1036 -1168 -1308 -1440
Distortion Corr Params Number : 16 (Full-frame)
Distortion Corr Params Present : Yes

It would probably be helpful if you posted a sample DNG.

• Phil

Here is a link to a Sony A7RII dng converted file: https://www.dropbox.com/scl/fi/f9mkzqtjk0bm3noigjoi2/20221220-7R200672.dng?rlkey=mrqlkicgjrg1nb861twmbqnxm&dl=0

Description of the bug

This is a somewhat vague issue, not sure if it is a bug per-se, but I thought it may be worth discussing anyway.

Recently I upgraded from commit 1d3f83d to the latest release (which I think is ba4dc3), and have noticed a lot slower image processing and UI response. I haven't pinned down any particular module which is slow, it seems to be a general slowdown across many aspects of the editing workflow. My PC hardware, OS, and input images haven't changed so I would guess it has been some change to Ansel since a few months ago.

Some things I have noticed:

• The UI often freezes for several seconds upon changing module parameters, even before the "working" prompt comes up (which I assume indicates the image pipeline processing).
• Sometimes it seems like the image is reprocessing for no reason ("working" prompt is shown), like clicking on a module to expand it or changing tabs in module UIs.
• General flakiness of image processing w.r.t. UI updates, e.g.:
• Colour picker doesn't always update when selecting a point on the image.
• Scopes don't always update.
• Occasionally changing parameters or toggling a module on/off doesn't update the image.
• When changing multiple module parameter in quick succession, seems like the image pipeline runs for each change, leading to long delays.
• The image processing and UI performance issues get worse with more modules active (makes sense).

By the end of editing one image, the UI feels almost unusably slow. Often waiting several seconds after any UI interaction, whereas previously everything felt pretty snappy.

I don't know what's changed in the backend with Ansel recently, but I wonder if there has been any big changes to how UI events are handled and when we decide to rerun the image pipeline.

To Reproduce

Do any kind of regular image editing in Darkroom, e.g. exposure, filmic RGB, colour calibration, colour balance, local contrast. By the end the performance issues are apparent to me, as described above.

Expected behavior

Not expecting the performance to change so significantly given that there haven't been massive changes to the image processing features I use in my editing. My PC is not the most powerful but I was quite happy with Ansel's performance previously.

System

darktable version : unknown - whichever came with the Ansel install OS : Win10, version 22H2, build 19045.3930 Memory : 8GB, 2133 MHz Graphics card : Nvidia GeForce 920MX Graphics driver : GeForce game ready driver version 537.42 OpenCL installed : unknown OpenCL activated : No GTK+ : unknown gcc : unknown cflags : unknown CMAKE_BUILD_TYPE : unknown

Additional context

• Are the steps above reproducible with a fresh edit (i.e. after discarding history)? Yes
• Do you use lua scripts? No

There is nothing specific nor useful in this issue.

There is nothing specific nor useful in this issue.

Please let me know how I may better/properly report this significant usability regression.

Merge pull request #654 from LebedevRI/bitstreams

Significantly deduplicate Bit Stream implementations

Promote generalized BitStreamerMSB16::drainImpl() as baseline implementation

Drop BitStreamerMSB32::drainImpl(), default impl is equivalent

Extract stream description out of BitStreamers

Drop BitStreamerMSB::drainImpl(), default impl is equivalent

BitVacuumerJPEG: partially generalize

BitStreamerJPEG: partially generalize

Promote generalized BitVacuumerMSB16::drainImpl() as baseline implementation

Drop BitVacuumerMSB32::drainImpl(), default impl is equivalent

BitStreamerMSB16::fillCache(): generalize

IWYU cleanup on bitstreams

Drop BitVacuumerMSB::drainImpl(), default impl is equivalent

Drop BitStreamerLSB::drainImpl(), default impl is equivalent

Drop BitVacuumerLSB::drainImpl(), default impl is equivalent

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (88138d4) 60.95% compared to head (0378e42) 60.97%.

@@ Coverage Diff @@
## develop #654 +/- ##
===========================================
+ Coverage 60.95% 60.97% +0.02% 
===========================================
 Files 268 260 -8 
 Lines 15967 15946 -21 
 Branches 2047 2044 -3 
===========================================
- Hits 9732 9723 -9 
+ Misses 6104 6095 -9 
+ Partials 131 128 -3 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

BitVacuumerMSB16: generalize drainImpl()

Extract stream description out of BitVacuumers

Skip to content

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

{{ message }}

aurelienpierreeng

/

ansel

Public

forked from edgardoh/darktable

Notifications

Fork 19

Star 574

Actions: aurelienpierreeng/ansel

Actions

CI

Loading...

Sorry, something went wrong.

Create status badge

ci.yml

433 workflow runs

433 workflow runs

Could not load branches

Nothing to show

Fix GPU memory leak on restarted pixel pipeline

CI #644:

Pull request #324

opened by tajuma

February 9, 2024 18:36

Action required

tajuma:issue-317

tajuma:issue-317

February 9, 2024 18:36

Action required

View #324

View workflow file

Enable Exiv2 0.28.x compilation. Solving issue #8

CI #643:

Pull request #319

opened by lologor

January 21, 2024 22:42

Action required

lologor:01-2024

lologor:01-2024

January 21, 2024 22:42

Action required

View #319

View workflow file

Import Session : Removed issues for Windows and some other code adjustments

CI #642:

Pull request #294

synchronize by Jiyone

January 2, 2024 13:02

25m 25s

Jiyone:win_import

Jiyone:win_import

January 2, 2024 13:02

25m 25s

View #294

View workflow file

Import Session : Removed issues for Windows and some other code adjustments

CI #641:

Pull request #294

synchronize by Jiyone

January 2, 2024 13:00

3m 17s

Jiyone:win_import

Jiyone:win_import

January 2, 2024 13:00

3m 17s

View #294

View workflow file

Darkroom: dispatch mouse events to modules only if they are enabled

CI #640:

Commit af648b7

pushed by aurelienpierre

January 2, 2024 02:24

23m 1s

master

master

January 2, 2024 02:24

23m 1s

View workflow file

CI

CI #639:

by aurelienpierre

January 2, 2024 01:24

23m 13s

master

master

January 2, 2024 01:24

23m 13s

View workflow file

CI

CI #638:

by aurelienpierre

January 2, 2024 01:24

5s

master

master

January 2, 2024 01:24

5s

View workflow file

Darkroom: do not fire the gui_post_expose callback if the module is n…

CI #637:

Commit f57be8c

pushed by aurelienpierre

January 2, 2024 01:21

3m 1s

master

master

January 2, 2024 01:21

3m 1s

View workflow file

Develop.c: minor refactoring for future reuse

CI #636:

Commit fe294d4

pushed by aurelienpierre

January 1, 2024 23:40

26m 1s

master

master

January 1, 2024 23:40

26m 1s

View workflow file

Bauhaus: use the max height of a single text line as a minimum for mi…

CI #635:

Commit 791da58

pushed by aurelienpierre

January 1, 2024 17:55

24m 39s

master

master

January 1, 2024 17:55

24m 39s

View workflow file

Add darktable as credit for homebrew build

CI #634:

Commit 6c57f16

pushed by aurelienpierre

January 1, 2024 17:43

12m 50s

master

master

January 1, 2024 17:43

12m 50s

View workflow file

Translations: add updating script

CI #633:

Commit cc40d8b

pushed by aurelienpierre

January 1, 2024 17:31

12m 54s

master

master

January 1, 2024 17:31

12m 54s

View workflow file

CI

CI #632:

Manually run

by aurelienpierre

January 1, 2024 15:23

23m 36s

master

master

January 1, 2024 15:23

23m 36s

View workflow file

CI

CI #631:

Manually run

by aurelienpierre

January 1, 2024 02:09

14m 10s

master

master

January 1, 2024 02:09

14m 10s

View workflow file

Ashift: ensure new crop is computed after other params are changed

CI #630:

Commit 50f6da4

pushed by aurelienpierre

December 31, 2023 17:39

25m 51s

master

master

December 31, 2023 17:39

25m 51s

View workflow file

Perspective correction : massive GUI overhaul

CI #629:

Commit a2e22cc

pushed by aurelienpierre

December 31, 2023 00:06

23m 20s

master

master

December 31, 2023 00:06

23m 20s

View workflow file

Bauhaus: increase line height

CI #628:

Commit cfe1bc9

pushed by aurelienpierre

December 30, 2023 22:50

23m 4s

master

master

December 30, 2023 22:50

23m 4s

View workflow file

Highlights: allow noise level up to 1 in GUI

CI #627:

Commit 01cbea2

pushed by aurelienpierre

December 30, 2023 20:42

24m 50s

master

master

December 30, 2023 20:42

24m 50s

View workflow file

Import Session : Removed issues for Windows and some other code adjustments

CI #626:

Pull request #294

synchronize by Jiyone

December 30, 2023 12:13

23m 26s

Jiyone:win_import

Jiyone:win_import

December 30, 2023 12:13

23m 26s

View #294

View workflow file

Import Session : Removed issues for Windows and some other code adjustments

CI #622:

Pull request #294

synchronize by Jiyone

December 29, 2023 11:20

23m 17s

Jiyone:win_import

Jiyone:win_import

December 29, 2023 11:20

23m 17s

View #294

View workflow file

MacOS packaging based on homebrew

CI #620:

Pull request #299

synchronize by lologor

December 29, 2023 00:57

24m 7s

lologor:12-2023

lologor:12-2023

December 29, 2023 00:57

24m 7s

View #299

View workflow file

Crop: add image_update_final_size in commit

CI #618:

Commit 807bd55

pushed by aurelienpierre

December 28, 2023 22:41

25m 42s

master

master

December 28, 2023 22:41

25m 42s

View workflow file

Import Session : Removed issues for Windows and some other code adjustments

CI #617:

Pull request #294

synchronize by Jiyone

December 28, 2023 22:24

24m 7s

Jiyone:win_import

Jiyone:win_import

December 28, 2023 22:24

24m 7s

View #294

View workflow file

import: Allow BMP files

CI #616:

Commit 4b54a2c

pushed by aurelienpierre

December 28, 2023 16:18

24m 15s

master

master

December 28, 2023 16:18

24m 15s

View workflow file

import: Allow BMP files

CI #615:

Pull request #300

opened by AlynxZhou

December 28, 2023 15:26

23m 48s

AlynxZhou:add-bmp-import

AlynxZhou:add-bmp-import

December 28, 2023 15:26

23m 48s

View #300

View workflow file

Previous 1 2 3 4 5 … 17 18 Next

You can’t perform that action at this time.

Solves issue #317

Quality Gate passed

Issues 0 New issues

Measures 0 Security Hotspots No data about Coverage 0.0% Duplication on New Code

See analysis details on SonarCloud

Merge pull request #653 from kmilos/hassy_cfv100c

Add Hasselblad CFV 100C aliases

Lens details: https://www.voigtlaender.de/lenses/vm/35-mm-12-0-ultron-aspherical-ii/?lang=en

Would love for this to be added to the lens fun database.

Thank you.

If you have the lens, take calibration-suitable pictures. Then you can run calibration and send results to us or send us calibration images and we will try to calibrate the lens. Please see: https://lensfun.github.io/calibration/

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e9c971) 60.95% compared to head (92bfa1d) 60.95%.

@@ Coverage Diff @@
## develop #653 +/- ##
========================================
 Coverage 60.95% 60.95% 
========================================
 Files 268 268 
 Lines 15967 15967 
 Branches 2047 2047 
========================================
 Hits 9732 9732 
 Misses 6104 6104 
 Partials 131 131 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Wow, CI is so green.

@kmilos thank you!

Add Hasselblad CFV 100C aliases

Merge pull request #652 from LebedevRI/bitvacuumer-crtp

BitVacuumer CRTP / source tree reorg

Move bit stream stuff into bitstreams/ out of io/

Convert BitVacuumer to CRTP, same as streamer

Extract BitStreamCacheBase stuff into BitStream.h

Merge remote-tracking branch 'upstream/pr/651' into develop

• upstream/pr/651: Pentax Q-S1 normalization

Merge remote-tracking branch 'upstream/pr/650' into develop

• upstream/pr/650: Hasselblad CFV-50c alias cleanup

Pentax Q-S1 normalization

Also drop no-samples attribute from Q10

What is the current problem you are facing ? I started moving from LrC to darktable and got some problems when trying to ask for help to improve the software, after few rounds I start search again and find the project, I will list here the issues and trying to summarise what I want to do:

• darktable-org/darktable/issues/16252
• darktable-org/darktable/issues/16253
• darktable-org/darktable/issues/16255

Where in your workflow does your problem occur ? I want to automate the ingestion process using more headless or paralel as possible, for me transform everything into cli as possible make possible to create some automations and if possible to run in another machine some will be better, this is why I open 3 issues on darktable, to be able to automate you need to have cli, to use the cli with gui, will need parallel, if you need to have a smooth/fast operation you need to divide to conquer.

Additional context Please if you want help or have a better tool, I don't want to use another tools because compat problems that can be happen because of how everyone write to XMP.

If you need help in some way or have some advice or expand the discussion.

What is the end goal of automation here ?

That's not possible as of now, because Ansel relies on a SQLite database that can't be accessed concurrently from different processes while preventing data corruption. Plus a good deal of presets and default settings is done in GUI code. CLI usage is only meant to batch-export pictures that have already been edited.

What is the end goal of automation here ?

That's not possible as of now, because Ansel relies on a SQLite database that can't be accessed concurrently from different processes while preventing data corruption. Plus a good deal of presets and default settings is done in GUI code. CLI usage is only meant to batch-export pictures that have already been edited.

Automate ingestion process mainly to build local copy and thumb cache.

Building the thumb cache has already a CLI command for the whole DB and a GUI control from global menu. As for local copies, I don't know. But for both, parallel processing is not needed.

Building the thumb cache has already a CLI command for the whole DB and a GUI control from global menu. As for local copies, I don't know. But for both, parallel processing is not needed.

thanks!

Merge pull request #2141 from payano/update_readme.md

Add MSYS2 to README.md

Merge pull request #2165 from kmilos/patch-2

Add Pentax Q-S1

We could drop "no-samples" on both this one and the Q10, as this is only about naming scheme for regular DNGs...

Alternatively, if we really want to solicit even more OOC DNG samples, we might want to add "no-samples" to the Leicas added recently?

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c2c0d9f) 60.95% compared to head (ca97ed5) 60.95%.

@@ Coverage Diff @@
## develop #651 +/- ##
========================================
 Coverage 60.95% 60.95% 
========================================
 Files 267 267 
 Lines 15967 15967 
 Branches 2047 2047 
========================================
 Hits 9732 9732 
 Misses 6104 6104 
 Partials 131 131 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

We could drop "no-samples" on both this one and the Q10, as this is only about naming scheme for regular DNGs...

Yes, please. It was an error to put (unknown-)?no-samples on DNG-only cameras.

@kmilos thank you!

The id attribute is what gets shown in dt UI (if present and different from the actual value), we only want one model for all body combos.

Hasselblad Phocus software also normalizes to just "Hasselblad CFV-50c" when converting any of these from 3FR to FFF.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c2c0d9f) 60.95% compared to head (f0bdbe7) 60.95%.

@@ Coverage Diff @@
## develop #650 +/- ##
========================================
 Coverage 60.95% 60.95% 
========================================
 Files 267 267 
 Lines 15967 15967 
 Branches 2047 2047 
========================================
 Hits 9732 9732 
 Misses 6104 6104 
 Partials 131 131 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

I guess this makes sense. This is so horrible :)

@kmilos thank you!

Hasselblad CFV-50c alias cleanup

The id is what gets shown in dt UI, we only want one model for all body combos

Hasselblad Phocus software also normalizes to just "Hasselblad CFV-50c" when converting any of these from 3FR to FFF

Merge pull request #649 from LebedevRI/broken-3fr

Support .3FR from old Hasselblad cameras

Add more Hasselblad CFV-50c alias

See https://github.com/darktable-org/rawspeed/pull/622#issuecomment-1933040200

AbstractLJpegDecoder: Hasselblad implicit EOI after Scan erratum

Fixes https://github.com/darktable-org/rawspeed/pull/622#issuecomment-1933133306

Those didn't produce valid/standard-compliant LJpeg stream, there is no EOI marker at the end, so just stop after decoding the Scan.

I looked through all the lists I could find of supported cameras and did not see any Ubiquiti Unifi cameras supported. I'm not sure if that's just a lack of interest or if I'm misunderstanding how this project works. Perhaps I need to find what sensor the camera is using? Though not sure how to do that, googling just returns "5MP CMOS" for sensor information.

Any guidance or help would be great. These cameras are great but they present a fisheye and I'd love to be able to use ffmpeg to dewarp the image for use with homekit or other services using scrypted.

Thanks again for your time and apologies if this is not the appropriate place for this.

I guess the project is mostly focused on photography cameras (slr, mirrorless, phones, etc.) but maintainers know better. Calibration itself is not a super simple procedure, especially if you want to get some sort of precise calibration and it's hard to cover hundreds or thousands of security cameras for almost no reasons, because most of the time nobody cares about and distortions for security cameras.

As about Ubiquiti cameras - it has pretty good specification with all the parameters like sensor size, field of view, basic lens parameters. For example https://techspecs.ui.com/unifi/cameras-nvrs/uvc-g5-pro has 1/2" sensor and thus crop factor 5.3 and using this crop factor and focal length (4.1) you can do a calibration. Here is an example how to do it https://pixls.us/articles/create-lens-calibration-data-for-lensfun/ (taken from this discussion https://github.com/lensfun/lensfun/discussions/1781)

Upd.: another link with calibration tutorials https://lensfun.github.io/calibration/ Upd. #2: as far as I know, lensfun does not perform reprojection, which is required to make fisheye projection rectilinear. It only corrects barrel distortion making lines straight in a current projection (which is not necessarily straight for fisheye). But I'm not 100% sure how lensfun works with different kind of projection. probably it treats everything as a rectilinear.

Also prettify all Q series model names.

Just a note of support for the request to add Pentax Q-S1.

Add Pentax Q-S1

Clang: disable -Wswitch-default

CI: add macOS arm64 job to basic workflow

MD5Benchmark: add suffix to --benchmark_min_time, actually dry-run it

Merge remote-tracking branch 'upstream/pr/647' into develop

• upstream/pr/647: Leica V-Lux 5 support

Merge remote-tracking branch 'upstream/pr/648' into develop

• upstream/pr/648: Leica V-Lux 4 support

Merge remote-tracking branch 'upstream/pr/645' into develop

• upstream/pr/645: Add some more unknown cameras

Merge remote-tracking branch 'upstream/pr/646' into develop

• upstream/pr/646: Leica S (Typ 007), S2, and S3 normalization Leica X2: remove superfluous color matrix Leica T (Typ 701), TL, and TL2 normalization Leica X and X-U (Typ 113) normalization Leica X Vario (Typ 107) normalization Leica X1 normalization Leica M and M-D (Typ 262) normalization

Enable code coverage and write test cover all code in the code base.

Here is codecov example. (I hope it is publicly visible) https://github.com/CAHEK7/lensfun/tree/codecov https://app.codecov.io/gh/CAHEK7/lensfun

Coverage build itself is already here. Only github action is required and repository admin access to properly setup codecov token and app.

Leica V-Lux 4 support

Using RPU sample.

Said to be equivalent to DMC-FZ200.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bec30b6) 60.92% compared to head (fa9e28e) 60.92%.

@@ Coverage Diff @@
## develop #648 +/- ##
========================================
 Coverage 60.92% 60.92% 
========================================
 Files 266 266 
 Lines 15960 15960 
 Branches 2046 2046 
========================================
 Hits 9723 9723 
 Misses 6105 6105 
 Partials 132 132 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

@kmilos thank you!

Confirmed equivalent to DMC-FZ1000M2

RPU sample sucks, i can not verify crop at all.

@kmilos thank you.

Leica V-Lux 5 support

Leica S (Typ 007), S2, and S3 normalization

Leica X2: remove superfluous color matrix

It is read from the DNG directly, and verified to be the same.

AFAICT, these cameras output only DNG, so this is just to normalize the make and model strings.

Leica M (Typ 262) Leica M-D (Typ 262) Leica S (Typ 007) Leica S2 Leica S3 Leica T (Typ 701) Leica TL Leica TL2 Leica X1 Leica X Vario (Typ 107) Leica X (Typ 113) Leica X-U (Typ 113)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bec30b6) 60.92% compared to head (3be16ff) 60.92%.

@@ Coverage Diff @@
## develop #646 +/- ##
========================================
 Coverage 60.92% 60.92% 
========================================
 Files 266 266 
 Lines 15960 15960 
 Branches 2046 2046 
========================================
 Hits 9723 9723 
 Misses 6105 6105 
 Partials 132 132 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

@kmilos thank you! I have not verified that these changes are correct, only did a visual inspection of the diff.

I managed to find quite a few of these DNG samples on either DPReview or PhotographyBlog to test, but not all...

Leica T (Typ 701), TL, and TL2 normalization

Leica X and X-U (Typ 113) normalization

Leica X Vario (Typ 107) normalization

Leica X1 normalization

Leica M and M-D (Typ 262) normalization

Add some more unknown cameras

Canon EOS 60Da Canon EOS-1D C Canon PowerShot Pro90 IS Fujifilm FinePix F710 Fujifilm FinePix F800EXR Fujifilm FinePix F810 Fujifilm FinePix S20Pro Fujifilm FinePix S5100 Fujifilm FinePix S9100 Leica D-Lux 2 Leica V-LUX 3 Leica V-LUX 3 Nikon D810A

Canon EOS 60Da Canon EOS-1D C Canon PowerShot Pro90 IS Fujifilm FinePix F710 Fujifilm FinePix F800EXR Fujifilm FinePix F810 Fujifilm FinePix S20Pro Fujifilm FinePix S5100 Fujifilm FinePix S9100 Leica D-Lux 2 Leica V-LUX 2 Leica V-LUX 3 Nikon D810A

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bec30b6) 60.92% compared to head (cabecdb) 60.92%.

@@ Coverage Diff @@
## develop #645 +/- ##
========================================
 Coverage 60.92% 60.92% 
========================================
 Files 266 266 
 Lines 15960 15960 
 Branches 2046 2046 
========================================
 Hits 9723 9723 
 Misses 6105 6105 
 Partials 132 132 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

@kmilos thank you! Searched each name in RPU backlog, no matches.

meson CI: remove clang32

Upstream has deprecated it.

Signed-off-by: Rosen Penev

Upstream has deprecated it.

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c8d1192) 63.93% compared to head (fa18c06) 63.93%.

@@ Coverage Diff @@
## main #2912 +/- ##
=======================================
 Coverage 63.93% 63.93% 
=======================================
 Files 104 104 
 Lines 22400 22400 
 Branches 10877 10877 
=======================================
 Hits 14322 14322 
 Misses 5854 5854 
 Partials 2224 2224 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Add Nikkor AF-S 35mm f/1.4G

From upload 5d73bf

Merge pull request #644 from LebedevRI/bitstreamerjpeg-track-marker-pos

Make BitStreamerJPEG Great Again!

Revert "LJpegDecompressor::decodeN(): skip padding before restart interval marker"

Unless there is a case where it matters for correctness, let's not do that as it's slower:

Comparing /home/lebedevri/rawspeed/build-Clang17-release/src/utilities/rsbench/rsbench-old to /home/lebedevri/rawspeed/build-Clang17-release/src/utilities/rsbench/rsbench
Benchmark Time CPU Time Old Time New CPU Old CPU New
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_mean -0.0120 -0.0120 150 148 150 148
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_median -0.0121 -0.0120 150 148 150 148
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_stddev -0.2048 -0.2032 0 0 0 0
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_cv -0.1952 -0.1936 0 0 0 0
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_mean -0.0248 -0.0248 829 808 829 808
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_median -0.0242 -0.0242 828 808 828 808
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_stddev -0.7370 -0.7363 2 0 2 0
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_cv -0.7303 -0.7296 0 0 0 0
OVERALL_GEOMEAN -0.0184 -0.0184 0 0 0 0

This reverts commit cb3a864da3657e4b9f88db23d08835cdf23b6038.

LJpegDecompressor: getStreamPosition() is usable, -12% runtime!

Comparing /home/lebedevri/rawspeed/build-Clang17-release/src/utilities/rsbench/rsbench-old to /home/lebedevri/rawspeed/build-Clang17-release/src/utilities/rsbench/rsbench
Benchmark Time CPU Time Old Time New CPU Old CPU New
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9394-compressed-lossless.DNG/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9394-compressed-lossless.DNG/threads:1/process_time/real_time_mean -0.1499 -0.1499 105 89 105 89
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9394-compressed-lossless.DNG/threads:1/process_time/real_time_median -0.1559 -0.1559 105 89 105 88
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9394-compressed-lossless.DNG/threads:1/process_time/real_time_stddev +11.2087 +11.1990 0 1 0 1
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9394-compressed-lossless.DNG/threads:1/process_time/real_time_cv +13.3613 +13.3500 0 0 0 0
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9395-compressed-lossless.DNG/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9395-compressed-lossless.DNG/threads:1/process_time/real_time_mean -0.1219 -0.1219 138 121 138 121
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9395-compressed-lossless.DNG/threads:1/process_time/real_time_median -0.1218 -0.1218 138 121 138 121
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9395-compressed-lossless.DNG/threads:1/process_time/real_time_stddev +0.2877 +0.2760 0 0 0 0
./Adobe DNG Converter/Canon EOS 5D Mark III/5G4A9395-compressed-lossless.DNG/threads:1/process_time/real_time_cv +0.4664 +0.4531 0 0 0 0
./Adobe DNG Converter/Canon EOS 5D Mark IV/B13A0729.dng/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
./Adobe DNG Converter/Canon EOS 5D Mark IV/B13A0729.dng/threads:1/process_time/real_time_mean -0.0948 -0.0948 298 270 298 270
./Adobe DNG Converter/Canon EOS 5D Mark IV/B13A0729.dng/threads:1/process_time/real_time_median -0.0940 -0.0940 298 270 298 270
./Adobe DNG Converter/Canon EOS 5D Mark IV/B13A0729.dng/threads:1/process_time/real_time_stddev -0.5894 -0.5890 1 0 1 0
./Adobe DNG Converter/Canon EOS 5D Mark IV/B13A0729.dng/threads:1/process_time/real_time_cv -0.5463 -0.5460 0 0 0 0
./Fujifilm/X100S/fujifilm-x100s-daylight-DSCF9505.dng/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
./Fujifilm/X100S/fujifilm-x100s-daylight-DSCF9505.dng/threads:1/process_time/real_time_mean -0.2091 -0.2091 79 62 79 62
./Fujifilm/X100S/fujifilm-x100s-daylight-DSCF9505.dng/threads:1/process_time/real_time_median -0.2093 -0.2093 79 62 79 62
./Fujifilm/X100S/fujifilm-x100s-daylight-DSCF9505.dng/threads:1/process_time/real_time_stddev +0.5261 +0.5346 0 0 0 0
./Fujifilm/X100S/fujifilm-x100s-daylight-DSCF9505.dng/threads:1/process_time/real_time_cv +0.9297 +0.9404 0 0 0 0
./Sony/ILCE-7RM5/7RM5-S35-LosslessCompressedMedium.ARW/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
./Sony/ILCE-7RM5/7RM5-S35-LosslessCompressedMedium.ARW/threads:1/process_time/real_time_mean -0.1273 -0.1273 171 150 171 150
./Sony/ILCE-7RM5/7RM5-S35-LosslessCompressedMedium.ARW/threads:1/process_time/real_time_median -0.1273 -0.1273 171 150 171 150
./Sony/ILCE-7RM5/7RM5-S35-LosslessCompressedMedium.ARW/threads:1/process_time/real_time_stddev +0.4437 +0.4470 0 0 0 0
./Sony/ILCE-7RM5/7RM5-S35-LosslessCompressedMedium.ARW/threads:1/process_time/real_time_cv +0.6543 +0.6581 0 0 0 0
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_mean -0.1328 -0.1328 173 150 173 150
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_median -0.1345 -0.1345 173 150 173 150
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_stddev +7.6826 +7.8204 0 1 0 1
Samsung/Galaxy S21 Ultra/20230712_115041.dng/threads:1/process_time/real_time_cv +9.0117 +9.1706 0 0 0 0
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_pvalue 0.0000 0.0000 U Test, Repetitions: 27 vs 27
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_mean -0.0463 -0.0463 869 829 869 829
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_median -0.0463 -0.0463 869 829 869 829
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_stddev +0.4310 +0.3955 0 0 0 0
Samsung/Galaxy S23 Ultra/20231214_130645.dng/threads:1/process_time/real_time_cv +0.5005 +0.4632 0 0 0 0
OVERALL_GEOMEAN -0.1272 -0.1272 0 0 0 0

Cr2Decompressor: getStreamPosition() is usable, -13% runtime!

Comparing /home/lebedevri/rawspeed/build-Clang17-release/src/utilities/rsbench/rsbench-old to /home/lebedevri/rawspeed/build-Clang17-release/src/utilities/rsbench/rsbench
Benchmark Time CPU Time Old Time New CPU Old CPU New
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
EOS 40D/_MG_0154.CR2/threads:32/process_time/real_time_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
EOS 40D/_MG_0154.CR2/threads:32/process_time/real_time_mean -0.1058 -0.1057 27 24 27 24
EOS 40D/_MG_0154.CR2/threads:32/process_time/real_time_median -0.1054 -0.1053 27 24 27 24
EOS 40D/_MG_0154.CR2/threads:32/process_time/real_time_stddev +1.3100 +1.3476 0 0 0 0
EOS 40D/_MG_0154.CR2/threads:32/process_time/real_time_cv +1.5832 +1.6252 0 0 0 0
EOS 5D Mark II/09.canon.sraw1.cr2/threads:32/process_time/real_time_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
EOS 5D Mark II/09.canon.sraw1.cr2/threads:32/process_time/real_time_mean -0.1433 -0.1426 107 91 3396 2912
EOS 5D Mark II/09.canon.sraw1.cr2/threads:32/process_time/real_time_median -0.1448 -0.1431 107 91 3395 2909
EOS 5D Mark II/09.canon.sraw1.cr2/threads:32/process_time/real_time_stddev +0.1930 -0.0059 0 0 12 12
EOS 5D Mark II/09.canon.sraw1.cr2/threads:32/process_time/real_time_cv +0.3925 +0.1595 0 0 0 0
EOS 5D Mark II/10.canon.sraw2.cr2/threads:32/process_time/real_time_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
EOS 5D Mark II/10.canon.sraw2.cr2/threads:32/process_time/real_time_mean -0.0961 -0.0961 56 51 56 51
EOS 5D Mark II/10.canon.sraw2.cr2/threads:32/process_time/real_time_median -0.0960 -0.0960 56 51 56 51
EOS 5D Mark II/10.canon.sraw2.cr2/threads:32/process_time/real_time_stddev -0.5090 -0.5048 0 0 0 0
EOS 5D Mark II/10.canon.sraw2.cr2/threads:32/process_time/real_time_cv -0.4568 -0.4522 0 0 0 0
EOS 5DS/2K4A9927.CR2/threads:32/process_time/real_time_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
EOS 5DS/2K4A9927.CR2/threads:32/process_time/real_time_mean -0.1958 -0.1958 235 189 235 189
EOS 5DS/2K4A9927.CR2/threads:32/process_time/real_time_median -0.1960 -0.1959 235 189 235 189
EOS 5DS/2K4A9927.CR2/threads:32/process_time/real_time_stddev -0.5610 -0.5659 0 0 0 0
EOS 5DS/2K4A9927.CR2/threads:32/process_time/real_time_cv -0.4541 -0.4602 0 0 0 0
EOS 5DS/2K4A9928.CR2/threads:32/process_time/real_time_pvalue 0.0004 0.0081 U Test, Repetitions: 9 vs 9
EOS 5DS/2K4A9928.CR2/threads:32/process_time/real_time_mean -0.1165 -0.0062 278 245 7018 6975
EOS 5DS/2K4A9928.CR2/threads:32/process_time/real_time_median -0.1158 -0.0040 278 245 7011 6983
EOS 5DS/2K4A9928.CR2/threads:32/process_time/real_time_stddev -0.1364 -0.0213 1 1 31 30
EOS 5DS/2K4A9928.CR2/threads:32/process_time/real_time_cv -0.0226 -0.0152 0 0 0 0
EOS 5DS/2K4A9929.CR2/threads:32/process_time/real_time_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
EOS 5DS/2K4A9929.CR2/threads:32/process_time/real_time_mean -0.0958 -0.0958 158 143 158 143
EOS 5DS/2K4A9929.CR2/threads:32/process_time/real_time_median -0.0954 -0.0955 158 143 158 143
EOS 5DS/2K4A9929.CR2/threads:32/process_time/real_time_stddev -0.3255 -0.3224 0 0 0 0
EOS 5DS/2K4A9929.CR2/threads:32/process_time/real_time_cv -0.2540 -0.2506 0 0 0 0
EOS 77D/IMG_4049.CR2/threads:32/process_time/real_time_pvalue 0.0004 0.0004 U Test, Repetitions: 9 vs 9
EOS 77D/IMG_4049.CR2/threads:32/process_time/real_time_mean -0.1523 -0.1523 156 132 156 132
EOS 77D/IMG_4049.CR2/threads:32/process_time/real_time_median -0.1517 -0.1517 155 132 155 132
EOS 77D/IMG_4049.CR2/threads:32/process_time/real_time_stddev -0.5352 -0.5282 0 0 0 0
EOS 77D/IMG_4049.CR2/threads:32/process_time/real_time_cv -0.4517 -0.4434 0 0 0 0
OVERALL_GEOMEAN -0.1300 -0.1152 0 0 0 0

BitStreamerJPEG: track position of the 'end-of-stream' marker

This time the input position remains as-is, so the termination guarantee remains unaffected.

Convert BitStreamer to CRTP

RawImageDataFloat::scaleValues(): whitePoint must exist

Merge remote-tracking branch 'upstream/pr/636' into develop

By Miloš Komarčević

Via Miloš Komarčević

• upstream/pr/636: DngDecoder: default white level for floats is simply 1

Merge pull request #643 from LebedevRI/oss-fuzz-msan

oss-fuzz: re-enable openmp for msan build

oss-fuzz: just don't delete build directory afterwards

coverage build is failing because libomp sources are in build directory, which we delete. While we could change the location of sources, perhaps just keeping the whole build dir is fine too?

libomp: re-enable ASan sanitization

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1487e4d) 60.76% compared to head (019911b) 60.76%.

@@ Coverage Diff @@
## develop #643 +/- ##
========================================
 Coverage 60.76% 60.76% 
========================================
 Files 266 266 
 Lines 15946 15946 
 Branches 2047 2047 
========================================
 Hits 9689 9689 
 Misses 6128 6128 
 Partials 129 129 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Description of the bug

The visual mapping button, mentioned in the documentation, does not seem to be present, and I cannot see a way to edit/create keyboard shortcuts? (Short of manually editing the config files.)

To Reproduce

1. Open Ansel
2. Try to find the visual mapping button

Expected behavior

Visual mapping button is present, as described in the documentation.

Context

Screenshots

Which commit introduced the error

Unknown.

System

• ansel version : 0.0.0+729~ge2c4a0a60
• OS : Arch Linux (kernel 6.7.3-zen1-1-zen)
• Linux - Distro : See above
• Memory : 64 GB
• Graphics card : AMD 6900 XT
• Graphics driver : Mesa
• OpenCL installed : Yes
• OpenCL activated : Yes
• Xorg : N/A
• Desktop : KDE Plasma (Wayland)
• GTK+ : unknown
• gcc : 13.2.1 20230801
• cflags : see build command below
• CMAKE_BUILD_TYPE : see build command below

Ansel compile/build commands (from the AUR package):

 cmake -B build \
 -DCMAKE_INSTALL_PREFIX=/usr \
 -DCMAKE_INSTALL_LIBDIR=lib \
 -DCMAKE_INSTALL_LIBEXECDIR=lib \
 -DCMAKE_BUILD_TYPE=Release \
 -DCMAKE_SKIP_RPATH=ON \
 -DBINARY_PACKAGE_BUILD=ON \
 -DUSE_LIBSECRET=ON \
 -DUSE_LUA=ON \
 -DUSE_BUNDLED_LUA=OFF \
 -DUSE_LIBRAW=ON \
 -DUSE_BUNDLED_LIBRAW=OFF \
 -DUSE_COLORD=ON \
 -DBUILD_CURVE_TOOLS=ON \
 -DBUILD_NOISE_TOOLS=ON \
 -DRAWSPEED_ENABLE_LTO=ON

cmake --build build

Ansel compile options:

compile options:
 bit depth is 64 bit
 normal build
 SSE2 optimized codepath enabled
 OpenMP support enabled
 OpenCL support enabled
 Lua support enabled, API version 8.0.0
 Colord support enabled
 GraphicsMagick support enabled
 ImageMagick support disabled
 OpenEXR support enabled

Additional context

• Can you reproduce with another darktable version(s)? unknown
• Can you reproduce with a RAW or Jpeg or both? N/A
• Are the steps above reproducible with a fresh edit (i.e. after discarding history)? yes
• If the issue is with the output image, attach an XMP file if (you'll have to change the extension to .txt)
• Is the issue still present using an empty/new config-dir (e.g. start darktable¹ with --configdir "/tmp")? yes
• Do you use lua scripts? no
• What lua scripts start automatically? N/A
• What lua scripts were running when the bug occurred? N/A

¹ darktable here I'm assuming is supposed to be ansel.

Keyboard shortcuts are temporarily removed.

It's an example of modifications, related to #2161. Partial fix for #2162. Example of how #2142 can be fixed and probably #2138 can be updated.

Deprecated lf_mount_new has been removed from cpp file (header part was done in https://github.com/lensfun/lensfun/pull/2134). I think the others C-API lf_*_new functions should be removed from cpp files too, but in separated pull requests.

If that example looks good, I can proceed with the other classes step by step.

Skip to content

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

{{ message }}

lensfun

/

lensfun

Public

Notifications

Fork 186

Star 584

Pull requests: lensfun/lensfun

New pull request New

15 Open

466 Closed

15 Open

466 Closed

No reviews

Review required

Approved review

Changes requested

Assigned to nobody

Newest

Oldest

Most commented

Least commented

Recently updated

Least recently updated

Best match

Most reactions

👍

👎

😄

🎉

😕

❤️

🚀

👀

Pull requests list

Modernize lfMount

2163

opened Feb 3, 2024 by CAHEK7

Loading…

16

Add C interface for EnableDistortionCorrection

2160

opened Feb 2, 2024 by CAHEK7

Loading…

CI: add macOS job

2159

opened Feb 2, 2024 by kmilos

Loading…

3

Update some Sigma and Tamron strings

2147

opened Jan 12, 2024 by kmilos

Loading…

1

Use smart pointers for lfLens Calibrations

2138

opened Jan 3, 2024 by payano

Loading…

12

replace "sourceforge.net" with "lensfun.github.io" in lensfun-update-data

2133

opened Dec 13, 2023 by jonas-ott

Loading…

1

Add tool for generating database updates

2132

opened Dec 13, 2023 by jonas-ott

Loading…

fix year 2038 problem

2130

opened Dec 5, 2023 by jonas-ott

Loading…

8

Add vignetting for Samyang 12mm AF

2004

opened Mar 10, 2023 by interru

Loading…

3

Added model code SAL18135 to name of Sony DT 18-135mm f/3.5-5.6 SAM

1992

opened Feb 24, 2023 by tomalakgeretkal

•

Draft

corrected name for the sigma 150-600mm contemporary

1588

opened Jan 18, 2022 by benklop

Loading…

1

12

Match library file name with soname

1351

opened Jan 26, 2021 by mikhailnov

Loading…

Stable release

3

Make plots more readable

1166

opened Apr 27, 2020 by uchrisu

Loading…

2

Give User-Profiles always priority

1151

opened Apr 24, 2020 by uchrisu

Loading…

Stable release

1

1

Another name for the Sigma 18-300mm

1039

opened Nov 18, 2019 by goddisignz

Loading…

3

ProTip! Updated in the last three days: updated:>2024-02-23 .

You can’t perform that action at this time.

The call of vector.clear() does not free all the pointers held by the vector. And since it's an assignment operator, the vector may contain some allocated pointers. For example lfMount: https://github.com/lensfun/lensfun/blob/20cbe397dc8e11eea8ea0a7ac4ca42b2b2413f34/libs/lensfun/mount.cpp#L43

The same problem exists for the lfLens assignment operator as well: https://github.com/lensfun/lensfun/blob/20cbe397dc8e11eea8ea0a7ac4ca42b2b2413f34/libs/lensfun/lens.cpp#L101

While here the pointers are handled properly: https://github.com/lensfun/lensfun/blob/20cbe397dc8e11eea8ea0a7ac4ca42b2b2413f34/libs/lensfun/lens.cpp#L111

Also that vector.clear() statement is not required for the copy constructors since in that case all the vectors are empty.

Related to #2161 if smart pointers will be used.

In https://github.com/lensfun/lensfun/issues/2142 I mentioned that the current codebase while being compiled with C++14 contains lots of pure C leftovers. One of the example uncovered in the following comment https://github.com/lensfun/lensfun/pull/2138#discussion_r1477043594 due to unnecessary C-style reinterpret cast at https://github.com/lensfun/lensfun/blob/20cbe397dc8e11eea8ea0a7ac4ca42b2b2413f34/libs/lensfun/lens.cpp#L1317

• [ ] get rid of C-style casts, replace it with appropriate C++ casts or even remove them completely
• [ ] get rid of pointer based operations while C++ containers are available. For example https://github.com/lensfun/lensfun/blob/20cbe397dc8e11eea8ea0a7ac4ca42b2b2413f34/libs/lensfun/mount.cpp#L30
• [ ] consider to use smart pointers wherever possible, take care of backward compatibility
• [ ] implement proper move constructors and operators
• [ ] (questionable) use std library instead of glib or own implementations
• [ ] (questionable) use std::string if possible instead of raw char *, take care of backward compatibility

Merge pull request #640 from LebedevRI/oss-fuzz-bundled-omp

oss-fuzz: OpenMP-aware fuzzing

DngDecoder: actually correctly handle defaulted white point

Without white point being optional this would've never been caught.

RawImageData::subFrame(): cropping to empty image is malformed.

DngDecoder: make bps an Optional

oss-fuzz: just build our own libomp

LLVMOpenMP.cmake: disable libomptarget

Try to update bundled libomp to 17

VC5Decompressor::createWaveletBandDecodingTasks(): iterate over reverse bands

LLVMOpenMP.cmake: disable all sanitizers

ASan, UBSan and MSan are all complaining.

CMake: rawspeed_parsers (transitively) needs OpenMP

oss-fuzz: don't enable omp for MSan builds

oss-fuzz: do build with OpenMP

OpenMP structured blocks can't throw, and that invariant is generally not reflected in the code (unless done manually) when compiled without OpenMP, and that hides bugs (787695f19bba53c5186cd89ee383884e69d6a285 e.g.)

rawspeed_get_number_of_processor_cores() returns 1 for fuzzers, so there should not be any actual multi-threading done.

Actually allow using bundled libomp when no system libomp exists

find_package(OpenMP) doesn't work then.

VC5Decompressor: avoid OpenMP-specific heap-use-after-free

This is rather convoluted.

=================================================================
==360017==ERROR: AddressSanitizer: heap-use-after-free on address 0x5110000020c8 at pc 0x556f25741bed bp 0x7feae20da010 sp 0x7feae20da008
READ of size 8 at 0x5110000020c8 thread T27
 #0 0x556f25741bec in .omp_outlined..49 /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:349:7
 #1 0x556f25741bec in .omp_task_entry..50 /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:344:1
 #2 0x7feb04f37452 (/lib/x86_64-linux-gnu/libomp.so.5+0x68452) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #3 0x7feb04f3b704 (/lib/x86_64-linux-gnu/libomp.so.5+0x6c704) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #4 0x7feb04f4d174 (/lib/x86_64-linux-gnu/libomp.so.5+0x7e174) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #5 0x7feb04f4775e (/lib/x86_64-linux-gnu/libomp.so.5+0x7875e) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #6 0x7feb04f45adf (/lib/x86_64-linux-gnu/libomp.so.5+0x76adf) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #7 0x7feb04efcd3f in __kmpc_barrier (/lib/x86_64-linux-gnu/libomp.so.5+0x2dd3f) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #8 0x556f25754f5b in rawspeed::VC5Decompressor::decodeThread(bool&) const /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:838:19
 #9 0x7feb04faf002 in __kmp_invoke_microtask (/lib/x86_64-linux-gnu/libomp.so.5+0xe0002) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #10 0x7feb04f183c8 (/lib/x86_64-linux-gnu/libomp.so.5+0x493c8) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #11 0x7feb04f16955 (/lib/x86_64-linux-gnu/libomp.so.5+0x47955) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #12 0x7feb04f88137 (/lib/x86_64-linux-gnu/libomp.so.5+0xb9137) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #13 0x556f256e281e in asan_thread_start(void*) crtfastmath.c
 #14 0x7feb04c6945b in start_thread nptl/pthread_create.c:444:8
 #15 0x7feb04ce9bbb in clone3 misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

0x5110000020c8 is located 8 bytes inside of 240-byte region [0x5110000020c0,0x5110000021b0)
freed by thread T16 here:
 #0 0x556f25718a61 in operator delete(void*) (/home/lebedevri/rawspeed/build-Clang17-FUZZ/fuzz/librawspeed/decompressors/VC5DecompressorFuzzer+0x1b8a61) (BuildId: dd91d53719a432f2)
 #1 0x556f25741b3e in std::default_delete::operator()(rawspeed::VC5Decompressor::Wavelet::AbstractBand*) const /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93:2
 #2 0x556f25741b3e in std::unique_ptr>::~unique_ptr() /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:398:4
 #3 0x556f25741b3e in void std::destroy_at>>(std::unique_ptr>*) /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:88:15
 #4 0x556f25741b3e in void std::_Destroy>>(std::unique_ptr>*) /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:149:7
 #5 0x556f25741b3e in void std::_Destroy_aux::__destroy>*>(std::unique_ptr>*, std::unique_ptr>*) /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:163:6
 #6 0x556f25741b3e in void std::_Destroy>*>(std::unique_ptr>*, std::unique_ptr>*) /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:195:7
 #7 0x556f25741b3e in void std::_Destroy>*, std::unique_ptr>>(std::unique_ptr>*, std::unique_ptr>*, std::allocator>>&) /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/alloc_traits.h:941:7
 #8 0x556f25741b3e in std::vector>, std::allocator>>>::_M_erase_at_end(std::unique_ptr>*) /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_vector.h:1944:6
 #9 0x556f25741b3e in std::vector>, std::allocator>>>::clear() /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_vector.h:1605:9
 #10 0x556f25741b3e in .omp_outlined..49 /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:349:21
 #11 0x556f25741b3e in .omp_task_entry..50 /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:344:1
 #12 0x7feb04f37452 (/lib/x86_64-linux-gnu/libomp.so.5+0x68452) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)
 #13 0x7feb04f3b704 (/lib/x86_64-linux-gnu/libomp.so.5+0x6c704) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)

previously allocated by thread T0 here:
 #0 0x556f257181e1 in operator new(unsigned long) (/home/lebedevri/rawspeed/build-Clang17-FUZZ/fuzz/librawspeed/decompressors/VC5DecompressorFuzzer+0x1b81e1) (BuildId: dd91d53719a432f2)
 #1 0x556f25750462 in std::__detail::_MakeUniq::__single_object std::make_unique(rawspeed::VC5Decompressor::Wavelet&, bool&, bool&) /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:1076:30
 #2 0x556f25750462 in rawspeed::VC5Decompressor::parseLargeCodeblock(rawspeed::ByteStream) /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:810:28
 #3 0x556f25745535 in rawspeed::VC5Decompressor::parseVC5() /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:588:9
 #4 0x556f2574348c in rawspeed::VC5Decompressor::VC5Decompressor(rawspeed::ByteStream, rawspeed::RawImage const&) /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:431:3
 #5 0x556f2571af96 in LLVMFuzzerTestOneInput /home/lebedevri/rawspeed/fuzz/librawspeed/decompressors/VC5Decompressor.cpp:55:31
 #6 0x556f2562fe84 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) crtfastmath.c
 #7 0x556f25630849 in fuzzer::Fuzzer::TryDetectingAMemoryLeak(unsigned char const*, unsigned long, bool) crtfastmath.c
 #8 0x556f2561927e in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) crtfastmath.c
 #9 0x556f2561edd6 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) crtfastmath.c
 #10 0x556f25648596 in main (/home/lebedevri/rawspeed/build-Clang17-FUZZ/fuzz/librawspeed/decompressors/VC5DecompressorFuzzer+0xe8596) (BuildId: dd91d53719a432f2)
 #11 0x7feb04c086c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

Thread T27 created by T0 here:
 #0 0x556f256ca4c1 in pthread_create (/home/lebedevri/rawspeed/build-Clang17-FUZZ/fuzz/librawspeed/decompressors/VC5DecompressorFuzzer+0x16a4c1) (BuildId: dd91d53719a432f2)
 #1 0x7feb04f87737 (/lib/x86_64-linux-gnu/libomp.so.5+0xb8737) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)

Thread T16 created by T0 here:
 #0 0x556f256ca4c1 in pthread_create (/home/lebedevri/rawspeed/build-Clang17-FUZZ/fuzz/librawspeed/decompressors/VC5DecompressorFuzzer+0x16a4c1) (BuildId: dd91d53719a432f2)
 #1 0x7feb04f87737 (/lib/x86_64-linux-gnu/libomp.so.5+0xb8737) (BuildId: 49f63176f1578200567d2439fd1ca076a4a2c2b3)

SUMMARY: AddressSanitizer: heap-use-after-free /home/lebedevri/rawspeed/src/librawspeed/decompressors/VC5Decompressor.cpp:349:7 in .omp_outlined..49
Shadow bytes around the buggy address:
 0x511000001e00: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
 0x511000001e80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 0x511000001f00: 00 00 00 00 00 00 fa fa fa fa fa fa fa fa fa fa
 0x511000001f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 0x511000002000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa fa
=>0x511000002080: fa fa fa fa fa fa fa fa fd[fd]fd fd fd fd fd fd
 0x511000002100: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
 0x511000002180: fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa fa
 0x511000002200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 0x511000002280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa fa
 0x511000002300: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
 Addressable: 00
 Partially addressable: 01 02 03 04 05 06 07
 Heap left redzone: fa
 Freed heap region: fd
 Stack left redzone: f1
 Stack mid redzone: f2
 Stack right redzone: f3
 Stack after return: f5
 Stack use after scope: f8
 Global redzone: f9
 Global init order: f6
 Poisoned by user: f7
 Container overflow: fc
 Array cookie: ac
 Intra object redzone: bb
 ASan internal: fe
 Left alloca redzone: ca
 Right alloca redzone: cb
==360017==ABORTING

OrfDecoder::decodeMetaDataInternal(): default to 12-bit white level

Add C interface for lfModifier::EnableDistortionCorrection (const lfLensCalibDistortion& lcd), addresses https://github.com/lensfun/lensfun/issues/502

I'm just a bit concerned about naming.

Cr2Decoder::decodeMetaDataInternal(): default white level to ljpeg sample precision

Revert "Merge pull request #631 from LebedevRI/fuzz-with-omp"

To make CI green. It is not yet obvious how this will be re-approached.

This reverts commit 3b5b63f1e52682822a825c51557b641642da7ad4, reversing changes made to 40f531f503e9e8988f5afe41f65723938d78b7d6.

Merge pull request #2158 from kmilos/patch-2

Add OM System OM-1 II

https://github.com/darktable-org/rawspeed/pull/610 redux

It is basically the same as the supported X-A10.

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dd50b78) 60.78% compared to head (f852acd) 60.77%.

@@ Coverage Diff @@
## develop #640 +/- ##
===========================================
- Coverage 60.78% 60.77% -0.02% 
===========================================
 Files 266 266 
 Lines 15949 15952 +3 
 Branches 2047 2051 +4 
===========================================
 Hits 9695 9695 
- Misses 6125 6127 +2 
- Partials 129 130 +1 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Alright, that is good enough for now.

DngDecoder: default white level for floats is simply 1

1. We divide by white level to normalize the image s.t. the 1.0 becomes the white level.
2. In DNG spec, white level is always an integer, there can not be a non-integral white level.
3. Additionally, no white level for FP DNG's means that it is pre-normalized (default is 1.0). Therefore, we can surmise that a) FP DNG's never have white level of <1.0 b) FP DNG's always have integral white level c) if FP DNG has a white level of w, it is always correct to divide by float(w) to normalize the image ... therefore, we can, as an optimization, store FP DNG white level as an integer.

This matches DNG SDK behavior.

Runs on 'macos-14' explicitly to test arm64 architecture ('macos-latest' is still 'macos-12', which is on x86_64).

While you are at it could you also upgrade actions/setup-python@v4 to v5 in .github/workflows/cmake-windows.yml to fix the Node.js 16 deprecation warning?

Done.

You could also consider enabling automatic action updates: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c8d1192) 63.93% compared to head (9466b4c) 63.93%.

@@ Coverage Diff @@
## main #2910 +/- ##
=======================================
 Coverage 63.93% 63.93% 
=======================================
 Files 104 104 
 Lines 22400 22400 
 Branches 10877 10877 
=======================================
 Hits 14322 14322 
 Misses 5854 5854 
 Partials 2224 2224 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Hm, Conan is not picking up system brotli on Ubuntu for some reason (the version is 1.0.9), but I guess it's not a big deal...

Merge pull request #639 from kmilos/kmilos/fuji_xa20_u

Add Fujifilm X-A20 placeholder

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (65c98e1) 60.78% compared to head (4c815fe) 60.78%.

@@ Coverage Diff @@
## develop #639 +/- ##
========================================
 Coverage 60.78% 60.78% 
========================================
 Files 266 266 
 Lines 15947 15947 
 Branches 2047 2047 
========================================
 Hits 9694 9694 
 Misses 6125 6125 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

@kmilos thank you!

Add Fujifilm X-A20 placeholder

Merge pull request #638 from LebedevRI/unknown-white-level

Unknown white level

Optional: add value_or() helper

Signed-off-by: Roman Lebedev

DngDecoder/RawImageDataFloat::scaleBlackWhite(): no white level means 1.0F

RawImageDataFloat::scaleBlackWhite() is dead code, i bet nobody uses it.

Convert whitePoint to Optional

For now, just assume it is always set.

Merge pull request #637 from kmilos/patch-2

Add Sony ZV-1M2 placeholder

Duh, already had https://github.com/darktable-org/rawspeed/pull/488

As i've explained before, i'd rather merge this kind of thing than have https://github.com/darktable-org/rawspeed/pull/488 leave forever open.

Go for it.

PR's can't be reopened once the branch has been deleted.

Sorry 😔

@kmilos thank you!

Add Sony ZV-1M2 placeholder

1. We divide by white level to normalize the image s.t. the 1.0 becomes the white level.
2. In DNG spec, white level is always an integer, there can not be a non-integral white level.
3. Additionally, no white level for FP DNG's means that it is pre-normalized (default is 1.0).

Therefore, we can surmise that a) FP DNG's never have white level of <1.0 b) FP DNG's always have integral white level c) if FP DNG has a white level of w, it is always correct to divide by float(w) to normalize the image ... therefore, we can, as an optimization, store FP DNG white level as an integer.

This matches DNG SDK behavior.

I don't think this is better.

I don't think this is better.

Better or not is not relevant - it is what the SDK does.

it is what the SDK does.

in addition to the SDK source code, this is also written in the standard: https://helpx.adobe.com/content/dam/help/en/photoshop/pdf/DNG_Spec_1_7_1_0.pdf#page=29

I'm fully aware of that, and none of that is a relevant argument here, because it dictates how the value is stored in DNG, it does not and can not dictate how the value is later stored in implementations.

The spec is somewhat ambiguous: says 1.0 but type is SHORT/LONG.

The SDK removes the ambiguity for me.

Spec says default is 1.0 for float, it doesn’t say it’s the only possible value.

I don't think this is better.

Better or not is not relevant - it is what the SDK does.

Does SDK really store 1.0f as (int)1 (0x1 hex)?

Yep, see the link.

Aha. But as i have said, i don't see how that is relevant here. It is still a magic constant. Why would we better off using that one over the one we use?

It's the correct default value 3rd parties could assume and rely on, just like 2^bps-1.

Is this a practical or theoretical concern?

For example, https://github.com/darktable-org/darktable/pull/16206 relies on either the float DNG file itself carries WhiteLevel=1, or rawspeed feeds it a 1 if absent.

Once again, the fact that SDK returns (int)1 as default white level for FP DNG's is a hack / workaround for the lack of std::variant for when that function was written.

We are not required to be bug-for-bug compatible with some other library. Returning 1 there is just as much as a magic number as returning 65535 or 65536.

There is absolutely no reason whatsoever why that idiotic behavior must now be mirrored in/by dt's img->raw_white_point. (just a add a boolean img->raw_is_prenormalized?)

DNG spec does not say that for FP DNG's, white level of (int)1 means that it is normalized.

Likewise, there's inversion of cause and effect ordering there. The current code does not rely on (int)1 being returned in such situations. Changing the magic constant breaks all other users (i should not have merged #635.) That patch will just have to rely on some other magic number.

Returning 1 there is just as much as a magic number as returning 65535 or 65536.

The DNG spec text says the default value for float files is 1.0, not 65535.0, nor 65536.0... I don't think there's anything arbitrary/magic here.

That's like saying one can return a random number in the integer case, while the spec says it's 2^bps-1?

Let's just remove both defaults then?

And yes, the previous PR was a bit hasty before the dust settled down, sorry about that.

Returning 1 there is just as much as a magic number as returning 65535 or 65536.

The DNG spec text says the default value for float files is 1.0, not 65535.0, nor 65536.0... I don't think there's anything arbitrary/magic here.

Once again, there is a confusion/conflation of the specification, which only dictates what some particular value of particular tag (or lack thereof) means, and how an implementation needs to further represent that knowledge.

I never argued that the default isn't 1.0, i only said that we can't represent float white level, and thus any representation of that fact as an integer results in a magic number that requires special treatment by consumers. Regardless of what that number is.

https://github.com/darktable-org/rawspeed/pull/638 either makes things slightly more sufferable, or worse.

638 either makes things slightly more sufferable, or worse.

I feel it's overcomplicating things...

After sleeping on this, the wordiage that should have been here, and would have helped, is:

1. we divide by white level to normalize the image s.t. the 1.0 becomes the white level
2. in dng, white level is always an integer, there can not be a non-integral white level.
3. additionally, no white level for FP DNG's means that it is pre-normalized.
therefore, we can surmise that
a) FP DNG's never have white level of <1.0
b) FP DNG's always have integral white level
c) if FP DNG has a white level of `w`, it is always correct to divide by float(w) to normalize the image
... therefore, we can, as an optimization, store FP DNG white level as an integer

One-line commit messages (and PR descriptions) suck. Please update the commit message with that wording.

But even with that, #638 is correct. Encoding the state "we don't actually know what the value is" via some magic numbers is just wrong.

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (db1b955) 60.78% compared to head (75ebaaa) 60.80%. Report is 17 commits behind head on develop.

@@ Coverage Diff @@
## develop #636 +/- ##
===========================================
+ Coverage 60.78% 60.80% +0.01% 
===========================================
 Files 266 266 
 Lines 15947 15947 
 Branches 2047 2047 
===========================================
+ Hits 9694 9696 +2 
+ Misses 6125 6123 -2 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

But even with that, https://github.com/darktable-org/rawspeed/pull/638 is correct.

Formally, yes. But thanks for reconsidering, I feel it makes sense and is the pragmatic thing to do here.

I'll improve the commit message. Shall I put those comments in the code as well?

I'll improve the commit message. Shall I put those comments in the code as well?

Yes, i think something like this should be best:

// A white level of the image, if known.
// NOTE: it is always correct to divide the pixel by float(whiteLevel) to normalize the image.
// NOTE: for floating-point images, the white level is never non-integral, and thus >= 1.0f
Optional whiteLevel;

@kmilos Thank you!

Merge pull request #635 from kmilos/kmilos/dng_float_white

DngDecoder: use uninitialized white point value for float DNGs

E.g. HDRMerge will use 65535 for real 16b cameras, don't hijack it.

This is to go w/ https://github.com/darktable-org/darktable/pull/16206

~~TODO: WhiteLevel should probably become float to support RATIONAL type and default value 1.0 (same goes for BlackLevel).~~

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0804b2b) 60.79% compared to head (f2ad598) 60.79%.

@@ Coverage Diff @@
## develop #635 +/- ##
========================================
 Coverage 60.79% 60.79% 
========================================
 Files 266 266 
 Lines 15941 15941 
 Branches 2044 2046 +2 
========================================
 Hits 9691 9691 
 Misses 6122 6122 
 Partials 128 128 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Yeah i don't know, seems broken either way. Thank you.

Yeah i don't know, seems broken either way.

Yep, "damned if you do, damned if you don't" sort of thing... ~~(until full support for rationals is implemented.)~~

Actually, after taking a look around the SDK, this should literally be "1"...

DngDecoder: use uninitialized white point value for float DNGs

E.g. HDRMerge will use 65535 for real 16b cameras, don't hijack it.

Prettify some Olympus model strings

Add OM System OM-1 II

Merge pull request #634 from LebedevRI/jpeg-overflow-revert

Re-add BitStreamerJPEG forward progress guarantee

codecov: macos coverage now comes from non-X86 builds

BitStreamerJPEGBenchmark: also try BitStreamerMSB (over non-Stuffed input)

Extract advanceToNextMarker() out of AbstractLJpegDecoder::getNextMarker()

AbstractLJpegDecoder::parseSOS(): don't expect scanLength to be reasonable

LJpegDecompressor::decodeN(): skip padding before restart interval marker

LJpegDecompressor::decodeN(): don't rely on BitStreamer::getStreamPosition()

Cr2Decompressor::decompressN_X_Y(): insist that we've advanced 0 bytes

This reverts commit 861923566436a9ceaa896dacbfb1c5209b46ad81.

Revert "BitStreamerJPEG::fillCache(): don't mark JPEG Marker bytes (and further) as consumed"

This reverts commit f47140a7a94d756deb4de411ce8f2df9f8b5422a.

As expected, f47140a7a94d756deb4de411ce8f2df9f8b5422a broke nearly all fuzzers. Performance is nice, but not at that cost. For now, just go back to the known-correct implementation, without reverting JPEG restart interval handling.

Merge pull request #631 from LebedevRI/fuzz-with-omp

oss-fuzz: do build with OpenMP

Merge pull request #633 from LebedevRI/ci

CI: macos-14 / XCode 15.2

CI: macos-14 / XCode 15.2

Merge pull request #632 from kmilos/patch-1

Add OM System OM-1 Mark II placeholder

@kmilos thank you!

Add OM System OM-1 Mark II placeholder

A missing space between different languages found today.

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

214 New issues 0 Security Hotspots No data about Coverage 2.2% Duplication on New Code

See analysis details on SonarCloud

OpenMP structured blocks can't throw, and that invariant is generally not reflected in the code (unless done manually) when compiled without OpenMP, and that hides bugs (787695f19bba53c5186cd89ee383884e69d6a285 e.g.)

rawspeed_get_number_of_processor_cores() returns 1 for fuzzers, so there should not be any actual multi-threading done.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c52d923) 60.86% compared to head (3e00628) 60.86%. Report is 4 commits behind head on develop.

@@ Coverage Diff @@
## develop #631 +/- ##
========================================
 Coverage 60.86% 60.86% 
========================================
 Files 266 266 
 Lines 15941 15941 
 Branches 2053 2053 
========================================
 Hits 9702 9702 
 Misses 6108 6108 
 Partials 131 131 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Merge pull request #630 from LebedevRI/next

Be more correct about exceptions and omp structured blocks

Skip to content

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

{{ message }}

aurelienpierreeng

/

ansel

Public

forked from edgardoh/darktable

Notifications

Fork 18

Star 563

Actions: aurelienpierreeng/ansel

Actions

All workflows

Loading...

Sorry, something went wrong.

Showing runs from all workflows

2,463 workflow runs

2,463 workflow runs

Could not load branches

Nothing to show

Nightly Win PKG

Nightly Win PKG #449:

Scheduled

January 29, 2024 01:03

18m 41s

master

master

January 29, 2024 01:03

18m 41s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #486:

Scheduled

January 29, 2024 00:36

14m 32s

master

master

January 29, 2024 00:36

14m 32s

View workflow file

Nightly Mac PKG

Nightly Mac PKG #415:

Scheduled

January 29, 2024 00:29

1m 32s

master

master

January 29, 2024 00:29

1m 32s

View workflow file

Crash on import-Copy to disk

Matrix bot #616:

Issue #320

edited by elidigui

January 28, 2024 10:26

21s

January 28, 2024 10:26

21s

View workflow file

Crash on import-Copy to disk

Matrix bot #615:

Issue #320

opened by elidigui

January 28, 2024 08:55

24s

January 28, 2024 08:55

24s

View workflow file

Nightly Win PKG

Nightly Win PKG #448:

Scheduled

January 28, 2024 01:07

19m 12s

master

master

January 28, 2024 01:07

19m 12s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #485:

Scheduled

January 28, 2024 00:39

14m 0s

master

master

January 28, 2024 00:39

14m 0s

View workflow file

Nightly Mac PKG

Nightly Mac PKG #414:

Scheduled

January 28, 2024 00:32

55s

master

master

January 28, 2024 00:32

55s

View workflow file

Nightly Win PKG

Nightly Win PKG #447:

Scheduled

January 27, 2024 01:01

19m 37s

master

master

January 27, 2024 01:01

19m 37s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #484:

Scheduled

January 27, 2024 00:36

13m 46s

master

master

January 27, 2024 00:36

13m 46s

View workflow file

Nightly Mac PKG

Nightly Mac PKG #413:

Scheduled

January 27, 2024 00:29

1m 6s

master

master

January 27, 2024 00:29

1m 6s

View workflow file

Nightly Win PKG

Nightly Win PKG #446:

Scheduled

January 26, 2024 01:03

19m 41s

master

master

January 26, 2024 01:03

19m 41s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #483:

Scheduled

January 26, 2024 00:36

14m 22s

master

master

January 26, 2024 00:36

14m 22s

View workflow file

Nightly Mac PKG

Nightly Mac PKG #412:

Scheduled

January 26, 2024 00:30

1m 6s

master

master

January 26, 2024 00:30

1m 6s

View workflow file

Nightly Win PKG

Nightly Win PKG #445:

Scheduled

January 25, 2024 01:08

19m 13s

master

master

January 25, 2024 01:08

19m 13s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #482:

Scheduled

January 25, 2024 00:39

13m 34s

master

master

January 25, 2024 00:39

13m 34s

View workflow file

Nightly Mac PKG

Nightly Mac PKG #411:

Scheduled

January 25, 2024 00:32

1m 23s

master

master

January 25, 2024 00:32

1m 23s

View workflow file

Nightly Win PKG

Nightly Win PKG #444:

Scheduled

January 24, 2024 01:08

19m 7s

master

master

January 24, 2024 01:08

19m 7s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #481:

Scheduled

January 24, 2024 00:39

14m 43s

master

master

January 24, 2024 00:39

14m 43s

View workflow file

Nightly Mac PKG

Nightly Mac PKG #410:

Scheduled

January 24, 2024 00:32

58s

master

master

January 24, 2024 00:32

58s

View workflow file

Nightly Win PKG

Nightly Win PKG #443:

Scheduled

January 23, 2024 01:08

19m 16s

master

master

January 23, 2024 01:08

19m 16s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #480:

Scheduled

January 23, 2024 00:39

14m 1s

master

master

January 23, 2024 00:39

14m 1s

View workflow file

Nightly Mac PKG

Nightly Mac PKG #409:

Scheduled

January 23, 2024 00:32

1m 6s

master

master

January 23, 2024 00:32

1m 6s

View workflow file

Nightly Win PKG

Nightly Win PKG #442:

Scheduled

January 22, 2024 01:10

19m 14s

master

master

January 22, 2024 01:10

19m 14s

View workflow file

Nightly Linux PKG

Nightly Linux PKG #479:

Scheduled

January 22, 2024 00:41

13m 5s

master

master

January 22, 2024 00:41

13m 5s

View workflow file

Previous 1 2 3 4 5 … 98 99 Next

You can’t perform that action at this time.

CrwDecompressor::decompress(): rely on CTAD

AbstractDngDecompressor::decompressThread(): widen the try{} blocks

FujiDecompressorImpl::decompressThread(): widen the try block

PanasonicV7Decompressor::decompress(): decompressRow() won't throw

PanasonicV5Decompressor::decompressInternal(): decompressRow() won't throw

PanasonicV5Decompressor::decompressThread(): processBlock() won't throw

PanasonicV4Decompressor::decompressThread(): processBlock() won't throw

rstest: no other exception types are expected

VC5Decompressor: no other exception types are expected

SonyArw2Decompressor::decompressThread(): no other exception types are expected

PhaseOneDecompressor::decompressThread(): no other exception types are expected

FujiDecompressorImpl::decompressThread(): no other exception types are expected

AbstractDngDecompressor::decompressThread(): no other exception types are expected

RawImageWorker::performTask(): no other exception types are expected

Standardized file supported by many editors to avoid bad indentation.

Legend

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c8d1192) 63.93% compared to head (92a41df) 63.93%.

@@ Coverage Diff @@
## main #2909 +/- ##
=======================================
 Coverage 63.93% 63.93% 
=======================================
 Files 104 104 
 Lines 22400 22400 
 Branches 10877 10877 
=======================================
 Hits 14322 14322 
 Misses 5854 5854 
 Partials 2224 2224 

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

Merge remote-tracking branch 'upstream/pr/629' into develop

Fixes https://github.com/darktable-org/rawspeed/issues/403 Refs. https://github.com/darktable-org/darktable/issues/14969 Refs. https://github.com/darktable-org/darktable/issues/15480 Refs. https://github.com/darktable-org/darktable/issues/13782

Does not affect the performance of the non-restart-interval path.

• upstream/pr/629: LJpegDecompressor::decodeN(): do proper restart marker checking LJpegDecompressor::decodeN(): actually skip restart marker, restart intervals are supported LJpegDecompressor::decodeN(): use ByteStream LJpegDecompressor::decodeN(): add new loop over each restart interval LJpeg: plumb numRowsPerRestartInterval into LJpegDecompressor, not supported yet. LJpeg: sink restart interval refutation into individual decoders LJpegDecoder::decodeScan(): extract some helper variables LJpegDecompressor: extract decodeRowN() out of decodeN() LJpegDecompressor: decode*() can be const LJpegDecompressor: get row-ref and operate on it rather than 2d-ref LJpegDecompressor: track predNext via a proper Array1DRef, not pointer LJpegDecompressor: s/bitStreamer/bs/ JpegMarkers.h: add getRestartMarkerNumber() helper Extract peekMarker into JpegMarkers.h Extract JpegMarker into it's own header BitStreamer: add skipBits() (with fill), for symmetry with the rest of methods ArwDecoder::DecodeLJpeg(): LJpegDecoder may throw, which is not okay here

LJpeg: sink restart interval refutation into individual decoders

LJpegDecompressor::decodeN(): add new loop over each restart interval

Benchmarking shows no performance change for the normal, non-restart-interval case, so we're good.

LJpegDecompressor::decodeN(): actually skip restart marker, restart intervals are supported

And thats the magic - the actual byte stream for all of the MCU's of the restart interval is followed by a JPEG Marker with the restart interval's counter (modulo 8) (except for the last restart interval), and we need to skip it to get to the bytes for the MCU's of the next restart interval.

Again, performance-neutral.

LJpeg: plumb numRowsPerRestartInterval into LJpegDecompressor, not supported yet.

LJpegDecoder::decodeScan(): extract some helper variables

LJpegDecompressor::decodeN(): do proper restart marker checking

We shouldn't really blindly hope that those two bytes are what we hope they are, we should verify that they are a restart marker, with correct number (modulo 8).

I'm not sure if there are cases where we don't exhaust the entirety of the input buffer beforehand, as in, may there be padding bytes before said restart marker?

Again, performance-neutral for the normal case.

LJpegDecompressor::decodeN(): use ByteStream

While a simple counter is enough right now, proper handling of restart intervals will require actually reading from the position in the buffer, and that requires actual run-time bounds checking, so we'll need ByteStream.

This, also, does not seem to affect performance of the current cases.

LJpegDecompressor: extract decodeRowN() out of decodeN()

Performance-neutral. The story may be different is ht is sunk.

LJpegDecompressor: decode*() can be const

LJpegDecompressor: get row-ref and operate on it rather than 2d-ref

LJpegDecompressor: track predNext via a proper Array1DRef, not pointer

LJpegDecompressor: s/bitStreamer/bs/

JpegMarkers.h: add getRestartMarkerNumber() helper

Extract peekMarker into JpegMarkers.h

Extract JpegMarker into it's own header

BitStreamer: add skipBits() (with fill), for symmetry with the rest of methods

ArwDecoder::DecodeLJpeg(): LJpegDecoder may throw, which is not okay here

We are in OpenMP thread, exceptions can't escape it.

Skip to content

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

{{ message }}

aurelienpierreeng

/

ansel

Public

forked from edgardoh/darktable

Notifications

Fork 18

Star 563

Insights: aurelienpierreeng/ansel

January 22, 2024 – January 29, 2024

Filter activity

24 hours

3 days

1 week

1 month

Overview

0 Active pull requests

1 Active issue

0

Merged pull requests

0

Open pull requests

0

Closed issues

1

New issue

There hasn’t been any commit activity on aurelienpierreeng/ansel in the last week.

Want to help out?

1 Issue opened by 1 person

Crash on import-Copy to disk

320 opened Jan 28, 2024

2 Unresolved conversations

Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.

UI Scopes module

293 commented on Jan 26, 2024 • 1 new comment

Zooming messes with pipeline (preview in Darkroom not stable)

296 commented on Jan 27, 2024 • 1 new comment

You can’t perform that action at this time.

Description of the bug

When I want to copy photos from a directory to another and when I configure the destination folder name with exif.year parameter, it crashes.

To Reproduce 1-Fichier/Import/Copy to disk 2-Source: C:\Vladicobulk\non\Pictures\import 3-Dest (Dossier de base de tout les projets): C:\Vladicobulk\non\Pictures\Photo 4-Motif de nommage du dossier projet: $(EXIF.YEAR)$(EXIF.MONTH) 5-Motif de nommage de fichiers: $(FILE.NAME).$(FILE.EXTENSION) 6-Import 7-error: "An unhandled expression occured..."

Expected behavior

It would copy toto.CR2 from C:\Vladicobulk\non\Pictures\import to C:\Vladicobulk\non\Pictures\Photo\202401\toto.CR2 by creating the dir 202401

Context

Screenshots NOP Screencast NOP

Which commit introduced the error

Don't know

System

• ansel version : 0.0.0+729~ge2c4a0a
• OS : 23H2 22631.3007

Additional context The file created during the crash is ansel_bt_82BGI2.txt: """""""""""""" this is 0.0.0+729~ge2c4a0a reporting an exception:

Error occurred on Sunday, January 28, 2024 at 09:45:15.

ansel.exe caused an Access Violation at location 00007FFDA38CC1C3 in module libansel.dll Reading from location 0000000000000000.

AddrPC Params 00007FFDA38CC1C3 00007FFDA3C630C0 00000251FCFF1070 00000251FDB0FE70 libansel.dll!dt_dev_load_image+0x173 00007FFDF93BB591 00007FFDA3998E10 00000251E6C61810 0000000000000000 libdarkroom.dll!try_enter+0x31 00007FFDA39A27C6 00000000FFFFFFFF 000000DC191FF0D8 00007FFDA3BB8DA0 libansel.dll!dt_view_manager_switch_by_view+0x86 00007FFDA3873130 0000000000000000 0000000000000000 0000000000000000 libansel.dll!dt_conf_cleanup+0x1e0 00007FFDE29032F5 0000000000000001 00007FFDA3C630C0 000002521808C200 libglib-2.0-0.dll!g_main_context_invoke_full+0x65 00007FFDE29034FA 0000000000000002 00007FFDA337AEF4 0000000000000000 libglib-2.0-0.dll!g_main_context_invoke+0x1a 00007FFDA3817369 00000251FD986F30 00000251E7651CD0 0000000000000001 libansel.dll!dt_imageio_tiff_read_profile+0x4d9 00007FFDEF344C91 00007FFDA38170E0 0000000000000000 000000DC191FF3B0 libffi-8.dll!ffi_call_win64+0x41 00007FFDEF344897 000000000000003F 0000000200020004 0000000000000005 libffi-8.dll!ffi_tramp_free+0x167 00007FFDEF344A72 00000251FD8D2CC0 000000DC191FF4F0 0000000000000014 libffi-8.dll!ffi_call+0x12 00007FFDEA718966 0000000000000000 0000000000000000 00007FFDEA71AD00 libgobject-2.0-0.dll!g_cclosure_marshal_generic+0x246 00007FFDEA718124 0000000000000000 0000000000000000 00000251FD69A830 libgobject-2.0-0.dll!g_closure_invoke+0x134 00007FFDEA72B2F7 00007FFE00000000 00007FFE00000000 00007FFDA5DEC750 libgobject-2.0-0.dll!g_param_spec_variant+0x2007 00007FFDEA731F6B 00000251E762CFC0 AF9300A3E4BC8A41 00000251FCFF1070 libgobject-2.0-0.dll!g_signal_emitv+0x1bb 00007FFDA3882701 0000000000000000 0000000000000000 0000000000000000 libansel.dll!dt_control_progress_cancellable+0xd1 00007FFDE28FEB5C 0000000000000002 00000251FCFF1070 0000000000000000 libglib-2.0-0.dll!g_clear_list+0x11ac 00007FFDE2901983 0000000000000000 00007FFDE2923E26 0000000000000000 libglib-2.0-0.dll!g_get_monotonic_time+0xa73 00007FFDE2902320 0000000000000000 0000000000000000 00007FFDA3C630C0 libglib-2.0-0.dll!g_main_loop_run+0x120 00007FFDA318BB5E 0000000000000000 00007FF74EE2406A 00007FF74EE24028 libgtk-3-0.dll!gtk_main+0x7e 00007FFDA396B46F 0002000000000001 00000251FB605040 0000000000000001 libansel.dll!dt_gui_gtk_run+0xaf 00007FF74EE22D09 00007FF74EE21560 00007FF74EE2277D 00007FFE14DA0F28 ansel.exe!0x2d09 00007FF74EE214C2 0000000000000000 00007FF74EE27048 0000000000000000 ansel.exe!0x14c2 00007FF74EE212F7 0000000000000000 0000000000000000 0000000000000000 ansel.exe!0x12f7 00007FF74EE21406 0000000000000000 0000000000000000 0000000000000000 ansel.exe!0x1406 00007FFE16FC257D 0000000000000000 0000000000000000 0000000000000000 KERNEL32.DLL!BaseThreadInitThunk+0x1d 00007FFE177AAA58 0000000000000000 0000000000000000 0000000000000000 ntdll.dll!RtlUserThreadStart+0x28

00007FF74EE20000-00007FF74EE3E000 ansel.exe 0.0.0.729 00007FFE17750000-00007FFE17967000 ntdll.dll 10.0.22621.2506 00007FFE16FB0000-00007FFE17074000 KERNEL32.DLL 10.0.22621.2506 00007FFE15000000-00007FFE153A6000 KERNELBASE.dll 10.0.22621.2792 00007FFE14CA0000-00007FFE14DB1000 ucrtbase.dll 10.0.22621.2506 00007FFDF8E30000-00007FFDF8E65000 libintl-8.dll 0.22.4.0 00007FFE16EF0000-00007FFE16FA3000 ADVAPI32.dll 10.0.22621.3007 00007FFE16890000-00007FFE16937000 msvcrt.dll 7.0.22621.2506 00007FFE17230000-00007FFE172D8000 sechost.dll 10.0.22621.3007 00007FFDE28C0000-00007FFDE2A26000 libglib-2.0-0.dll 2.78.3.0 00007FFE14E60000-00007FFE14E88000 bcrypt.dll 10.0.22621.2506 00007FFE16D30000-00007FFE16ED0000 ole32.dll 10.0.22621.2506 00007FFE154A0000-00007FFE155B7000 RPCRT4.dll 10.0.22621.2792 00007FFE14DC0000-00007FFE14E5A000 msvcp_win.dll 10.0.22621.2506 00007FFE17480000-00007FFE174A9000 GDI32.dll 10.0.22621.2792 00007FFE14B50000-00007FFE14B76000 win32u.dll 10.0.22621.3007 00007FFE14B80000-00007FFE14C98000 gdi32full.dll 10.0.22621.2861 00007FFDB9BE0000-00007FFDB9CF9000 libiconv-2.dll 1.17.0.0 00007FFE17080000-00007FFE1722E000 USER32.dll 10.0.22621.2506 00007FFE15F30000-00007FFE162B9000 combase.dll 10.0.22621.2792 00007FFE156D0000-00007FFE15F2A000 SHELL32.dll 10.0.22621.3007 00007FFE174B0000-00007FFE17521000 WS2_32.dll 10.0.22621.1 00007FFDF1690000-00007FFDF16F8000 libpcre2-8-0.dll 00007FFDA3770000-00007FFDA3D0A000 libansel.dll 00007FFE05750000-00007FFE05774000 libgcc_s_seh-1.dll 00007FFDF1740000-00007FFDF1796000 exchndl.dll 0.9.11.0 00007FFDB3E30000-00007FFDB3F5C000 libcairo-2.dll 00007FFDEDB80000-00007FFDEDBB1000 libgdk_pixbuf-2.0-0.dll 2.42.10.0 00007FFDA5D20000-00007FFDA5E68000 libgdk-3-0.dll 3.24.39.0 00007FFE175D0000-00007FFE17601000 IMM32.dll 10.0.22621.2792 00007FFDA58A0000-00007FFDA5A59000 libgio-2.0-0.dll 2.78.3.0 00007FFE16410000-00007FFE16884000 SETUPAPI.dll 10.0.22621.2506 00007FFE162C0000-00007FFE1631E000 SHLWAPI.dll 10.0.22621.2506 00007FFDEA710000-00007FFDEA76A000 libgobject-2.0-0.dll 2.78.3.0 00007FFDE8550000-00007FFDE85B5000 libpango-1.0-0.dll 1.50.14.0 00007FFE0CDA0000-00007FFE0CDB8000 libpangocairo-1.0-0.dll 1.50.14.0 00007FFE08FD0000-00007FFE08FE7000 libwinpthread-1.dll 1.0.0.0 00007FFDF9750000-00007FFDF976F000 zlib1.dll 00007FFDA2DE0000-00007FFDA3010000 libstdc++-6.dll 00007FFDEDB40000-00007FFDEDB76000 libavif-16.dll 00007FFDD9910000-00007FFDD99DC000 libcurl-4.dll 8.5.0.0 00007FFDA3010000-00007FFDA376F000 libgtk-3-0.dll 3.24.39.0 00007FFE14E90000-00007FFE14FF6000 CRYPT32.dll 10.0.22621.2506 00007FFE17360000-00007FFE173C2000 WLDAP32.dll 10.0.22621.2506 00007FFE0EE90000-00007FFE0EEA0000 libgmodule-2.0-0.dll 2.78.3.0 00007FFDA2AB0000-00007FFDA2DD7000 libexiv2.dll 00007FFE156C0000-00007FFE156C8000 PSAPI.DLL 10.0.22621.1 00007FFDEA950000-00007FFDEA99F000 libgomp-1.dll 00007FFE155C0000-00007FFE156B9000 comdlg32.dll 10.0.22621.2506 00007FFDA5BE0000-00007FFDA5D1C000 libGraphicsMagick-3.dll 00007FFE17610000-00007FFE17703000 shcore.dll 10.0.22621.2715 00007FFDC0C90000-00007FFDC0D81000 libheif.dll 00007FFDA2610000-00007FFDA27D6000 libicuuc74.dll 00007FFDB3D30000-00007FFDB3E2C000 libjpeg-8.dll 00007FFDA27E0000-00007FFDA2AAE000 libicuin74.dll 00007FFDF9130000-00007FFDF915E000 libjson-glib-1.0-0.dll 00007FFDA2300000-00007FFDA260A000 libOpenEXR-3_2.dll 00007FFDE6510000-00007FFDE657F000 liblcms2-2.dll 00007FFDE6280000-00007FFDE62F7000 libopenjp2-7.dll 00007FFDEA1E0000-00007FFDEA223000 libpng16-16.dll 00007FFDE6070000-00007FFDE60B3000 libpugixml.dll 1.14.0.0 00007FFDE24A0000-00007FFDE24F9000 libsecret-1-0.dll 00007FFDDE340000-00007FFDDE3D5000 libsoup-2.4-1.dll 00007FFDDAA40000-00007FFDDAAD3000 libtiff-6.dll 00007FFDA1A60000-00007FFDA22FE000 librsvg-2-2.dll 00007FFDA18D0000-00007FFDA1A52000 libsqlite3-0.dll 00007FFDF6000000-00007FFDF6014000 libwebpmux-3.dll 00007FFDD3190000-00007FFDD324F000 libwebp-7.dll 00007FFDA1780000-00007FFDA18C3000 libxml2-2.dll 00007FFDC0680000-00007FFDC0741000 mgwhelp.dll 0.9.11.0 00007FFE0D010000-00007FFE0D01A000 VERSION.dll 10.0.22621.1 00007FFDF8730000-00007FFDF8737000 MSIMG32.dll 10.0.22621.2506 00007FFDBD960000-00007FFDBDA24000 libfreetype-6.dll 2.13.2.0 00007FFDDE1E0000-00007FFDDE237000 libfontconfig-1.dll 00007FFDC0A00000-00007FFDC0AAF000 libpixman-1-0.dll 00007FFE11EF0000-00007FFE11F1B000 dwmapi.dll 10.0.22621.2506 00007FFDFC200000-00007FFDFC3B9000 gdiplus.dll 10.0.22621.2506 00007FFE13290000-00007FFE1329E000 HID.DLL 10.0.22621.1 00007FFE134F0000-00007FFE1351D000 IPHLPAPI.DLL 10.0.22621.1 00007FFE13560000-00007FFE13659000 DNSAPI.dll 10.0.22621.2506 00007FFE0DCA0000-00007FFE0DCD4000 WINMM.dll 10.0.22621.2506 00007FFDF4850000-00007FFDF4861000 libcairo-gobject-2.dll 00007FFDF2020000-00007FFDF204C000 libfribidi-0.dll 00007FFDA15D0000-00007FFDA177F000 libepoxy-0.dll 00007FFDF4320000-00007FFDF433F000 libpangowin32-1.0-0.dll 1.50.14.0 00007FFDEF340000-00007FFDEF351000 libffi-8.dll 00007FFDA1490000-00007FFDA15CC000 libharfbuzz-0.dll 00007FFDEEDD0000-00007FFDEEDE8000 libthai-0.dll 00007FFDED910000-00007FFDED92C000 libpangoft2-1.0-0.dll 1.50.14.0 00007FFDA09A0000-00007FFDA0B96000 libdav1d-7.dll 7.0.0.0 00007FFDA0630000-00007FFDA0995000 rav1e.dll 00007FFDECD90000-00007FFDECDA6000 libsharpyuv-0.dll 00007FFDA0BA0000-00007FFDA1484000 libaom.dll 00007FFDA5790000-00007FFDA5891000 libyuv.dll 00007FFDEBF10000-00007FFDEBF27000 libbrotlidec.dll 00007FFD9FE40000-00007FFDA0623000 libSvtAv1Enc.dll 00007FFDE2870000-00007FFDE28B2000 libidn2-0.dll 00007FFD9F960000-00007FFD9FE31000 libcrypto-3-x64.dll 3.2.0.0 00007FFDEA3A0000-00007FFDEA3C2000 libpsl-5.dll 00007FFDEA6D0000-00007FFDEA707000 libnghttp2-14.dll 1.58.0.0 00007FFDE23B0000-00007FFDE23FE000 libssh2-1.dll 1.11.0.0 00007FFD9F870000-00007FFD9F954000 libssl-3-x64.dll 3.2.0.0 00007FFD9F750000-00007FFD9F86E000 libzstd.dll 00007FFE07640000-00007FFE078D3000 COMCTL32.dll 6.10.22621.2506 00007FFDEBEF0000-00007FFDEBF0A000 libbz2-1.dll 00007FFDE0B90000-00007FFDE0BC4000 libexpat-1.dll 00007FFDEAED0000-00007FFDEAEE8000 libltdl-7.dll 00007FFDBDEA0000-00007FFDBDF5A000 libde265-0.dll 00007FFDF05A0000-00007FFDF0648000 WINSPOOL.DRV 10.0.22621.2506 00007FFD9E3F0000-00007FFD9F742000 libx265.dll 3.4.0.31 00007FFDE8920000-00007FFDE894E000 libatk-1.0-0.dll 2.50.0.0 00007FFDDD330000-00007FFDDD388000 libImath-3_1.dll 00007FFDEA440000-00007FFDEA452000 libIlmThread-3_2.dll 00007FFDDA980000-00007FFDDA9E0000 libIex-3_2.dll 00007FFD9C440000-00007FFD9C67E000 libOpenEXRCore-3_2.dll 00007FFDEA040000-00007FFDEA05C000 libdeflate.dll 00007FFD9C2F0000-00007FFD9C436000 libgcrypt-20.dll 1.10.3.0 00007FFDE99C0000-00007FFDE99D7000 libjbig-0.dll 00007FFDB8BF0000-00007FFDB8CB1000 libLerc.dll 00007FFDDE2A0000-00007FFDDE2D5000 liblzma-5.dll 5.4.5.0 00007FFE13F90000-00007FFE13FBC000 USERENV.dll 10.0.22621.2506 00007FFE12490000-00007FFE126C3000 dbghelp.dll 10.0.22621.2506 00007FFE16330000-00007FFE16407000 OLEAUT32.dll 10.0.22621.2506 00007FFE104E0000-00007FFE10753000 DWrite.dll 10.0.22621.2506 00007FFDE0020000-00007FFDE0039000 USP10.dll 10.0.22621.1 00007FFDE61C0000-00007FFDE61EC000 libgraphite2.dll 00007FFE0ED20000-00007FFE0ED30000 libdatrie-1.dll 00007FFDE2470000-00007FFDE249D000 libbrotlicommon.dll 00007FFD9C100000-00007FFD9C2ED000 libunistring-5.dll 1.1.0.0 00007FFD9C680000-00007FFD9E3E9000 libicudt74.dll 00007FFDD9670000-00007FFDD96AC000 libgpg-error-0.dll 1.47.0.0 00007FFE09700000-00007FFE09732000 dbgcore.DLL 10.0.22621.1 00007FFE14220000-00007FFE1422C000 CRYPTBASE.DLL 10.0.22621.1 00007FFE15420000-00007FFE1549A000 bcryptPrimitives.dll 10.0.22621.2506 00007FFE16B00000-00007FFE16B09000 NSI.dll 10.0.22621.1 00007FFE13A20000-00007FFE13A38000 kernel.appcore.dll 10.0.22621.2715 00007FFE12990000-00007FFE13286000 windows.storage.dll 10.0.22621.2792 00007FFE12850000-00007FFE1298E000 wintypes.dll 10.0.22621.2792 00007FFE0F040000-00007FFE0F177000 winhttp.dll 10.0.22621.2506 00007FFDEEC90000-00007FFDEEC96000 KBDFR.DLL 10.0.22621.1 00007FFE11C70000-00007FFE11D1B000 uxtheme.dll 10.0.22621.3007 00007FFE16990000-00007FFE16AE0000 MSCTF.dll 10.0.22621.2792 00007FFE14660000-00007FFE1468C000 DEVOBJ.dll 10.0.22621.2506 00007FFE14690000-00007FFE146DE000 cfgmgr32.dll 10.0.22621.2506 00007FFE153B0000-00007FFE1541B000 WINTRUST.dll 10.0.22621.3007 00007FFE14290000-00007FFE142A2000 MSASN1.dll 10.0.22621.2506 00007FFE173D0000-00007FFE17480000 clbcatq.dll 2001.12.10941.16384 00007FFDD5F80000-00007FFDD5FFE000 OpenCL.dll 3.0.1.0 00007FFE11D80000-00007FFE11DB6000 dxcore.dll 10.0.22621.2506 00007FFE095C0000-00007FFE096F5000 AppXDeploymentClient.dll 10.0.22621.2792 00007FFD9B380000-00007FFD9C0FA000 amdocl64.dll 31.0.21024.5005 00007FFDE2AF0000-00007FFDE2BF0000 OPENGL32.dll 10.0.22621.2506 00007FFE05970000-00007FFE0599D000 GLU32.dll 10.0.22621.2506 00007FFD97140000-00007FFD9B37E000 amdhsail64.dll 00007FFD75500000-00007FFD7BA46000 amd_comgr.dll 00007FFE149C0000-00007FFE149E6000 profapi.dll 10.0.22621.2506 00007FFDE5FF0000-00007FFDE5FF9000 IconCodecService.dll 10.0.22621.1 00007FFE10330000-00007FFE104E0000 WindowsCodecs.dll 10.0.22621.2506 00007FFDF1460000-00007FFDF155C000 Windows.ApplicationModel.dll 10.0.22621.2506 00007FFDEF690000-00007FFDEF77B000 Windows.StateRepositoryPS.dll 10.0.22621.2792 00007FFE0CD40000-00007FFE0CD63000 Windows.StateRepositoryBroker.dll 10.0.22621.2792 00007FFE0F3C0000-00007FFE0F4C1000 propsys.dll 7.0.22621.2506 00007FFDEBAD0000-00007FFDEBAF6000 mssprxy.dll 7.0.22621.2792 00007FFDFD400000-00007FFDFD518000 mrmcorer.dll 10.0.22621.2506 00007FFE06940000-00007FFE06BFC000 iertutil.dll 11.0.22621.3007 00007FFE0D050000-00007FFE0D06A000 windows.staterepositorycore.dll 10.0.22621.2792 00007FFE08030000-00007FFE0806D000 windows.staterepositoryclient.dll 10.0.22621.2792 00007FFDFC160000-00007FFDFC192000 bcp47mrm.dll 10.0.22621.2506 00007FFDFD050000-00007FFDFD1C4000 Windows.UI.dll 10.0.22621.2506 00007FFE0FAA0000-00007FFE0FAB0000 libpixbufloader-png.dll 00007FFDE11B0000-00007FFDE126C000 mscms.dll 10.0.22621.2506 00007FFDF17A0000-00007FFDF17E9000 icm32.dll 10.0.22621.2506 00007FFDF61F0000-00007FFDF633A000 textinputframework.dll 10.0.22621.2792 00007FFE11620000-00007FFE11754000 CoreMessaging.dll 10.0.22621.3007 00007FFE0DFE0000-00007FFE0E34C000 CoreUIComponents.dll 10.0.22621.2506 00007FFDF93B0000-00007FFDF93D2000 libdarkroom.dll 00007FFE0EF40000-00007FFE0EF4F000 liblighttable.dll 00007FFE09070000-00007FFE0907F000 libavif.dll 00007FFE09050000-00007FFE0905D000 libcopy.dll 00007FFDF9390000-00007FFDF93A6000 libexr.dll 00007FFE09030000-00007FFE0903E000 libj2k.dll 00007FFE08F20000-00007FFE08F2E000 libjpeg.dll 00007FFE084C0000-00007FFE084D0000 libpdf.dll 00007FFE060A0000-00007FFE060AD000 libpfm.dll 00007FFE05B90000-00007FFE05B9F000 libpng.dll 00007FFDFD810000-00007FFDFD81D000 libppm.dll 00007FFDFD570000-00007FFDFD57F000 libtiff.dll 00007FFDF9F50000-00007FFDF9F5F000 libwebp.dll 00007FFDF48B0000-00007FFDF48C3000 libxcf.dll 00007FFDF96E0000-00007FFDF96EF000 libdisk.dll 00007FFDF8EE0000-00007FFDF8EF0000 libgallery.dll 00007FFDF4890000-00007FFDF48A1000 libpiwigo.dll 00007FFDF1830000-00007FFDF1858000 libashift.dll 00007FFDF4870000-00007FFDF4889000 libatrous.dll 00007FFDF1810000-00007FFDF1830000 libbasecurve.dll 00007FFDF17F0000-00007FFDF1806000 libbasicadj.dll 00007FFDF5FF0000-00007FFDF5FFF000 libbilat.dll 00007FFDE64F0000-00007FFDE6501000 libbilateral.dll 00007FFDF19F0000-00007FFDF19FE000 libbloom.dll 00007FFDE6260000-00007FFDE6271000 libblurs.dll 00007FFDE6050000-00007FFDE6061000 libborders.dll 00007FFDE5250000-00007FFDE5266000 libcacorrect.dll 00007FFDF1680000-00007FFDF1690000 libcacorrectrgb.dll 00007FFDEF5D0000-00007FFDEF5DE000 libcensorize.dll 00007FFDEF330000-00007FFDEF340000 libchannelmixer.dll 00007FFDDE490000-00007FFDDE4BD000 libchannelmixerrgb.dll 00007FFDECD80000-00007FFDECD8E000 libclahe.dll 00007FFDE3130000-00007FFDE314C000 libclipping.dll 00007FFDEA1D0000-00007FFDEA1DE000 libcolisa.dll 00007FFDDDD30000-00007FFDDDD4B000 libcolorbalance.dll 00007FFDDD310000-00007FFDDD32B000 libcolorbalancergb.dll 00007FFDDAC30000-00007FFDDAC4B000 libcolorchecker.dll 00007FFDEA100000-00007FFDEA10E000 libcolorcontrast.dll 00007FFDE9C30000-00007FFDE9C40000 libcolorcorrection.dll 00007FFDDAA20000-00007FFDDAA39000 libcolorin.dll 00007FFDE9540000-00007FFDE954E000 libcolorize.dll 00007FFDD98F0000-00007FFDD9903000 libcolormapping.dll 00007FFDD5640000-00007FFDD5651000 libcolorout.dll 00007FFDD5620000-00007FFDD5633000 libcolorreconstruct.dll 00007FFDE0EA0000-00007FFDE0EAF000 libcolortransfer.dll 00007FFDD5600000-00007FFDD561C000 libcolorzones.dll 00007FFDD55E0000-00007FFDD55F4000 libcrop.dll 00007FFDE0B80000-00007FFDE0B8F000 libdefringe.dll 00007FFDD3100000-00007FFDD314D000 libdemosaic.dll 00007FFDD37F0000-00007FFDD380E000 libdenoiseprofile.dll 00007FFDC3110000-00007FFDC3125000 libdiffuse.dll 00007FFDDE330000-00007FFDDE33F000 libdither.dll 00007FFDC30F0000-00007FFDC3105000 libequalizer.dll 00007FFDC30D0000-00007FFDC30E2000 libexposure.dll 00007FFDC30B0000-00007FFDC30C6000 libfilmic.dll 00007FFDC1820000-00007FFDC184B000 libfilmicrgb.dll 00007FFDDE290000-00007FFDDE29D000 libfinalscale.dll 00007FFDDE120000-00007FFDDE12F000 libflip.dll 00007FFDDDFA0000-00007FFDDDFB0000 libgamma.dll 00007FFDD98E0000-00007FFDD98F0000 libglobaltonemap.dll 00007FFDC1800000-00007FFDC1812000 libgraduatednd.dll 00007FFDD9660000-00007FFDD966E000 libgrain.dll 00007FFDD5F50000-00007FFDD5F60000 libhazeremoval.dll 00007FFDC16E0000-00007FFDC16FA000 libhighlights.dll 00007FFDD55D0000-00007FFDD55DE000 libhighpass.dll 00007FFDD37E0000-00007FFDD37EF000 libhotpixels.dll 00007FFDD3780000-00007FFDD3790000 libinvert.dll 00007FFDC16B0000-00007FFDC16D1000 liblens.dll 00007FFDC1680000-00007FFDC16A8000 liblensfun.dll 00007FFDC30A0000-00007FFDC30AD000 libsystre-0.dll 00007FFDC1660000-00007FFDC167F000 libtre-5.dll 00007FFDC1240000-00007FFDC1251000 liblevels.dll 00007FFDC1220000-00007FFDC123A000 libliquify.dll 00007FFDC0890000-00007FFDC08A2000 liblowlight.dll 00007FFDC2080000-00007FFDC2090000 liblowpass.dll 00007FFDC05C0000-00007FFDC05E0000 liblut3d.dll 00007FFD93440000-00007FFD93F28000 libgmic.dll 00007FFDBE800000-00007FFDBE811000 libfftw3_threads-3.dll 00007FFDBE7A0000-00007FFDBE7FA000 libGraphicsMagick++-12.dll 00007FFD96CF0000-00007FFD97139000 libopencv_core-409.dll 4.9.0.0 00007FFDA3EE0000-00007FFDA42F2000 libfftw3-3.dll 00007FFDB9B30000-00007FFDB9BD9000 libopencv_videoio-409.dll 4.9.0.0 00007FFDBC600000-00007FFDBC666000 libtbb12.dll 2021.11.0.0 00007FFD8D2C0000-00007FFD8FD4D000 libopenblas.dll 00007FFDB7420000-00007FFDB7692000 avformat-60.dll 60.16.100.0 00007FFD90E60000-00007FFD9230F000 avcodec-60.dll 60.31.102.0 00007FFDB90D0000-00007FFDB90EB000 libgstapp-1.0-0.dll 00007FFDB8E30000-00007FFDB8EB7000 libgstaudio-1.0-0.dll 00007FFDB8DA0000-00007FFDB8E24000 libgstbase-1.0-0.dll 00007FFDB9080000-00007FFDB90C3000 libgstpbutils-1.0-0.dll 00007FFD8C190000-00007FFD8D2BC000 avutil-58.dll 58.29.100.0 00007FFDB6EC0000-00007FFDB7000000 libgstreamer-1.0-0.dll 00007FFDB8D80000-00007FFDB8D9A000 libgstriff-1.0-0.dll 00007FFDB6DF0000-00007FFDB6EBB000 libgstvideo-1.0-0.dll 00007FFDB8CD0000-00007FFDB8D76000 swscale-7.dll 7.5.100.0 00007FFDB7BE0000-00007FFDB7C58000 libopencv_imgcodecs-409.dll 4.9.0.0 00007FFD92D90000-00007FFD93435000 libopencv_imgproc-409.dll 4.9.0.0 00007FFD969D0000-00007FFD96CE8000 libgfortran-5.dll 00007FFDB73C0000-00007FFDB7416000 libgme.dll 00007FFDB79C0000-00007FFDB7A23000 libbluray-2.dll 00007FFD92B80000-00007FFD92D82000 libgnutls-30.dll 00007FFDB6DC0000-00007FFDB6DEF000 librtmp-1.dll 00007FFDA3DF0000-00007FFDA3EDB000 libmodplug-1.dll 00007FFDA3D20000-00007FFDA3DEB000 libsrt.dll 00007FFDB6C90000-00007FFDB6CA7000 libgsm.dll 00007FFDB6D30000-00007FFDB6DB3000 libssh.dll 00007FFDB5910000-00007FFDB5992000 libmp3lame-0.dll 00007FFDB6C50000-00007FFDB6C82000 libopencore-amrnb-0.dll 00007FFDB6C30000-00007FFDB6C50000 libopencore-amrwb-0.dll 00007FFDB62C0000-00007FFDB62E9000 libspeex-1.dll 00007FFDB60C0000-00007FFDB612B000 libopus-0.dll 00007FFDB4AF0000-00007FFDB4B0F000 libtheoradec-1.dll 00007FFDB4AB0000-00007FFDB4AEE000 libtheoraenc-1.dll 00007FFDA4C20000-00007FFDA4C53000 libvorbis-0.dll 00007FFDA4BD0000-00007FFDA4C12000 libva.dll 00007FFD92AE0000-00007FFD92B75000 libvorbisenc-2.dll 00007FFD92A70000-00007FFD92ADB000 libvpl.dll 2.10.0.0 00007FFD92700000-00007FFD92A6F000 libvpx-1.dll 00007FFD90B70000-00007FFD90E54000 libx264-164.dll 0.164.3161.0 00007FFD925D0000-00007FFD926F1000 xvidcore.dll 00007FFDB4A80000-00007FFDB4AA9000 swresample-4.dll 4.12.100.0 00007FFD92570000-00007FFD925CB000 liborc-0.4-0.dll 00007FFD92520000-00007FFD9256D000 libgsttag-1.0-0.dll 00007FFDC1210000-00007FFDC121D000 libva_win32.dll 00007FFD924B0000-00007FFD92514000 libquadmath-0.dll 00007FFD90A00000-00007FFD90AAD000 libgmp-10.dll 00007FFD90AB0000-00007FFD90B68000 libbrotlienc.dll 00007FFD909B0000-00007FFD909FC000 libhogweed-6.dll 00007FFE14350000-00007FFE1437E000 ncrypt.dll 10.0.22621.3007 00007FFD90950000-00007FFD909A9000 libnettle-8.dll 00007FFD905A0000-00007FFD90703000 libp11-kit-0.dll 00007FFDB3D10000-00007FFDB3D30000 libtasn1-6.dll 00007FFDF7410000-00007FFDF7419000 WSOCK32.dll 10.0.22621.1 00007FFDA4BB0000-00007FFDA4BC3000 libogg-0.dll 00007FFD8C100000-00007FFD8C187000 libsoxr.dll 00007FFE14310000-00007FFE14347000 NTASN1.dll 10.0.22621.1 00007FFDC0C80000-00007FFDC0C8D000 libmask_manager.dll 00007FFD969B0000-00007FFD969C1000 libmonochrome.dll 00007FFD92490000-00007FFD924A3000 libnegadoctor.dll 00007FFDC0920000-00007FFDC092E000 libnlmeans.dll 00007FFDBFF20000-00007FFDBFF2F000 liboverexposed.dll 00007FFDBC560000-00007FFDBC570000 libprofile_gamma.dll 00007FFD92470000-00007FFD92483000 librawdenoise.dll 00007FFDB9A70000-00007FFDB9A7F000 librawoverexposed.dll 00007FFD90930000-00007FFD90942000 librawprepare.dll 00007FFDB8CC0000-00007FFDB8CCE000 librelight.dll 00007FFD90910000-00007FFD9092E000 libretouch.dll 00007FFD908F0000-00007FFD9090A000 librgbcurve.dll 00007FFD908D0000-00007FFD908E4000 librgblevels.dll 00007FFDB7BD0000-00007FFDB7BDE000 librotatepixels.dll 00007FFDB6C20000-00007FFDB6C2E000 libscalepixels.dll 00007FFD90580000-00007FFD90593000 libshadhi.dll 00007FFDB5900000-00007FFDB5910000 libsharpen.dll 00007FFDA5BD0000-00007FFDA5BDE000 libsoften.dll 00007FFDA5780000-00007FFDA5790000 libsplittoning.dll 00007FFD90560000-00007FFD90571000 libspots.dll 00007FFD8BFF0000-00007FFD8C0FA000 libtemperature.dll 00007FFD90540000-00007FFD90559000 libtonecurve.dll 00007FFD8FE30000-00007FFD8FE59000 libtoneequal.dll 00007FFDA4BA0000-00007FFDA4BAF000 libtonemap.dll 00007FFDA3D10000-00007FFDA3D1E000 libvelvia.dll 00007FFD90530000-00007FFD9053D000 libvibrance.dll 00007FFD8FE10000-00007FFD8FE21000 libvignette.dll 00007FFD8BFD0000-00007FFD8BFE4000 libwatermark.dll 00007FFD8BFB0000-00007FFD8BFC3000 libzonesystem.dll 00007FFD8FE00000-00007FFD8FE0D000 libbackgroundjobs.dll 00007FFD8BF90000-00007FFD8BFAB000 libcollect.dll 00007FFD8BF70000-00007FFD8BF81000 libcolorpicker.dll 00007FFD8BF60000-00007FFD8BF70000 libduplicate.dll 00007FFD8BF40000-00007FFD8BF57000 libexport.dll 00007FFD8BF30000-00007FFD8BF3D000 libfilmstrip.dll 00007FFD8BF20000-00007FFD8BF2F000 libfilter.dll 00007FFD8BF00000-00007FFD8BF16000 libgeotagging.dll 00007FFD8BEE0000-00007FFD8BF00000 libosmgpsmap-1.0-1.dll 00007FFD8BED0000-00007FFD8BEDD000 libhinter.dll 00007FFD8BEB0000-00007FFD8BEC8000 libhistogram.dll 00007FFD8BE90000-00007FFD8BEA4000 libhistory.dll 00007FFD8BE80000-00007FFD8BE8D000 libimage_infos.dll 00007FFD8BE70000-00007FFD8BE7D000 libioporder.dll 00007FFD8BE60000-00007FFD8BE6D000 liblighttable_mode.dll 00007FFD8BE50000-00007FFD8BE5F000 liblocation.dll 00007FFD8BE30000-00007FFD8BE41000 libmap_locations.dll 00007FFD8BE20000-00007FFD8BE2E000 libmap_settings.dll 00007FFD8BE00000-00007FFD8BE16000 libmasks.dll 00007FFD8BDF0000-00007FFD8BDFD000 libmasktoolbar.dll 00007FFD8BDC0000-00007FFD8BDE2000 libmenu.dll 00007FFD8BDB0000-00007FFD8BDBD000 libmenubuttons.dll 00007FFD8BD90000-00007FFD8BDA1000 libmetadata.dll 00007FFD8BD70000-00007FFD8BD82000 libmetadata_view.dll 00007FFD8BD50000-00007FFD8BD69000 libmidi.dll 00007FFD8BD30000-00007FFD8BD41000 libportmidi.dll 00007FFE024B0000-00007FFE024D9000 winmmbase.dll 10.0.22621.1 00007FFE09440000-00007FFE094DD000 MMDevAPI.DLL 10.0.22621.2506 00007FFDED6E0000-00007FFDED726000 wdmaud.drv 10.0.22621.1 00007FFE0F2A0000-00007FFE0F2AB000 AVRT.dll 10.0.22621.2506 00007FFE05520000-00007FFE05529000 ksuser.dll 10.0.22621.1 00007FFDF7450000-00007FFDF763C000 AUDIOSES.DLL 10.0.22621.2506 00007FFDF9050000-00007FFDF905E000 msacm32.drv 10.0.22621.2506 00007FFDEDB20000-00007FFDEDB3E000 MSACM32.dll 10.0.22621.1 00007FFDEFD90000-00007FFDEFD9B000 midimap.dll 10.0.22621.2506 00007FFD8BD20000-00007FFD8BD2F000 libmodulegroups.dll 00007FFD8BD10000-00007FFD8BD1D000 libmodule_toolbox.dll 00007FFD8BD00000-00007FFD8BD10000 libnavigation.dll 00007FFD8BCF0000-00007FFD8BCFF000 libsnapshots.dll 00007FFD8BCD0000-00007FFD8BCE1000 libstyles.dll 00007FFD8BCB0000-00007FFD8BCCC000 libtagging.dll 00007FFD8BCA0000-00007FFD8BCAD000 libview_toolbox.dll 00007FFD8BC90000-00007FFD8BC9D000 libpixbufloader-svg.dll 00007FFE13EF0000-00007FFE13F59000 mswsock.dll 10.0.22621.2506 00007FFD8BC80000-00007FFD8BC88000 wshunix.dll 10.0.22621.1 00007FFDFADE0000-00007FFDFADFE000 MPR.dll 10.0.22621.1 00007FFDE30A0000-00007FFDE30C9000 p9np.dll 10.0.22621.2506 00007FFDEBAC0000-00007FFDEBACC000 drprov.dll 10.0.22621.1 00007FFDE6630000-00007FFDE6649000 ntlanman.dll 10.0.22621.2506 00007FFDE0AF0000-00007FFDE0B0F000 davclnt.dll 10.0.22621.1 00007FFE14710000-00007FFE14776000 WINSTA.dll 10.0.22621.2506 00007FFE0E890000-00007FFE0E8AA000 wkscli.dll 10.0.22621.2506 00007FFDF1A00000-00007FFDF1A12000 cscapi.dll 10.0.22621.1 00007FFE134E0000-00007FFE134EC000 netutils.dll 10.0.22621.2506 00007FFDE2AD0000-00007FFDE2AE1000 libpixbufloader-jpeg.dll 00007FFD90710000-00007FFD908CC000 DUI70.dll 10.0.22621.2506 00007FFDB4B90000-00007FFDB4C29000 DUser.dll 10.0.22621.1 00007FFDF6590000-00007FFDF6640000 TextShaping.dll 10.0.22621.2506 00007FFDF19C0000-00007FFDF19E8000 edputil.dll 10.0.22621.1 00007FFDF7790000-00007FFDF77F9000 oleacc.dll 7.2.22621.1 00007FFDDB9F0000-00007FFDDBA5B000 thumbcache.dll 10.0.22621.2506 00007FFDF4C20000-00007FFDF4C7E000 dataexchange.dll 10.0.22621.2506 00007FFE0C950000-00007FFE0CBD5000 twinapi.appcore.dll 10.0.22621.2506 00007FFDF7130000-00007FFDF72EB000 Windows.Globalization.dll 10.0.22621.2506 00007FFDF1650000-00007FFDF1679000 globinputhost.dll 10.0.22621.2792 00007FFDFD730000-00007FFDFD790000 Bcp47Langs.dll 10.0.22621.2506 00007FFE0F2D0000-00007FFE0F307000 xmllite.dll 10.0.22621.2506 00007FFE03EA0000-00007FFE03F5B000 StructuredQuery.dll 7.0.22621.2506 00007FFE0C020000-00007FFE0C645000 OneCoreUAPCommonProxyStub.dll 10.0.22621.2792 00007FFDF4C80000-00007FFDF4C8E000 atlthunk.dll 10.0.22621.1 00007FFDD3EF0000-00007FFDD3F95000 Windows.FileExplorer.Common.dll 10.0.22621.2506 00007FFDEF820000-00007FFDEF8CB000 OneCoreCommonProxyStub.dll 10.0.22621.3007 00007FFDEF240000-00007FFDEF329000 Windows.Storage.Search.dll 10.0.22621.2506 00007FFDE3200000-00007FFDE36F3000 windowsudk.shellcommon.dll 10.0.22621.3007 00007FFDFA000000-00007FFDFA175000 Windows.UI.Immersive.dll 10.0.22621.2506 00007FFE0F9A0000-00007FFE0FA45000 policymanager.dll 10.0.22621.2792 00007FFE0F8F0000-00007FFE0F983000 msvcp110_win.dll 10.0.22621.1 00007FFE172E0000-00007FFE1735F000 coml2.dll 10.0.22621.2506 00007FFDEA870000-00007FFDEA87D000 LINKINFO.dll 10.0.22621.1 00007FFE11900000-00007FFE11997000 apphelp.dll 10.0.22621.2506 00007FFDDE2E0000-00007FFDDE2FA000 NetworkExplorer.dll 10.0.22621.1 00007FFE08070000-00007FFE081A5000 Windows.System.Launcher.dll 10.0.22621.2506 00007FFDC07F0000-00007FFDC0847000 dlnashext.dll 10.0.22621.2715 00007FFD8BC10000-00007FFD8BC79000 PlayToDevice.dll 10.0.22621.1 00007FFE011D0000-00007FFE011F1000 DevDispItemProvider.dll 10.0.22621.2506 00007FFDDBC10000-00007FFDDBCA4000 ntshrui.dll 10.0.22621.2506 00007FFE13CE0000-00007FFE13D23000 SspiCli.dll 10.0.22621.3007 00007FFE06C00000-00007FFE06C28000 srvcli.dll 10.0.22621.2506 00007FFD8FD50000-00007FFD8FDF3000 wpdshext.dll 10.0.22621.2715 00007FFDD3650000-00007FFDD36EE000 PortableDeviceApi.dll 10.0.22621.1 00007FFDDADF0000-00007FFDDAE27000 EhStorShell.dll 10.0.22621.1 00007FFD8BBE0000-00007FFD8BC04000 EhStorAPI.dll 10.0.22621.1 00007FFE13830000-00007FFE13844000 WTSAPI32.dll 10.0.22621.1 00007FFDDAD10000-00007FFDDADE2000 cscui.dll 10.0.22621.2506 00007FFDDE4F0000-00007FFDDE51D000 cldapi.dll 10.0.22621.2506 00007FFDDC4B0000-00007FFDDC759000 explorerframe.dll 10.0.22621.2792

Windows 10.0.22621.2506 DrMingw 0.9.11 """"""""""""""""""

What you try to do is impossible.

$EXIF_YEAR is a property of picture files that you can re-use to rename them. Folders have no EXIF properties and therefore you can't use the $EXIF_xxx variables on them (move, import, rename, etc.).

Folders have their own way of declaring date, which uses the GUI value from import dialog: $YEAR, $MONTH, $DAY.

Not sure what can be done from GUI to prevent users from trying to use EXIF variables in folders naming.

Bonjour. Merci pour la réponse. J aurais voulu faire comme sur darktable où les exif des photos sont utilisés pour nommer les répertoires et ainsi faire comme sur lightroom. Je me suis peut être mal fais comprendre sur mon ticket github. Ce que j'ai fais c est que d'utiliser darktable pour l import (in avouable ;)) et j ajoute les photos ainsi importés dans la collection d'Ansel.  C est peut être osé de mixer les deux mais ça va le faire. Dans le pire des cas J abîme les xmp. Courage pour Ansel. J espère que ça va prendre. Cordialement

Elie

⁣Get BlueMail for Android ​

On Jan 29, 2024, 5:34 PM, at 5:34 PM, "Aurélien PIERRE" @.***> wrote:

What you try to do is impossible.

$EXIF_YEAR is a property of picture files that you can re-use to rename them. Folders have no EXIF properties and therefore you can't use the $EXIF_xxx variables on them (move, import, rename, etc.).

Folders have their own way of declaring date, which uses the GUI value from import dialog: $YEAR, $MONTH, $DAY.

Not sure what can be done from GUI to prevent users from trying to use EXIF variables in folders naming.

-- Reply to this email directly or view it on GitHub: https://github.com/aurelienpierreeng/ansel/issues/320#issuecomment-1915086531 You are receiving this because you authored the thread.

Message ID: @.***>

Je ne comprends pas le but recherché par rapport au workflow et le problème ici.

L'option "copy to disk" créée un nouveau dossier dont le nom est spécifié à l'import. Utiliser les valeurs EXIF n'a pas de sens à ce niveau (peu import si darktable ou lightroom le permettent ou pas) puisque les EXIFs sont la propriété des images.

Quel est le comportement désiré si un événement (au hasard: un mariage) a des photos prises avant et après minuit ? On divise le set de photos en deux arbitrairement en fonction de la date des photos ? L'utilisation globale des EXIFs au niveau des dossiers est un non-sens de design. L'utilisation d'une date spécifiée manuellement lève les ambiguités et les limite les problèmes possibles.

Bonsoir. En effet je comprends votre point de vu. J ai toujours fait en sorte de pouvoir me passer des logiciel de traitement d image au cas où ils deviennent indisponibles. C est pourquoi je profite de cette capacité pour ranger mes photo comme ça. Je sais que je pourrais les ordonner avec des tags par exemple. Par ailleurs je ne suis pas pro, je ne suis pas organisé, je travaille les photos par projet quand J en ai le temps mais étant en plus assez irrégulier, les automatisations des logiciels me sont d une grande utilité. Pour gérer mes sauvegardes aussi c est pratique d avoir une régularité chronologique

Mais si Ansel ne le fait pas c est pas grave.

Bon courage.

Cordialement.

On Jan 29, 2024, 8:14 PM, at 8:14 PM, "Aurélien PIERRE" @.***> wrote:

Je ne comprends pas le but recherché par rapport au workflow et le problème ici.

L'option "copy to disk" créée un nouveau dossier dont le nom est spécifié à l'import. Utiliser les valeurs EXIF n'a pas de sens à ce niveau (peu import si darktable ou lightroom le permettent ou pas) puisque les EXIFs sont la propriété des images.

Quel est le comportement désiré si un événement (au hasard: un mariage) a des photos prises avant et après minuit ? On divise le set de photos en deux arbitrairement en fonction de la date des photos ? L'utilisation globale des EXIFs au niveau des dossiers est un non-sens de design. L'utilisation d'une date spécifiée manuellement lève les ambiguités et les limite les problèmes possibles.

-- Reply to this email directly or view it on GitHub: https://github.com/aurelienpierreeng/ansel/issues/320#issuecomment-1915391596 You are receiving this because you authored the thread.

Message ID: @.***>

CI: update to latest conan 1

Signed-off-by: Rosen Penev

Refs. https://github.com/darktable-org/rawspeed/issues/403 Refs. https://github.com/darktable-org/darktable/issues/14969 Refs. https://github.com/darktable-org/darktable/issues/15480 Refs. https://github.com/darktable-org/darktable/issues/13782

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (c7cd7ff) 60.72% compared to head (f3bf815) 60.95%.

@@ Coverage Diff @@
## develop #629 +/- ##
===========================================
+ Coverage 60.72% 60.95% +0.22% 
===========================================
 Files 265 266 +1 
 Lines 15841 15917 +76 
 Branches 2042 2053 +11 
===========================================
+ Hits 9620 9702 +82 
+ Misses 6095 6084 -11 
- Partials 126 131 +5 

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.

This is roughly it i guess, now "just" need to benchmark things...

Merge pull request #628 from LebedevRI/ci

Bump all(?) github actions to their latest versions